Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-19 Thread Daniel P . Berrangé
On Tue, Apr 18, 2023 at 05:18:04PM +, Nick Guenther wrote: > April 18, 2023 3:37 AM, "Peter Krempa" wrote: > > In fact libvirt is already using this folder for tracking qemu's PIDs: > > /run/user/703204575/libvirt/qemu > └── run > ├── abcdefg.pid > ├── abcdefg.xml > ├── abcdef.pi

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-19 Thread Michal Prívozník
On 4/19/23 04:13, Laine Stump wrote: > On 4/18/23 1:18 PM, Nick Guenther wrote: >> April 18, 2023 3:37 AM, "Peter Krempa" wrote: >> >>> cases of code style not being aligned from what libvirt does normally >>> ... >> >> I'm very happy to conform my style as needed. I just want my users to >> be ab

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Laine Stump
On 4/18/23 1:18 PM, Nick Guenther wrote: April 18, 2023 3:37 AM, "Peter Krempa" wrote: cases of code style not being aligned from what libvirt does normally ... I'm very happy to conform my style as needed. I just want my users to be able to use libvirt (if they can't I'll teach them to use

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Nick Guenther
April 18, 2023 3:37 AM, "Peter Krempa" wrote: > cases of code style not being aligned from what libvirt does normally ... I'm very happy to conform my style as needed. I just want my users to be able to use libvirt (if they can't I'll teach them to use qemu directly I suppose but that's annoy

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Daniel P . Berrangé
On Tue, Apr 18, 2023 at 02:59:26AM -0400, Nick Guenther wrote: > The qemu driver creates IPC sockets using absolute paths, > but under POSIX socket paths are constrained pretty tightly. > On systems with homedirs on an unusual mount point, like > network homedirs, or just particularly long username

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Peter Krempa
On Tue, Apr 18, 2023 at 02:59:26 -0400, Nick Guenther wrote: > The qemu driver creates IPC sockets using absolute paths, > but under POSIX socket paths are constrained pretty tightly. > On systems with homedirs on an unusual mount point, like > network homedirs, or just particularly long usernames,

[libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Nick Guenther
The qemu driver creates IPC sockets using absolute paths, but under POSIX socket paths are constrained pretty tightly. On systems with homedirs on an unusual mount point, like network homedirs, or just particularly long usernames, this could make starting VMs under qemu:///session impossible. Reso