Re: [libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-30 Thread Daniel P . Berrangé
On Fri, Mar 27, 2020 at 08:40:31PM +0100, Andrea Bolognani wrote: > On Fri, 2020-03-27 at 16:52 +0100, Michal Prívozník wrote: > > On 27. 3. 2020 16:42, Daniel P. Berrangé wrote: > > > > > +if (priv->escapeChar[0] == '^') { > > > > > +vshPrintExtra(ctl, " (Ctrl + %c)", priv->escapeChar[

Re: [libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-27 Thread Andrea Bolognani
On Fri, 2020-03-27 at 16:52 +0100, Michal Prívozník wrote: > On 27. 3. 2020 16:42, Daniel P. Berrangé wrote: > > > > +if (priv->escapeChar[0] == '^') { > > > > +vshPrintExtra(ctl, " (Ctrl + %c)", priv->escapeChar[1]); > > > > +} > > > > I'll remove the {} to keep syntax-check happy

Re: [libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-27 Thread Michal Prívozník
On 27. 3. 2020 16:42, Daniel P. Berrangé wrote: > On Fri, Mar 27, 2020 at 04:34:48PM +0100, Michal Prívozník wrote: >> On 27. 3. 2020 16:11, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> tools/virsh-domain.c | 6 +- >>> 1 file changed, 5 insertions(+), 1 deletion

Re: [libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-27 Thread Daniel P . Berrangé
On Fri, Mar 27, 2020 at 04:34:48PM +0100, Michal Prívozník wrote: > On 27. 3. 2020 16:11, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > tools/virsh-domain.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/tools/virsh-domain.c b/to

Re: [libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-27 Thread Michal Prívozník
On 27. 3. 2020 16:11, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > tools/virsh-domain.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 8591e483a5..ada0189685 100644 > --- a/tools/virsh-dom

[libvirt PATCH] tools: explain that '^' means 'Ctrl' for console escape sequence

2020-03-27 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tools/virsh-domain.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8591e483a5..ada0189685 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -3002,7 +3002,11 @@ cmdRunCo