Re: [libvirt PATCH] util: keep the pidfile locked

2020-03-25 Thread Michal Prívozník
On 25. 3. 2020 0:58, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Unfortunately, advisory record locking lose the lock if any fd refering > to the file is closed. There doesn't seem to be a way to preserve the > lock atomically. We could eventually retake the lock if low pidfi

[libvirt PATCH] util: keep the pidfile locked

2020-03-24 Thread marcandre . lureau
From: Marc-André Lureau Unfortunately, advisory record locking lose the lock if any fd refering to the file is closed. There doesn't seem to be a way to preserve the lock atomically. We could eventually retake the lock if low pidfilefd is required. This fixes processes being leaked, as they are