Re: [libvirt PATCH 00/11] Random bits found by clang-tidy

2021-01-28 Thread Tim Wiederhake
On Thu, 2021-01-28 at 10:35 +, Daniel P. Berrangé wrote: > On Thu, Jan 28, 2021 at 11:24:30AM +0100, Tim Wiederhake wrote: > > clang-tidy is a static code analysis tool under the llvm umbrella. > > It is > > primarily meant to be used on C++ code bases, but some of the > > checks it > > provide

Re: [libvirt PATCH 00/11] Random bits found by clang-tidy

2021-01-28 Thread Peter Krempa
On Thu, Jan 28, 2021 at 11:24:30 +0100, Tim Wiederhake wrote: [...] > Tim Wiederhake (11): > virfile: Remove redundant #ifndef > xen: Fix indentation in xenParseXLSpice > qemu_tpm: Fix indentation in qemuTPMEmulatorBuildCommand > virsh-domain: Fix error handling of pthread_sigmask > Rep

Re: [libvirt PATCH 00/11] Random bits found by clang-tidy

2021-01-28 Thread Daniel P . Berrangé
On Thu, Jan 28, 2021 at 11:24:30AM +0100, Tim Wiederhake wrote: > clang-tidy is a static code analysis tool under the llvm umbrella. It is > primarily meant to be used on C++ code bases, but some of the checks it > provides also apply to C. > > The findings vary in severity and contain pseudo-fals

[libvirt PATCH 00/11] Random bits found by clang-tidy

2021-01-28 Thread Tim Wiederhake
clang-tidy is a static code analysis tool under the llvm umbrella. It is primarily meant to be used on C++ code bases, but some of the checks it provides also apply to C. The findings vary in severity and contain pseudo-false-positives, i.e. clang-tidy is flagging potential execution flows that co