Re: [libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying

2023-05-05 Thread Laine Stump
On 5/2/23 11:15 AM, Michal Prívozník wrote: On 5/1/23 05:19, Laine Stump wrote: +rule->ignoreErrors = ignoreErrors +|| (group->actionFlags & VIR_FIREWALL_TRANSACTION_IGNORE_ERRORS); Nit pick - we usually put logical operands at the end of previous line. A *very* long time

Re: [libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying

2023-05-03 Thread Daniel P . Berrangé
On Sun, Apr 30, 2023 at 11:19:18PM -0400, Laine Stump wrote: > We know at the time a virFirewallRule is created (with > virFirewallAddRule*()) whether or not we will later want to ignore > errors encountered when attempting to apply that rule - if > ignoreErrors is set in the AddRule or if the grou

Re: [libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying

2023-05-02 Thread Michal Prívozník
On 5/1/23 05:19, Laine Stump wrote: > We know at the time a virFirewallRule is created (with > virFirewallAddRule*()) whether or not we will later want to ignore > errors encountered when attempting to apply that rule - if > ignoreErrors is set in the AddRule or if the group has already had > VIR_F

[libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying

2023-04-30 Thread Laine Stump
We know at the time a virFirewallRule is created (with virFirewallAddRule*()) whether or not we will later want to ignore errors encountered when attempting to apply that rule - if ignoreErrors is set in the AddRule or if the group has already had VIR_FIREWALL_TRANSACTION_IGNORE_ERRORS set, then we