Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Pavel Hrdina
On Wed, Aug 05, 2020 at 03:23:44PM +0200, Erik Skultety wrote: > On Wed, Aug 05, 2020 at 03:14:52PM +0200, Andrea Bolognani wrote: > > On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote: > > > Once we (hopefully) move remaining projects to meson and some of the > > > projects would require newer

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Erik Skultety
On Wed, Aug 05, 2020 at 03:14:52PM +0200, Andrea Bolognani wrote: > On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote: > > Once we (hopefully) move remaining projects to meson and some of the > > projects would require newer meson we would have to introduce the ugly > > hack into these spec fil

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Andrea Bolognani
On Wed, 2020-08-05 at 14:30 +0200, Pavel Hrdina wrote: > Once we (hopefully) move remaining projects to meson and some of the > projects would require newer meson we would have to introduce the ugly > hack into these spec files as well (if there are any). > > After checking what is in the macro fi

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Erik Skultety
On Wed, Aug 05, 2020 at 02:37:09PM +0200, Pavel Hrdina wrote: > On Wed, Aug 05, 2020 at 02:00:14PM +0200, Erik Skultety wrote: > > On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote: > > > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote: > > > > Gross hack in our CI vs gross hac

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Pavel Hrdina
On Wed, Aug 05, 2020 at 02:00:14PM +0200, Erik Skultety wrote: > On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote: > > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote: > > > Gross hack in our CI vs gross hack in spec file. I vote for CI to have > > > the hack. > > > > > > In

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Pavel Hrdina
On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote: > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote: > > Gross hack in our CI vs gross hack in spec file. I vote for CI to have > > the hack. > > > > In addition the macros are provided by meson and there are changes in > > the

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Erik Skultety
On Wed, Aug 05, 2020 at 01:47:21PM +0200, Andrea Bolognani wrote: > On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote: > > Gross hack in our CI vs gross hack in spec file. I vote for CI to have > > the hack. > > > > In addition the macros are provided by meson and there are changes in > > the

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Andrea Bolognani
On Wed, 2020-08-05 at 13:27 +0200, Pavel Hrdina wrote: > Gross hack in our CI vs gross hack in spec file. I vote for CI to have > the hack. > > In addition the macros are provided by meson and there are changes in > the macro file, for example the latest macro file uses `meson compile` > instead o

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Pavel Hrdina
On Wed, Aug 05, 2020 at 12:52:15PM +0200, Andrea Bolognani wrote: > On Wed, 2020-08-05 at 12:24 +0200, Pavel Hrdina wrote: > > On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote: > > > Oh, I see now the %meson macro is shipped as part of meson itself. We > > > definitely don't want to

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Andrea Bolognani
On Wed, 2020-08-05 at 12:24 +0200, Pavel Hrdina wrote: > On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote: > > Oh, I see now the %meson macro is shipped as part of meson itself. We > > definitely don't want to install two versions of meson, and if we end > > up agreeing that keeping

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Pavel Hrdina
On Wed, Aug 05, 2020 at 11:52:30AM +0200, Andrea Bolognani wrote: > On Wed, 2020-08-05 at 11:23 +0200, Erik Skultety wrote: > > On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote: > > > Erik reports that there are issues with building RPMs on CentOS. He > > > opened https://gitlab.com

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Andrea Bolognani
On Wed, 2020-08-05 at 11:23 +0200, Erik Skultety wrote: > On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote: > > Erik reports that there are issues with building RPMs on CentOS. He > > opened https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/42, but > > it seems to me that the t

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Erik Skultety
On Wed, Aug 05, 2020 at 10:59:08AM +0200, Andrea Bolognani wrote: > On Thu, 2020-07-16 at 11:54 +0200, Pavel Hrdina wrote: > > +++ b/meson_options.txt > > @@ -12,3 +12,4 @@ option('test_coverage', type: 'boolean', value: false, > > description: 'turn on cod > > option('apparmor', type: 'feature',

Re: [libvirt PATCH 037/351] meson: add readline build option

2020-08-05 Thread Andrea Bolognani
On Thu, 2020-07-16 at 11:54 +0200, Pavel Hrdina wrote: > +++ b/meson_options.txt > @@ -12,3 +12,4 @@ option('test_coverage', type: 'boolean', value: false, > description: 'turn on cod > option('apparmor', type: 'feature', value: 'auto', description: 'apparmor > support') > option('attr', type:

[libvirt PATCH 037/351] meson: add readline build option

2020-07-16 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- configure.ac| 3 -- m4/virt-readline.m4 | 86 - meson.build | 64 + meson_options.txt | 1 + 4 files changed, 65 insertions(+), 89 deletions(-) delete mode 100644 m4/vi