Re: [libvirt PATCH 06/17] virfile: refactor virFileNBDDeviceAssociate

2021-01-04 Thread Peter Krempa
On Mon, Dec 14, 2020 at 16:55:26 +0100, Pavel Hrdina wrote: > The only reason why virstoragefile.h needs to be included in virfile.h > is that virFileNBDDeviceAssociate() takes virStorageFileFormat argument. > The function doesn't need the enum value as it converts the value to > string and uses on

[libvirt PATCH 06/17] virfile: refactor virFileNBDDeviceAssociate

2020-12-14 Thread Pavel Hrdina
The only reason why virstoragefile.h needs to be included in virfile.h is that virFileNBDDeviceAssociate() takes virStorageFileFormat argument. The function doesn't need the enum value as it converts the value to string and uses only that. Change the argument to string which will allow us to remov