Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 12:29:29PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 7, 2020 at 11:50 AM Ján Tomko wrote: > > > > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > > >From: Marc-André Lureau > > > > > >Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the >

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Marc-André Lureau
Hi On Tue, Apr 7, 2020 at 11:50 AM Ján Tomko wrote: > > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the > >presence of machine1 service"), the code checks for systemd1 > >registration. Not

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 11:50:31AM +0200, Ján Tomko wrote: > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the > > presence of machine1 service"), the code checks for systemd1 > > registrat

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Ján Tomko
On a Monday in 2020, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the presence of machine1 service"), the code checks for systemd1 registration. Not totally unreasonable, but that seems odd since we actually check machi

[libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-06 Thread marcandre . lureau
From: Marc-André Lureau Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the presence of machine1 service"), the code checks for systemd1 registration. Not totally unreasonable, but that seems odd since we actually check machined presence in this function. Signed-off-by: Marc-André