Re: [libvirt PATCH 10/10] virDomainAudioSDLParse: Use virXMLProp*

2021-04-26 Thread Peter Krempa
On Mon, Apr 26, 2021 at 12:48:47 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 23, 2021 at 05:39:23PM +0200, Tim Wiederhake wrote: > > This strictens the parser to disallow negative values (interpreted as > > `UINT_MAX + value + 1`) for attribute `bufferCount`. > > I don't get what's different he

Re: [libvirt PATCH 10/10] virDomainAudioSDLParse: Use virXMLProp*

2021-04-26 Thread Daniel P . Berrangé
On Fri, Apr 23, 2021 at 05:39:23PM +0200, Tim Wiederhake wrote: > This strictens the parser to disallow negative values (interpreted as > `UINT_MAX + value + 1`) for attribute `bufferCount`. I don't get what's different here - we were already using virStrToLong_ui to get positive values. > Signed

Re: [libvirt PATCH 10/10] virDomainAudioSDLParse: Use virXMLProp*

2021-04-26 Thread Peter Krempa
On Fri, Apr 23, 2021 at 17:39:23 +0200, Tim Wiederhake wrote: > This strictens the parser to disallow negative values (interpreted as > `UINT_MAX + value + 1`) for attribute `bufferCount`. A change like this requires justification, but you've provided only an explanation. > Signed-off-by: Tim Wie

[libvirt PATCH 10/10] virDomainAudioSDLParse: Use virXMLProp*

2021-04-23 Thread Tim Wiederhake
This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `bufferCount`. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/dom