Re: [libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

2021-02-09 Thread Pavel Hrdina
On Tue, Feb 09, 2021 at 05:33:28PM +0100, Pavel Hrdina wrote: > On Tue, Feb 09, 2021 at 01:59:01PM +, Daniel P. Berrangé wrote: > > The "max" model can be treated the same way as "host" model in general. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > 94 files changed, 431 insertions(+

Re: [libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

2021-02-09 Thread Pavel Hrdina
On Tue, Feb 09, 2021 at 01:59:01PM +, Daniel P. Berrangé wrote: > The "max" model can be treated the same way as "host" model in general. > > Signed-off-by: Daniel P. Berrangé > --- > 94 files changed, 431 insertions(+), 73 deletions(-) > > diff --git a/src/qemu/qemu_capabilities.c b/src/qe

Re: [libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

2021-02-09 Thread Daniel P . Berrangé
On Tue, Feb 09, 2021 at 02:21:32PM +, Richard W.M. Jones wrote: > > Patch series looks fine to me, and we can certainly use this feature. > > One question I have about it: Does this apply to all architectures > equally, or will we need to detect it from capabilities? I mean to > say, if this

Re: [libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

2021-02-09 Thread Richard W.M. Jones
Patch series looks fine to me, and we can certainly use this feature. One question I have about it: Does this apply to all architectures equally, or will we need to detect it from capabilities? I mean to say, if this was added to libvirt version X, then I might mandate that you have to use libv

[libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

2021-02-09 Thread Daniel P . Berrangé
The "max" model can be treated the same way as "host" model in general. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c| 17 - src/qemu/qemu_command.c | 10 +++--- src/qemu/qemu_domain.c |