Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Andrea Bolognani
On Mon, Jan 10, 2022 at 02:32:48PM +0100, Olaf Hering wrote: > Mon, 10 Jan 2022 13:29:28 + Andrea Bolognani : > > I'm definitely open to moving it if you can make a convincing enough case > > for it :) > > I was hoping the binary can be moved to libexec, which means a man page is > not strict

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 01:29:54PM +0100, Olaf Hering wrote: > Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani : > > > +``virt-ssh-helper`` is an internal tool > > If it is indeed an internal tool, why is the man page in section 1, and why > is it in PATH? We explicitly want virt-ssh-helper in

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Olaf Hering
Mon, 10 Jan 2022 13:29:28 + Andrea Bolognani : > I'm definitely open to moving it if you can make a convincing enough case for > it :) I was hoping the binary can be moved to libexec, which means a man page is not strictly required. But apparently this can not be done due to the way how it

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Andrea Bolognani
On Mon, Jan 10, 2022 at 01:02:43PM +, Andrea Bolognani wrote: > On Mon, Jan 10, 2022 at 01:29:54PM +0100, Olaf Hering wrote: > > Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani : > > > +``virt-ssh-helper`` is an internal tool > > > > If it is indeed an internal tool, why is the man page in sec

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Andrea Bolognani
On Mon, Jan 10, 2022 at 01:29:54PM +0100, Olaf Hering wrote: > Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani : > > > +``virt-ssh-helper`` is an internal tool > > If it is indeed an internal tool, why is the man page in section 1, and why > is it in PATH? > I think the man page needs to be moved

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-10 Thread Olaf Hering
Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani : > +``virt-ssh-helper`` is an internal tool If it is indeed an internal tool, why is the man page in section 1, and why is it in PATH? I think the man page needs to be moved to section 8, the binary into $libexec. The path to it will be known, th

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-07 Thread Andrea Bolognani
On Fri, Jan 07, 2022 at 04:30:33PM +0100, Michal Prívozník wrote: > On 12/13/21 14:44, Andrea Bolognani wrote: > > We don't usually provide manual pages for internal tools, > > but in the case of virt-ssh-helper the command is installed > > inside the default $PATH and so it's likely that the user

Re: [libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2022-01-07 Thread Michal Prívozník
On 12/13/21 14:44, Andrea Bolognani wrote: > We don't usually provide manual pages for internal tools, > but in the case of virt-ssh-helper the command is installed > inside the default $PATH and so it's likely that the user > will stumble upon it by using the shell's completion feature > when invo

[libvirt PATCH v2 1/1] virt-ssh-helper: Add manual page

2021-12-13 Thread Andrea Bolognani
We don't usually provide manual pages for internal tools, but in the case of virt-ssh-helper the command is installed inside the default $PATH and so it's likely that the user will stumble upon it by using the shell's completion feature when invoking another virt-* command, which makes it a good id