Re: [libvirt PATCH v2 43/56] util: conditionalize FD stream to exclude WIN32

2020-02-05 Thread Daniel P . Berrangé
On Fri, Jan 31, 2020 at 04:13:45PM +0100, Pavel Hrdina wrote: > On Tue, Jan 28, 2020 at 01:11:24PM +, Daniel P. Berrangé wrote: > > Almost none of the virFDStream code will actually work > > on WIN32 builds, nor is it used except for in the > > virtualbox driver for screenshots. It is simpler t

Re: [libvirt PATCH v2 43/56] util: conditionalize FD stream to exclude WIN32

2020-01-31 Thread Pavel Hrdina
On Tue, Jan 28, 2020 at 01:11:24PM +, Daniel P. Berrangé wrote: > Almost none of the virFDStream code will actually work > on WIN32 builds, nor is it used except for in the > virtualbox driver for screenshots. It is simpler to > wrap it all in a '#ifndef WIN32'. > > Signed-off-by: Daniel P. Be

[libvirt PATCH v2 43/56] util: conditionalize FD stream to exclude WIN32

2020-01-28 Thread Daniel P . Berrangé
Almost none of the virFDStream code will actually work on WIN32 builds, nor is it used except for in the virtualbox driver for screenshots. It is simpler to wrap it all in a '#ifndef WIN32'. Signed-off-by: Daniel P. Berrangé --- src/util/virfdstream.c | 122 +++---