Re: [libvirt PATCH v2 6/6] ci: util: Add a registry checker for stale images

2021-03-18 Thread Erik Skultety
... > Another thing I'm not a fan of is having the message start at column > zero instead of being aligned along with the rest of the code... > textwrap.dedent() could help here, although it'd be a little annoying > to use because we want the image details to be indented and we can't > know the co

Re: [libvirt PATCH v2 6/6] ci: util: Add a registry checker for stale images

2021-03-17 Thread Erik Skultety
On Wed, Mar 17, 2021 at 04:57:01PM +0100, Andrea Bolognani wrote: > On Tue, 2021-03-16 at 18:33 +0100, Erik Skultety wrote: > > +++ b/ci/helper > > +def _list_stale_images(self): > > So far we have not used "_" as the prefix for any method name. Do we > want to start doing that? What would be

Re: [libvirt PATCH v2 6/6] ci: util: Add a registry checker for stale images

2021-03-17 Thread Andrea Bolognani
On Tue, 2021-03-16 at 18:33 +0100, Erik Skultety wrote: > +++ b/ci/helper > +def _list_stale_images(self): So far we have not used "_" as the prefix for any method name. Do we want to start doing that? What would be the criteria? > +# check for stale images in GitLab registry > +

[libvirt PATCH v2 6/6] ci: util: Add a registry checker for stale images

2021-03-16 Thread Erik Skultety
This function checks whether there are any stale Docker images in the registry that can be purged. Since we're pulling available container images from our GitLab registry with the 'list-images' action, it could happen that we'd list old (already unsupported) images and make them available for the u