Re: [libvirt PATCH v3 0/8] vmx: Don't error out on missing filename for cdrom

2021-01-05 Thread Martin Kletzander
On Tue, Jan 05, 2021 at 07:19:08PM +0100, Michal Privoznik wrote: On 1/5/21 4:54 PM, Martin Kletzander wrote: This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now r

Re: [libvirt PATCH v3 0/8] vmx: Don't error out on missing filename for cdrom

2021-01-05 Thread Michal Privoznik
On 1/5/21 4:54 PM, Martin Kletzander wrote: This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now results in an error and the user not being able to even dump the XML

[libvirt PATCH v3 0/8] vmx: Don't error out on missing filename for cdrom

2021-01-05 Thread Martin Kletzander
This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now results in an error and the user not being able to even dump the XML. Instead of erroring out, just keep the driv