Re: [libvirt PATCH v3 1/1] Add a PCI/PCIe device VPD Capability

2021-09-17 Thread Dmitrii Shcherbakov
Hi Peter, Thanks for the quick reply. > This is a quick note, not a full review Ack, appreciate the early feedback. > it can be properly split into multiple smaller chunks I will look into splitting it into parts related to the binary parser, XML handling and docs at least. There are some dep

Re: [libvirt PATCH v3 1/1] Add a PCI/PCIe device VPD Capability

2021-09-17 Thread Peter Krempa
On Fri, Sep 17, 2021 at 13:54:49 +0300, Dmitrii Shcherbakov wrote: > Add support for deserializing the binary PCI/PCIe VPD format and > exposing VPD resources as XML elements in a new nested capability > of PCI/PCIe devices called 'vpd'. > > The VPD format is specified in "I.3. VPD Definitions" in

[libvirt PATCH v3 1/1] Add a PCI/PCIe device VPD Capability

2021-09-17 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The VPD format is specified in "I.3. VPD Definitions" in PCI specs (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4