Re: [libvirt PATCH v3 5/6] ci: util: Add a registry checker for stale images

2021-03-18 Thread Erik Skultety
... > > +def get_registry_stale_images(registry_uri: str, > > + supported_distros: List[str]) -> Dict[str, > > int]: > > +""" > > +Check the GitLab image registry for images that we no longer support > > and > > +which should be deleted. > > + > > +:p

Re: [libvirt PATCH v3 5/6] ci: util: Add a registry checker for stale images

2021-03-18 Thread Andrea Bolognani
On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > +def check_stale_images(self): > +if self.args.check_stale != "yes" or self.args.quiet: > +return I would prefer it if this check were to be performed in the action_refresh() method to decide whether or not check_sta

[libvirt PATCH v3 5/6] ci: util: Add a registry checker for stale images

2021-03-18 Thread Erik Skultety
This function checks whether there are any stale Docker images in the registry that can be purged. Since we're pulling available container images from our GitLab registry with the 'list-images' action, it could happen that we'd list old (already unsupported) images and make them available for the u