Re: [libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

On Thu, Sep 01, 2022 at 03:43:58PM +0200, Peter Krempa wrote: > On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/qemu/qemu_snapshot.c | 94 ++-- > > 1 file changed, 53 insertions(+), 41 deletions(-) >

Re: [libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_snapshot.c | 94 ++-- > 1 file changed, 53 insertions(+), 41 deletions(-) Code change looks reasonable. I'd probably go for a C99-style init of the

[libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 94 ++-- 1 file changed, 53 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index b5e6a87566..d40d75e75d 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/