Re: [libvirt] [PATCH 2/7] qemu: Split out code to generate VNC command line

2013-04-25 Thread Peter Krempa
On 04/25/13 12:34, Christophe Fergeau wrote: On Tue, Apr 23, 2013 at 03:46:09PM +0200, Peter Krempa wrote: Decrease size of qemuBuildGraphicsCommandLine() by splitting out spice-related code into qemuBuildGraphicsVNCCommandLine(). I guess you mean "VNC-related code" here. Ah, yes. I borrowed

Re: [libvirt] [PATCH 2/7] qemu: Split out code to generate VNC command line

2013-04-25 Thread Christophe Fergeau
On Tue, Apr 23, 2013 at 03:46:09PM +0200, Peter Krempa wrote: > Decrease size of qemuBuildGraphicsCommandLine() by splitting out > spice-related code into qemuBuildGraphicsVNCCommandLine(). I guess you mean "VNC-related code" here. Christophe > > This patch also fixes 2 possible memory leaks on

Re: [libvirt] [PATCH 2/7] qemu: Split out code to generate VNC command line

2013-04-23 Thread Daniel P. Berrange
On Tue, Apr 23, 2013 at 03:46:09PM +0200, Peter Krempa wrote: > Decrease size of qemuBuildGraphicsCommandLine() by splitting out > spice-related code into qemuBuildGraphicsVNCCommandLine(). > > This patch also fixes 2 possible memory leaks on error path in the code > that was split-out. The buffer