Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-08-12 Thread Kevin Wolf
Am 11.08.2011 18:28, schrieb Corey Bryant: > > > On 07/26/2011 08:51 AM, Corey Bryant wrote: > > > +static int raw_open_fd(BlockDriverState *bs, const char *filename, > int flags) > > +{ > > +BDRVRawState *s = bs->opaque; > > +const char *fd_str; > > +int fd; > > + > > +/

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Blue Swirl
On Tue, Jul 26, 2011 at 3:51 PM, Corey Bryant wrote: > sVirt provides SELinux MAC isolation for Qemu guest processes and their > corresponding resources (image files). sVirt provides this support > by labeling guests and resources with security labels that are stored > in file system extended attr

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 15:09, schrieb Corey Bryant: > Kevin/Daniel, thanks a lot for your input. > > In terms of the support that libvirt requires, I just want to make sure > all bases are covered. > > In order for this support to be useful to libvirt, the following are > required (sorry if this is repe

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Corey Bryant
On 07/27/2011 04:43 AM, Daniel P. Berrange wrote: On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: > Am 27.07.2011 10:22, schrieb Daniel P. Berrange: > > On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: > >> Am 26.07.2011 18:57, schrieb Corey Bryant: > >> diff --git a/block/cow.c b/block/cow.c > >> index 4cf543c..e1

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 10:22, schrieb Daniel P. Berrange: > On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: >> Am 26.07.2011 18:57, schrieb Corey Bryant: >> diff --git a/block/cow.c b/block/cow.c >> index 4cf543c..e17f8e7 100644 >> --- a/block/cow.c >> +++ b/block/cow.c >

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: > Am 26.07.2011 18:57, schrieb Corey Bryant: > diff --git a/block/cow.c b/block/cow.c > index 4cf543c..e17f8e7 100644 > --- a/block/cow.c > +++ b/block/cow.c > @@ -82,6 +82,11 @@ static int cow_open(BlockDrive

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 18:57, schrieb Corey Bryant: > > Kevin, thanks for the input. > > On 07/26/2011 11:18 AM, Kevin Wolf wrote: >> Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 01:10 PM, Alexander Graf wrote: On 26.07.2011, at 18:57, Corey Bryant wrote: > > Kevin, thanks for the input. > > On 07/26/2011 11:18 AM, Kevin Wolf wrote: >> Am 26.07.2011 14:51, schrieb Corey Bryant: >>> >sVirt provides SELinux MAC isolation for Qemu guest processes

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Alexander Graf
On 26.07.2011, at 18:57, Corey Bryant wrote: > > Kevin, thanks for the input. > > On 07/26/2011 11:18 AM, Kevin Wolf wrote: >> Am 26.07.2011 14:51, schrieb Corey Bryant: >>> > sVirt provides SELinux MAC isolation for Qemu guest processes and their >>> > corresponding resources (image files).

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: > sVirt provides SELinux MAC isolation for Qemu guest processes and their > corresponding resources (image files). sVirt provides this support > by labeling guests and resources

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 16:46, schrieb Corey Bryant: > > On 07/26/2011 10:05 AM, Kevin Wolf wrote: >> Am 26.07.2011 15:02, schrieb Christoph Hellwig: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Corey Bryant
On 07/26/2011 10:05 AM, Kevin Wolf wrote: Am 26.07.2011 15:02, schrieb Christoph Hellwig: > I have to say I really hate it. We've been working hard on getting rid > of special cases in the qemu block layer, and this sprinkles them all > over. I'd recommend to fix your security model instea

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 15:02, schrieb Christoph Hellwig: > I have to say I really hate it. We've been working hard on getting rid > of special cases in the qemu block layer, and this sprinkles them all > over. I'd recommend to fix your security model instead. I think the problem here is more with the imp

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Eric Blake
On 07/26/2011 07:02 AM, Christoph Hellwig wrote: I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. What is it that you hate - the particular qemu

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-26 Thread Christoph Hellwig
I have to say I really hate it. We've been working hard on getting rid of special cases in the qemu block layer, and this sprinkles them all over. I'd recommend to fix your security model instead. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-l