Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-28 Thread Chris Lalancette
Yuji NISHIDA wrote: > Thanks, Chris and Daniel > > I corrected the code that I posted here according to your comments. > Chris, I now need to handle openvz containers by character(name) not > integer(id) at all. Right, the patch looks good to correct the two smaller issues that I pointed out, b

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-24 Thread Yuji NISHIDA
Thanks, Chris and Daniel I corrected the code that I posted here according to your comments. Chris, I now need to handle openvz containers by character(name) not integer(id) at all. diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 54bcaa9..3b8505d 100644 --- a/src/op

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-23 Thread Daniel Veillard
On Wed, Sep 23, 2009 at 10:22:51AM +0200, Chris Lalancette wrote: > Yuji NISHIDA wrote: > > Hi Daniel > > > > Fixed patch according to your comments in openvzDomainDefineCmd func. > > > > --- a/src/openvz_driver.c > > +++ b/src/openvz_driver.c > > @@ -101,6 +101,9 @@ static int openvzDomainDefine

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-23 Thread Chris Lalancette
Yuji NISHIDA wrote: > Hi Daniel > > Fixed patch according to your comments in openvzDomainDefineCmd func. > > --- a/src/openvz_driver.c > +++ b/src/openvz_driver.c > @@ -101,6 +101,9 @@ static int openvzDomainDefineCmd(virConnectPtr conn, > virDomainDefPtr vmdef)

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-17 Thread Yuji NISHIDA
Hi Daniel Fixed patch according to your comments in openvzDomainDefineCmd func. --- a/src/openvz_driver.c +++ b/src/openvz_driver.c @@ -101,6 +101,9 @@ static int openvzDomainDefineCmd(virConnectPtr conn, virDomainDefPtr vmdef) { int narg; +int veid; +

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-15 Thread Daniel P. Berrange
On Tue, Sep 15, 2009 at 03:40:09PM +0900, Yuji NISHIDA wrote: > Hi Daniel, > > I didn't realize that I even did not follow the manner of XML. > I have worked with this problem and got a small patch to handle "ID" > in OpenVZ functionality. > I found it is working well with the XML script include

Re: [libvirt] Re: OpenVZ : The restriction of domain name should be addressed

2009-09-02 Thread Daniel Veillard
On Fri, Aug 21, 2009 at 11:08:05AM +0900, Yuji NISHIDA wrote: > >>> 2009/7/24 Daniel P. Berrange > We should make use of this --name parameter then - I guess it didn't exist when we first wrote the driver. It is useful to users to have separate ID vs Name parameters - and in fact th