Re: Fix lilypond-book include paths (issue 4046) (issue 116540043 by julien.ri...@gmail.com)

2014-08-21 Thread dak
https://codereview.appspot.com/116540043/diff/40001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/116540043/diff/40001/input/regression/lilypond-book/GNUmakefile#newcode22 input/regression/lilypond-book/GNUmakef

PATCHES: Countdown for August 24th 2014

2014-08-21 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on August 24th. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread dak
On 2014/08/21 17:50:15, Trevor Daniels wrote: Let's see if I understand the issue here. Because the incipit is generated as a separate score hidden inside a music function it is not possible to use the usual override mechanism to change any values set inside the music function, including t

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread tdanielsmusic
Let's see if I understand the issue here. Because the incipit is generated as a separate score hidden inside a music function it is not possible to use the usual override mechanism to change any values set inside the music function, including the value of InstrumentName.self-aligment-X. The defa

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread David Kastrup
Mark Knoop writes: > At 15:40 on 21 Aug 2014, Phil Holmes wrote: >>Let's see if anyone else has an opinion. > > I am inclined to agree with David. The function should not have a > different default alignment for the instrument name. It is a shame that > the instrument name alignment can't be calc

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Mark Knoop
At 15:40 on 21 Aug 2014, Phil Holmes wrote: >Let's see if anyone else has an opinion. I am inclined to agree with David. The function should not have a different default alignment for the instrument name. It is a shame that the instrument name alignment can't be calculated from any existing layout

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Peter Bjuhr
On 2014-08-21 17:03, Trevor Daniels wrote: Phil, you wrote Thursday, August 21, 2014 3:18 PM And this is the nub of the discussion. There's nothing actually _wrong_ with my patch: it's just you don't like how it looks. I very much do. This time I've attached a centre-aligned and a right-a

Re: Adds incipit section to NR (issue 108270043byphilehol...@googlemail.com)

2014-08-21 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: "Phil Holmes" > Cc: ; ; > ; > Sent: Thursday, August 21, 2014 3:56 PM > Subject: Re: Adds incipit section to NR (issue > 108270043byphilehol...@googlemail.com) > > > "Phil Holmes" writes: > >> > Let's see if a

Re: Adds incipit section to NR (issue 108270043byphilehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: ; ; ; Sent: Thursday, August 21, 2014 3:56 PM Subject: Re: Adds incipit section to NR (issue 108270043byphilehol...@googlemail.com) "Phil Holmes" writes: > Let's see if anyone else has an opinion. About what?

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Trevor Daniels
Phil, you wrote Thursday, August 21, 2014 3:18 PM > And this is the nub of the discussion. There's nothing actually _wrong_ > with my patch: it's just you don't like how it looks. I very much do. This > time I've attached a centre-aligned and a right-aligned example, and much > prefer the l

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread David Kastrup
"Phil Holmes" writes: > Let's see if anyone else has an opinion. About what? You want to argue about what instrument name alignment looks nicest. But that's besides the point. The issue I am talking about is that there is nothing inherent in incipits that makes aligning instrument names diffe

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
Let's see if anyone else has an opinion. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread David Kastrup
"Phil Holmes" writes: >> Unless incipit-width is too small to accommodate the incipit in the >> first place, the amount of space available for the instrument name is >> \indent-\incipit-width. Even in that case, I don't see that the natural >> or best placement of the instrument name in the rema

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: ; ; ; Sent: Thursday, August 21, 2014 2:43 PM Subject: Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com) "Phil Holmes" writes: - Original Message - From: "David Kastrup" To:

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: "Phil Holmes" > Cc: ; > ; ; > > Sent: Thursday, August 21, 2014 1:26 PM > Subject: Re: Adds incipit section to NR (issue 108270043 > byphilehol...@googlemail.com) > >> At any rate: why do you believe that an in

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: To: ; ; ; ; ; Cc: ; Sent: Thursday, August 21, 2014 1:55 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/06/29 13:51:33, PhilEHolmes wrote: Please review. Sorry to step in like that. I'm not able t

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread dak
On 2014/08/21 12:55:37, Jean-Charles wrote: On 2014/06/29 13:51:33, PhilEHolmes wrote: > Please review. Sorry to step in like that. I'm not able to comment on the code, but have just one question, since I don't use incipits: does it happen that the original score reproduced in an incipit

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: ; ; ; Sent: Thursday, August 21, 2014 1:26 PM Subject: Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com) At any rate: why do you believe that an instrument should be formatted differently

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread lilyfan
On 2014/06/29 13:51:33, PhilEHolmes wrote: Please review. Sorry to step in like that. I'm not able to comment on the code, but have just one question, since I don't use incipits: does it happen that the original score reproduced in an incipit happens to be on a four lines staff? How would it t

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: > To: ; ; > >> On 2014/08/21 10:21:18, mail_philholmes.net wrote: >> >>> There's nothing wrong in changing a poor default to a good one, and >>> then allowing the user to restore the poor one. >> >> But you are not "changing a poor de

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: To: ; ; ; ; Cc: ; Sent: Thursday, August 21, 2014 12:31 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/21 10:21:18, mail_philholmes.net wrote: There's nothing wrong in changing a poor default to a

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread dak
On 2014/08/21 10:21:18, mail_philholmes.net wrote: There's nothing wrong in changing a poor default to a good one, and then allowing the user to restore the poor one. But you are not "changing a poor default to a good one". You are overriding locally, as the default of a single command, wha

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
Sorry - the images were not helpful. It looks like my mailer adds the image when it's sent, not when it's attached. Here they are again. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lil

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread Phil Holmes
- Original Message - From: To: ; ; ; ; Cc: ; Sent: Wednesday, August 20, 2014 9:40 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/20 08:17:01, email_philholmes.net wrote: >> ly/property-init.ly:303: ragged-last = ##f >> woul