Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-03-08 Thread Ming Lei
On Fri, Mar 08, 2019 at 08:55:22AM +0100, Christoph Hellwig wrote: > On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > > On 2/26/19 7:21 PM, Ming Lei wrote: > > > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > > >> On 2/26/19 6:53 PM, Ming Lei wrote: > > >>> On Tue, Feb 2

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-03-08 Thread Christoph Hellwig
On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > Speaking of this, I took a quick look at why we've now regressed a lot > on IOPS perf with the multipage work. It looks like it's all related to > the (much) fatter setup around iteration, which is related to this very > topic too. > Ba

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-03-07 Thread Christoph Hellwig
On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > On 2/26/19 7:21 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > >> On 2/26/19 6:53 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: > On 2/26/19 6:21 PM, Min

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-28 Thread Ming Lei
On Wed, Feb 27, 2019 at 11:42:41AM -0800, Christoph Hellwig wrote: > On Tue, Feb 26, 2019 at 09:06:23PM -0700, Jens Axboe wrote: > > On 2/26/19 9:05 PM, Jens Axboe wrote: > > > On 2/26/19 8:44 PM, Ming Lei wrote: > > >> On Tue, Feb 26, 2019 at 08:37:05PM -0700, Jens Axboe wrote: > > >>> On 2/26/19

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-27 Thread Ming Lei
On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > On 2/26/19 7:21 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > >> On 2/26/19 6:53 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: > On 2/26/19 6:21 PM, Min

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-27 Thread Christoph Hellwig
On Tue, Feb 26, 2019 at 09:06:23PM -0700, Jens Axboe wrote: > On 2/26/19 9:05 PM, Jens Axboe wrote: > > On 2/26/19 8:44 PM, Ming Lei wrote: > >> On Tue, Feb 26, 2019 at 08:37:05PM -0700, Jens Axboe wrote: > >>> On 2/26/19 8:09 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jen

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 9:05 PM, Jens Axboe wrote: > On 2/26/19 8:44 PM, Ming Lei wrote: >> On Tue, Feb 26, 2019 at 08:37:05PM -0700, Jens Axboe wrote: >>> On 2/26/19 8:09 PM, Ming Lei wrote: On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: > On 2/26/19 7:37 PM, Ming Lei wrote: >> On Tue

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 8:44 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 08:37:05PM -0700, Jens Axboe wrote: >> On 2/26/19 8:09 PM, Ming Lei wrote: >>> On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: On 2/26/19 7:37 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axbo

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 08:37:05PM -0700, Jens Axboe wrote: > On 2/26/19 8:09 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: > >> On 2/26/19 7:37 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > On 2/26/19 7:21 PM, Min

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 8:37 PM, Jens Axboe wrote: > On 2/26/19 8:09 PM, Ming Lei wrote: >> On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: >>> On 2/26/19 7:37 PM, Ming Lei wrote: On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > On 2/26/19 7:21 PM, Ming Lei wrote: >> On Tue

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 8:09 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: >> On 2/26/19 7:37 PM, Ming Lei wrote: >>> On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: On 2/26/19 7:21 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axbo

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 07:43:32PM -0700, Jens Axboe wrote: > On 2/26/19 7:37 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > >> On 2/26/19 7:21 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > On 2/26/19 6:53 PM, Min

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 7:37 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: >> On 2/26/19 7:21 PM, Ming Lei wrote: >>> On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: On 2/26/19 6:53 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axbo

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 07:28:54PM -0700, Jens Axboe wrote: > On 2/26/19 7:21 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > >> On 2/26/19 6:53 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: > On 2/26/19 6:21 PM, Min

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 7:21 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: >> On 2/26/19 6:53 PM, Ming Lei wrote: >>> On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: On 2/26/19 6:21 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote:

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 06:57:16PM -0700, Jens Axboe wrote: > On 2/26/19 6:53 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: > >> On 2/26/19 6:21 PM, Ming Lei wrote: > >>> On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote: > > On 2/25/19 9:34 PM, Jens

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 6:53 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: >> On 2/26/19 6:21 PM, Ming Lei wrote: >>> On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote: On 2/25/19 9:34 PM, Jens Axboe wrote: > On 2/25/19 8:46 PM, Eric Biggers wrote: >> Hi Je

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 06:47:54PM -0700, Jens Axboe wrote: > On 2/26/19 6:21 PM, Ming Lei wrote: > > On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote: > >> > >> On 2/25/19 9:34 PM, Jens Axboe wrote: > >>> On 2/25/19 8:46 PM, Eric Biggers wrote: > Hi Jens, > > On Thu, Feb 21, 2019

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/26/19 6:21 PM, Ming Lei wrote: > On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote: >> >> On 2/25/19 9:34 PM, Jens Axboe wrote: >>> On 2/25/19 8:46 PM, Eric Biggers wrote: Hi Jens, On Thu, Feb 21, 2019 at 10:45:27AM -0700, Jens Axboe wrote: > On 2/20/19 3:58 PM, Ming Lei wr

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Ming Lei
On Tue, Feb 26, 2019 at 11:56 PM Jens Axboe wrote: > > On 2/25/19 9:34 PM, Jens Axboe wrote: > > On 2/25/19 8:46 PM, Eric Biggers wrote: > >> Hi Jens, > >> > >> On Thu, Feb 21, 2019 at 10:45:27AM -0700, Jens Axboe wrote: > >>> On 2/20/19 3:58 PM, Ming Lei wrote: > On Mon, Feb 11, 2019 at 12:0

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-26 Thread Jens Axboe
On 2/25/19 9:34 PM, Jens Axboe wrote: > On 2/25/19 8:46 PM, Eric Biggers wrote: >> Hi Jens, >> >> On Thu, Feb 21, 2019 at 10:45:27AM -0700, Jens Axboe wrote: >>> On 2/20/19 3:58 PM, Ming Lei wrote: On Mon, Feb 11, 2019 at 12:00:41PM -0700, Jens Axboe wrote: > For an ITER_BVEC, we can just

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-25 Thread Jens Axboe
On 2/25/19 8:46 PM, Eric Biggers wrote: > Hi Jens, > > On Thu, Feb 21, 2019 at 10:45:27AM -0700, Jens Axboe wrote: >> On 2/20/19 3:58 PM, Ming Lei wrote: >>> On Mon, Feb 11, 2019 at 12:00:41PM -0700, Jens Axboe wrote: For an ITER_BVEC, we can just iterate the iov and add the pages to the

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-25 Thread Eric Biggers
Hi Jens, On Thu, Feb 21, 2019 at 10:45:27AM -0700, Jens Axboe wrote: > On 2/20/19 3:58 PM, Ming Lei wrote: > > On Mon, Feb 11, 2019 at 12:00:41PM -0700, Jens Axboe wrote: > >> For an ITER_BVEC, we can just iterate the iov and add the pages > >> to the bio directly. This requires that the caller do

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-21 Thread Jens Axboe
On 2/20/19 3:58 PM, Ming Lei wrote: > On Mon, Feb 11, 2019 at 12:00:41PM -0700, Jens Axboe wrote: >> For an ITER_BVEC, we can just iterate the iov and add the pages >> to the bio directly. This requires that the caller doesn't releases >> the pages on IO completion, we add a BIO_NO_PAGE_REF flag fo

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-20 Thread Ming Lei
On Mon, Feb 11, 2019 at 12:00:41PM -0700, Jens Axboe wrote: > For an ITER_BVEC, we can just iterate the iov and add the pages > to the bio directly. This requires that the caller doesn't releases > the pages on IO completion, we add a BIO_NO_PAGE_REF flag for that. > > The current two callers of b

[PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-11 Thread Jens Axboe
For an ITER_BVEC, we can just iterate the iov and add the pages to the bio directly. This requires that the caller doesn't releases the pages on IO completion, we add a BIO_NO_PAGE_REF flag for that. The current two callers of bio_iov_iter_get_pages() are updated to check if they need to release p

[PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-09 Thread Jens Axboe
For an ITER_BVEC, we can just iterate the iov and add the pages to the bio directly. This requires that the caller doesn't releases the pages on IO completion, we add a BIO_NO_PAGE_REF flag for that. The current two callers of bio_iov_iter_get_pages() are updated to check if they need to release p

Re: [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-09 Thread Hannes Reinecke
On 2/8/19 6:34 PM, Jens Axboe wrote: For an ITER_BVEC, we can just iterate the iov and add the pages to the bio directly. This requires that the caller doesn't releases the pages on IO completion, we add a BIO_NO_PAGE_REF flag for that. The current two callers of bio_iov_iter_get_pages() are upd

[PATCH 11/19] block: implement bio helper to add iter bvec pages to bio

2019-02-08 Thread Jens Axboe
For an ITER_BVEC, we can just iterate the iov and add the pages to the bio directly. This requires that the caller doesn't releases the pages on IO completion, we add a BIO_NO_PAGE_REF flag for that. The current two callers of bio_iov_iter_get_pages() are updated to check if they need to release p