[PATCH 4/4] nbd: fix zero cmd timeout handling v2

2019-08-13 Thread Mike Christie
This fixes a regression added in 4.9 with commit: commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 Author: Josef Bacik Date: Thu Sep 8 12:33:40 2016 -0700 nbd: allow block mq to deal with timeouts where before the patch userspace would set the timeout to 0 to disable it. With the above pat

Re: [PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-13 Thread Josef Bacik
On Tue, Aug 13, 2019 at 10:45:55AM -0500, Mike Christie wrote: > On 08/13/2019 08:13 AM, Josef Bacik wrote: > > On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote: > >> This fixes a regression added in 4.9 with commit: > >> > >> commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 > >> Author

Re: [PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-13 Thread Mike Christie
On 08/13/2019 10:54 AM, Mike Christie wrote: > I was debating about sending a patch for not allowing > > blk_queue_rq_timeout(q, 9) I meant zero blk_queue_rq_timeout(q, 0) > > in a separate patchset, but I was not sure if people use that for > testing fast timeouts. >

Re: [PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-13 Thread Mike Christie
On 08/13/2019 10:45 AM, Mike Christie wrote: > On 08/13/2019 08:13 AM, Josef Bacik wrote: >> On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote: >>> This fixes a regression added in 4.9 with commit: >>> >>> commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 >>> Author: Josef Bacik >>> Date

Re: [PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-13 Thread Mike Christie
On 08/13/2019 08:13 AM, Josef Bacik wrote: > On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote: >> This fixes a regression added in 4.9 with commit: >> >> commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 >> Author: Josef Bacik >> Date: Thu Sep 8 12:33:40 2016 -0700 >> >> nbd: allo

Re: [PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-13 Thread Josef Bacik
On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote: > This fixes a regression added in 4.9 with commit: > > commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 > Author: Josef Bacik > Date: Thu Sep 8 12:33:40 2016 -0700 > > nbd: allow block mq to deal with timeouts > > where before

[PATCH 4/4] nbd: fix zero cmd timeout handling

2019-08-09 Thread Mike Christie
This fixes a regression added in 4.9 with commit: commit 0eadf37afc2500e1162c9040ec26a705b9af8d47 Author: Josef Bacik Date: Thu Sep 8 12:33:40 2016 -0700 nbd: allow block mq to deal with timeouts where before the patch userspace would set the timeout to 0 to disable it. With the above pat