Re: [PATCH v4 09/16] block: sed-opal: split generation of bytestring header and content

2019-02-08 Thread Derrick, Jonathan
Looks good Reviewed-by Jon Derrick On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote: > From: Jonas Rabenstein > > Split the header generation from the (normal) memcpy part if a > bytestring is copied into the command buffer. This allows in-place > generation of the bytestring content. For

Re: [PATCH v4 09/16] block: sed-opal: split generation of bytestring header and content

2019-02-04 Thread Christoph Hellwig
> + start = &cmd->cmd[cmd->pos]; > + return start; No need for the local start variable here, just return the computed address directly. Otherwise looks good: Reviewed-by: Christoph Hellwig

[PATCH v4 09/16] block: sed-opal: split generation of bytestring header and content

2019-02-01 Thread David Kozub
From: Jonas Rabenstein Split the header generation from the (normal) memcpy part if a bytestring is copied into the command buffer. This allows in-place generation of the bytestring content. For example, copy_from_user may be used without an intermediate buffer. Signed-off-by: Jonas Rabenstein