RE: [PATCH] hwrng: cctrn - Simplify with dev_err_probe()

2020-08-27 Thread Hadar Gat
k); > - return PTR_ERR(clk); > - } > + if (IS_ERR(clk)) > + return dev_err_probe(dev, PTR_ERR(clk), > + "Error getting clock\n"); > + > drvdata->clk = clk; > > rc = clk_prepare_enable(drvdata->clk); > -- > 2.17.1 Thanks for this code simplification. :-) Acked-by: Hadar Gat Hadar

RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF

2020-04-30 Thread Hadar Gat
> From: linux-crypto-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Herbert Xu > > On Thu, Apr 30, 2020 at 07:39:14AM +0000, Hadar Gat wrote: > > > > Yes, it builds, but it is useless. > > But that's the whole point of COMPILE_TEST. Herbert, I d

RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF

2020-04-30 Thread Hadar Gat
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Herbert Xu > > On Tue, Apr 28, 2020 at 12:26:31PM +, Hadar Gat wrote: > > > > I've set COMPILE_TEST but couldn't see any problem. > > Woul

RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF

2020-04-28 Thread Hadar Gat
> From: linux-crypto-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Herbert Xu > Sent: Monday, 27 April 2020 18:07 > > On Mon, Apr 27, 2020 at 02:36:02PM +0300, Hadar Gat wrote: > > The cctrng is unusable on non-DT systems so we should depend on it. > > &

[PATCH] crypto: ccree: fix finup

2018-06-21 Thread Hadar Gat
finup() operation was incorrect, padding was missing. Fix by setting the ccree HW to enable padding. Signed-off-by: Hadar Gat Cc: sta...@vger.kernel.org --- drivers/crypto/ccree/cc_hash.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/ccree