Re: [LTP] [LTP PATCH 0/2] ltp: fix af_alg02 to specify control data

Hi Eric, > It isn't clearly defined what happens if you read from an AF_ALG request > socket without previously sending the control data to begin an > encryption or decryption operation. On some kernels the read will > return 0, while on others it will block. > Testing this corner case isn't the

Re: [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests

Hi Eric, > > Changed since v1: > > - Define 'AF_ALG' in include/lapi/socket.h if undefined. > > Also move 'SOL_ALG' definition to there. > The only minor issue is with missing SOL_ALG on older distros. > Going to push it with this fix including lapi/socket.h on lib/tst_af_alg.c and > t

Re: [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests

Hi Eric, > This series adds helper functions for testing AF_ALG (the userspace > interface to algorithms in the Linux kernel's crypto API) to the > Linux Test Project. It then adds a few sample regression tests. > I've had these patches sitting around for a while with the goal of also > writing

Re: [LTP] [PATCH 4/6] crypto/af_alg03: new regression test for rfc7539 hash alg validation

Hi Eric, > > you forget to add af_alg03 into runtest/cve. > > The same applies to af_alg0{4,5}. > As far as I know, there are no CVEs assigned for those bugs. Wouldn't be better to add them to runtest/cve (or other runtest file) just with filename? And rename them in runtest file once the CVEs ar

Re: [LTP] [PATCH 0/6] ltp: AF_ALG test helpers and a few regression tests

Hi Eric, apart from missing AF_ALG for old distros and missing record in runtest/cve for af_alg0[3-5] LGTM. Sorry for delay with the review. Reviewed-by: Petr Vorel Kind regards, Petr > Hello, > This series adds helper functions for testing AF_ALG (the userspace > interface to algo

Re: [LTP] [PATCH 2/6] crypto/af_alg01: new regression test for hmac nesting bug

Hi Eric, > +static void run(void) > +{ > + /* try several different unkeyed hash algorithms */ > + static const char * const hash_algs[] = { > + "md5", "md5-generic", > + "sha1", "sha1-generic", > + "sha224", "sha224-generic", > + "sha256", "

Re: [LTP] [PATCH 1/6] lib: add tst_af_alg lib

Hi Eric, > From: Eric Biggers > Add helper functions for creating and using AF_ALG sockets. AF_ALG is > the userspace interface to algorithms in the Linux kernel's crypto API. > See https://www.kernel.org/doc/html/latest/crypto/userspace-if.html for > more information about this interface. AF_

Re: [LTP] [PATCH 4/6] crypto/af_alg03: new regression test for rfc7539 hash alg validation

Hi Eric, you forget to add af_alg03 into runtest/cve. The same applies to af_alg0{4,5}. Kind regards, Petr

Re: Backport e666d4e9ceec crypto: vmx - Use skcipher for ctr fallback

Hi Herbert, > On Thu, Aug 23, 2018 at 05:31:01PM +0200, Petr Vorel wrote: > > Hi, > > I wonder, it it makes sense to backport commit > > e666d4e9ceec crypto: vmx - Use skcipher for ctr fallback > > to v 4.14 stable kernel. > > I'm using it in 4.12+. > &

Backport e666d4e9ceec crypto: vmx - Use skcipher for ctr fallback

Hi, I wonder, it it makes sense to backport commit e666d4e9ceec crypto: vmx - Use skcipher for ctr fallback to v 4.14 stable kernel. I'm using it in 4.12+. These commits (somehow similar) has been backported to 4.10.2: 5839f555fa57 crypto: vmx - Use skcipher for xts fallback c96d0a1c47ab crypto: