Re: [PATCH] crypto: ccree: fix iv copying for small buffers

2018-06-21 Thread Herbert Xu
On Thu, Jun 21, 2018 at 04:35:44PM +0300, Gilad Ben-Yossef wrote: > > What about OFB? unless I've missed something there is no generic > implementation... ? In general we shouldn't add hardware drivers for algorithms that do not have a generic implementation. Sometimes they slip through though.

Re: [PATCH] crypto: ccree: fix iv copying for small buffers

2018-06-21 Thread Gilad Ben-Yossef
On Tue, Jun 19, 2018 at 5:27 PM, Herbert Xu wrote: > On Sun, Jun 17, 2018 at 01:06:42PM +0300, Gilad Ben-Yossef wrote: >> >> It was ctr(aes). I wrongly assumed that we are supposed to unconditionally >> copy >> the cipher-text block post operation and let the caller do with it what it >> wants and