Re: [PATCH] crypto: padlock-aes: Add ecx to outputs for rep instructions

2018-09-13 Thread Herbert Xu
On Fri, Sep 07, 2018 at 02:57:42AM +0100, Ben Hutchings wrote: > The current constraints for inline "rep xcrypt*" instructions mark ecx > as an input only. The compiler can therefore assume wrongly that ecx > holds the same value afterward, but in reality it will contain 0. > > This previously le

[PATCH] crypto: padlock-aes: Add ecx to outputs for rep instructions

2018-09-06 Thread Ben Hutchings
The current constraints for inline "rep xcrypt*" instructions mark ecx as an input only. The compiler can therefore assume wrongly that ecx holds the same value afterward, but in reality it will contain 0. This previously led to data corruption, which was fixed around by commit 46d8c4b28652 ("cry