Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-05 Thread Herbert Xu
On Wed, Mar 05, 2014 at 09:42:38AM -0600, Joel Fernandes wrote: > > In my testing it wasn't called from softirq, I'm using cryptodev which is > called from openssl through ioctl, here is a traceback (sorry about wrap): > > [] (cryptodev_ioctl+0x282/0x59c [cryptodev]) > [ 220.015390] [] (cryptodev

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-05 Thread Joel Fernandes
On 03/05/2014 01:11 AM, Herbert Xu wrote: > On Wed, Mar 05, 2014 at 04:18:12AM +, Fernandes, Joel wrote: >> >> >>> On Mar 4, 2014, at 8:00 PM, "Herbert Xu" >>> wrote: >>> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: HIGHMEM pages may not be mapped so we must kmap

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Herbert Xu
On Wed, Mar 05, 2014 at 04:18:12AM +, Fernandes, Joel wrote: > > > > On Mar 4, 2014, at 8:00 PM, "Herbert Xu" > > wrote: > > > >> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: > >> HIGHMEM pages may not be mapped so we must kmap them before accessing. > >> This resolves a

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Fernandes, Joel
> On Mar 4, 2014, at 8:00 PM, "Herbert Xu" wrote: > >> On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: >> HIGHMEM pages may not be mapped so we must kmap them before accessing. >> This resolves a random OOPs error that was showing up during OpenSSL SHA >> tests. >> >> Signed-o

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Herbert Xu
On Tue, Mar 04, 2014 at 12:30:54PM -0600, Joel Fernandes wrote: > HIGHMEM pages may not be mapped so we must kmap them before accessing. > This resolves a random OOPs error that was showing up during OpenSSL SHA > tests. > > Signed-off-by: Joel Fernandes > Cc: Herbert Xu > --- > v2 changes: >

[PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-04 Thread Joel Fernandes
HIGHMEM pages may not be mapped so we must kmap them before accessing. This resolves a random OOPs error that was showing up during OpenSSL SHA tests. Signed-off-by: Joel Fernandes Cc: Herbert Xu --- v2 changes: - don't check for HIGHMEM, kmap/kunmap do them anyway (Thanks Herbert). dr