Re: [PATCH v2 0/2] hwrng: Add support for qcpm v2 hwrng

2018-06-21 Thread Vinod
On 21-06-18, 23:30, Timur Tabi wrote: > > But there is a bigger concern raised by Herbert on this not being a true > > RNG and thus should be moved to crypto/ > > I've asked some of the crypto experts in Q to answer that question. That will be very helpful, I have not got any info on this. Altho

Re: [PATCH v2 0/2] hwrng: Add support for qcpm v2 hwrng

2018-06-21 Thread Timur Tabi
On 6/21/18 11:27 PM, Vinod wrote: I have checked the series. I am not sure I follow that this is v2 and you read CONFIG register. Apart from that other changes look mostly okay with few nitpicks:) It seems that there are two registers sets for v2 hardware, one with CONFIG and one without. I

Re: [PATCH v2 0/2] hwrng: Add support for qcpm v2 hwrng

2018-06-21 Thread Vinod
On 21-06-18, 10:17, Timur Tabi wrote: > On Tue, Jun 19, 2018 at 4:54 AM, Vinod Koul wrote: > > This series adds support for newer version of hwrng as found in > > Qualcomm SoCs. To do that add new v2 compatible string and driver_data > > values for v2. > > It's amazing you're sending this now, be

Re: [PATCH v2 0/2] hwrng: Add support for qcpm v2 hwrng

2018-06-21 Thread Timur Tabi
On Tue, Jun 19, 2018 at 4:54 AM, Vinod Koul wrote: > This series adds support for newer version of hwrng as found in > Qualcomm SoCs. To do that add new v2 compatible string and driver_data > values for v2. It's amazing you're sending this now, because I also have a PRNG patchset that I'm sending