On Sat, Sep 21, 2024 at 08:45:28AM +0300, Dan Carpenter wrote:
> On Fri, Sep 20, 2024 at 02:50:02PM +0200, Gustavo A. R. Silva wrote:
> > This is like container_of() but it has an assert to ensure that it's
> > using the first struct member.
> >
>
> I just remembered that Greg wanted this based o
On Sat, Aug 24, 2024 at 03:04:52PM +0800, Hongbo Li wrote:
> As discussed in the previous thread, the coccinelle rules and some
> replacements will be added in the future.
Then we have to wait for this one until then. Remember, we can not take
functions that no one calls, as they will be noticed
On Fri, Aug 23, 2024 at 04:22:32PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 23, 2024 at 9:13 AM Hongbo Li wrote:
> >
> > Add str_true_false()/str_false_true() helper to "true" or "false"
> > string literal. And we found more than 10 cases currently exist
> > in the tree. So these helpers can be
On Mon, Aug 19, 2024 at 10:59:45PM +0800, Wen Yang wrote:
> pstore_dump() is called when both preemption and local IRQ are disabled,
> and a spinlock is obtained, which is problematic for the RT kernel because
> in this configuration, spinlocks are sleep locks.
>
> Replace the spinlock_t with raw_
On Tue, Jul 23, 2024 at 12:04:41PM +0200, Thorsten Leemhuis wrote:
> On 23.07.24 06:11, Theodore Ts'o wrote:
> > On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
> >>> Is strscpy_pad appropriate if the @src parameter itself is a fixed
> >>> length char[16] which isn't null terminated when
On Tue, Jul 09, 2024 at 09:24:54AM +, LEROY Christophe wrote:
>
>
> Le 09/07/2024 à 11:15, Greg KH a écrit :
> > On Mon, Jul 08, 2024 at 03:12:55PM +, LEROY Christophe wrote:
> >>
> >>
> >> Le 08/07/2024 à 14:36, Greg KH a écrit :
> >>&
On Mon, Jul 08, 2024 at 03:12:55PM +, LEROY Christophe wrote:
>
>
> Le 08/07/2024 à 14:36, Greg KH a écrit :
> > On Sun, Jul 07, 2024 at 03:34:15PM +0800, WangYuli wrote:
> >>
> >> On 2024/7/6 17:30, Greg KH wrote:
> >>> This makes it sound l
On Sun, Jul 07, 2024 at 03:34:15PM +0800, WangYuli wrote:
>
> On 2024/7/6 17:30, Greg KH wrote:
> > This makes it sound like you are reverting this because of a build
> > error, which is not the case here, right? Isn't this because of the
> > powerpc issue
On Sat, Jul 06, 2024 at 11:11:01AM +0800, WangYuli wrote:
> This reverts commit 08f6c05feb1db21653e98ca84ea04ca032d014c7.
>
> Upstream commit e60adf513275 ("bpf: Take return from set_memory_rox() into
> account with bpf_jit_binary_lock_ro()")
> depends on
> upstream commit 1dad391daef1 ("bpf, arm
On Mon, Jun 10, 2024 at 02:02:27PM -0700, Kees Cook wrote:
> When reworking the range checking for get_user(), the get_user_8() case
> on 32-bit wasn't zeroing the high register. (The jump to bad_get_user_8
> was accidentally dropped.) Restore the correct error handling
> destination (and rename th
On Thu, May 16, 2024 at 03:28:16PM +, Manthey, Norbert wrote:
> Dear Kees, all,
>
> we published an extension for the Coverity model that is used by the
> CoverityScan setup for the Linux kernel [1]. We have been using this
> extension to analyze the 6.1 kernel branch, and reported some fixes
On Thu, Feb 29, 2024 at 10:59:10PM -0800, Jakub Kicinski wrote:
> On Thu, 29 Feb 2024 13:30:22 -0800 Kees Cook wrote:
> > Introduce a new struct net_device_priv that contains struct net_device
> > but also accounts for the commonly trailing bytes through the "size" and
> > "data" members.
>
> I'm
On Thu, Feb 29, 2024 at 02:22:00PM +0800, Kai-Heng Feng wrote:
> When inserting an SD7.0 card to Realtek card reader, the card reader
> unplugs itself and morph into a NVMe device. The slot Link down on hot
> unplugged can cause the following error:
>
> pcieport :00:1c.0: pciehp: Slot(8): Link
/sys/kernel/notes: hypercall_page @ 156
> /sys/kernel/notes: xen_hypercall_set_trap_table @ 156
> /sys/kernel/notes: startup_xen @ 132
>
> Signed-off-by: Kees Cook
> ---
> Cc: "Tobin C. Harding"
> Cc: Tycho Andersen
> Cc: Greg KH
> Cc: Guixiong Wei
On Sun, Feb 18, 2024 at 03:35:01PM +0800, Guixiong Wei wrote:
> From: Guixiong Wei
>
> Restrict non-privileged user access to /sys/kernel/notes to
> avoid security attack.
>
> The non-privileged users have read access to notes. The notes
> expose the load address of startup_xen. This address cou
On Wed, Jan 03, 2024 at 01:00:58PM +0800, 孟敬姿 wrote:
> Hi, we suggest revisiting the capability checks in
> check_syslog_permissions(). Currently CAP_SYSLOG is checked first, and
> if it’s not there but there is a CAP_SYS_ADMIN, it can also pass the
> check. We recommend refining this check to excl
On Tue, Dec 19, 2023 at 03:00:22PM -0800, Nick Desaulniers wrote:
> ---
>
> For Google specific guidance, I'll quote what they have:
>
> > License Headers and Copyright Notices
> > Googlers should add Google's copyright notice (or a "The Project Authors"
> > style copyright notice) to new files
On Tue, Dec 19, 2023 at 10:35:55AM -0800, Tanzir Hasan wrote:
> > Legal note, this file is NOT copyright Google as no Google employe
> > actually wrote the logcal contents of it.
> >
> > Please be VERY careful when doing stuff like this, it has potentially
> > big repercussions, and you don't want
On Tue, Dec 19, 2023 at 06:09:52PM +, Tanzir Hasan wrote:
> This diff uses an open source tool include-what-you-use (IWYU) to modify
> the include list changing indirect includes to direct includes.
> IWYU is implemented using the IWYUScripts github repository which is a tool
> that is
> curre
On Tue, Dec 19, 2023 at 06:09:51PM +, Tanzir Hasan wrote:
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -39,13 +39,6 @@
>
> #define STACK_MAGIC 0xdeadbeef
>
> -/**
> - * REPEAT_BYTE - repeat the value @x multiple times as an unsigned long value
> - * @x: value to repe
On Mon, Dec 18, 2023 at 06:44:47PM +, tanz...@google.com wrote:
> This patch creates wordpart.h and includes it in asm/word-at-a-time.h
> for the all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h
> because of REPEAT_BYTE. Moving this to another header and including it
> where nece
On Wed, Dec 06, 2023 at 03:00:47AM +, Al Viro wrote:
> On Wed, Dec 06, 2023 at 12:55:42AM +, Al Viro wrote:
> > On Wed, Dec 06, 2023 at 08:46:50AM +0900, Greg KH wrote:
> > > > >
> > > > > But of course, it doesn't always hold true, there are a
On Tue, Dec 05, 2023 at 02:14:55PM -0800, Nick Desaulniers wrote:
> On Tue, Dec 5, 2023 at 1:59 PM Greg KH wrote:
> >
> > On Tue, Dec 05, 2023 at 01:51:10PM -0800, Nick Desaulniers wrote:
> > > On Tue, Dec 5, 2023 at 1:38 PM Al Viro wrote:
> > > >
> >
On Tue, Dec 05, 2023 at 01:51:10PM -0800, Nick Desaulniers wrote:
> On Tue, Dec 5, 2023 at 1:38 PM Al Viro wrote:
> >
> > On Tue, Dec 05, 2023 at 08:58:53PM +, tanz...@google.com wrote:
> > > This diff uses an open source tool include-what-you-use (IWYU) to modify
> > > the include list changi
On Fri, Nov 24, 2023 at 10:27:32PM +0100, Luka Panio wrote:
> Signed-off-by: Luka Panio
> Acked-by: Krzysztof Kozlowski
> Acked-by: Konrad Dybcio
>
> ---
> v2:
> Update commit message. Drop reserved gpio's as this device in reality do not
> have gpio, and pins are not protected.
Again, I see
On Fri, Nov 24, 2023 at 10:27:31PM +0100, Luka Panio wrote:
> Acked-by: Conor Dooley
> Signed-off-by: Luka Panio
>
> ---
> v2:
> Update commit message
What commit message? I know I can't take patches without any changelog
text, maybe other maintainers are more loose?
thanks,
greg k-h
On Wed, Nov 01, 2023 at 03:14:21PM +0800, Xingxing Luo wrote:
> When connecting USB to PC, there is a very low probability of kernel
> crash. The reason is that in ep0_txstate(), the buf member of struct
> usb_request used may be a null pointer. Therefore, it needs to
> determine whether it is null
On Wed, Nov 01, 2023 at 03:14:21PM +0800, Xingxing Luo wrote:
> When connecting USB to PC, there is a very low probability of kernel
> crash. The reason is that in ep0_txstate(), the buf member of struct
> usb_request used may be a null pointer. Therefore, it needs to
> determine whether it is null
On Mon, Oct 23, 2023 at 05:31:53PM +0800, Xingxing Luo wrote:
> When connecting USB to PC, there is a very low probability of kernel
> crash. The reason is that in ep0_txstate(), the buf member of struct
> usb_request used may be a null pointer. Therefore, it needs to
> determine whether it is null
On Sun, Oct 22, 2023 at 06:35:47PM +0700, James Tirta Halim wrote:
> ---
> include/linux/string.h | 9 ++---
> tools/bpf/bpftool/gen.c | 2 +-
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/string.h b/include/linux/string.h
> index dbfc66400050..1c51039604e
On Sat, Oct 21, 2023 at 10:18:39PM +0200, luka177 wrote:
> Add a compatible for Xiaomi Pad 6.
>
> From: luka177
>
> Signed-off-by: luka177
>
> ---
> Add "From:" in commit message
That's not how that works, it needs to be the first line. The
documentation states this, right?
And "177" should
On Sat, Oct 21, 2023 at 09:37:16PM +0200, Лука Паньо wrote:
> This is a new version, but there is no change for dt-bindings part.
Then you must document this.
> As for
> "From:" submitting-patches.rst: "Note, the From: tag is optional when the
> From: author is also the person (and
> email) liste
On Sat, Oct 21, 2023 at 07:13:51PM +0200, Christophe JAILLET wrote:
> strncat() usage in thunderx_ocx_com_threaded_isr() is wrong.
> The size given to strncat() is the maximum number of bytes that can be
> written, excluding the trailing NULL.
>
> Here, the size of the 'msg' buffer is used (i.e. O
On Sat, Oct 21, 2023 at 07:33:17PM +0200, luka177 wrote:
> Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc.
>
> Signed-off-by: luka177
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm8250-xiaomi-pipa.dts | 625 ++
> 2 files
On Fri, Oct 20, 2023 at 04:35:45AM +0100, Matthew Wilcox (Oracle) wrote:
> To make seq_buf more lightweight as a string buf, move the readpos member
> from seq_buf to its container, trace_seq. That puts the responsibility
> of maintaining the readpos entirely in the tracing code. If some future
>
35 matches
Mail list logo
