Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"

2021-04-09 Thread Saravana Kannan
On Fri, Apr 9, 2021 at 12:26 PM Rob Herring wrote: > > On Wed, Apr 7, 2021 at 3:45 PM Ilya Lipnitskiy > wrote: > > > > On Tue, Apr 6, 2021 at 6:24 PM Saravana Kannan wrote: > > > > > > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring wrote: > > > > > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kann

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Andrew Lunn
On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. So apart from c45 vs c22, how does this differ to nxp-tja11xx.c? Do we really want two different drivers for the same hardware? Can we combine them somehow? > +conf

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread Nick Desaulniers
On Fri, Apr 9, 2021 at 4:18 AM Peter Zijlstra wrote: > > On Fri, Apr 09, 2021 at 12:55:18PM +0200, Florian Weimer wrote: > > * Ard Biesheuvel: > > > > > Wouldn't that require the compiler to interpret the contents of the > > > asm() block? > > > > Yes and no. It would require proper toolchain sup

Re: [PATCH v3] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation

2021-04-09 Thread Konrad Rzeszutek Wilk
On Thu, Apr 08, 2021 at 08:13:07PM -0700, Florian Fainelli wrote: > > > On 3/24/2021 1:42 AM, Christoph Hellwig wrote: > > On Mon, Mar 22, 2021 at 06:53:49PM -0700, Florian Fainelli wrote: > >> When SWIOTLB_NO_FORCE is used, there should really be no allocations of > >> default_nslabs to occur si

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 21:41:06 +0300 Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. > > Signed-off-by: Radu Pirea (NXP OSS) drivers/net/phy/nxp-c45: struct mdio_device_id is 8 bytes. The last of 1 is: 0x10 0xb0 0x1b 0x00 0xf0 0xff 0xff 0xff FATAL: modpos

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias Apa

Re: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-09 Thread Chris von Recklinghausen
On 4/9/21 12:56 PM, David Laight wrote: From: Chris von Recklinghausen Sent: 08 April 2021 11:46 Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. Prior to this patch, MD5 is used only to create a digest to ensure i

Re: [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 01:25:26AM CDT, Zev Weiss wrote: >On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: >> >> >>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >>>On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: Make the KCS device drivers responsible for allocating

Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"

2021-04-09 Thread Rob Herring
On Wed, Apr 7, 2021 at 3:45 PM Ilya Lipnitskiy wrote: > > On Tue, Apr 6, 2021 at 6:24 PM Saravana Kannan wrote: > > > > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring wrote: > > > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kannan > > > wrote: > > > > > > > > On Tue, Apr 6, 2021 at 5:34 PM Rob H

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Samudrala, Sridhar
On 4/9/2021 11:37 AM, Jakub Kicinski wrote: On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote: On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote: On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: I'd like to discuss a possibility of handling devlink port parameters with devlink p

[PATCH v2 5/5] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-04-09 Thread Amey Narkhede
Add reset_method sysfs attribute to enable user to query and set user preferred device reset methods and their ordering. Reviewed-by: Alex Williamson Reviewed-by: Raphael Norwitz Co-developed-by: Alex Williamson Signed-off-by: Alex Williamson Signed-off-by: Amey Narkhede --- Documentation/AB

[PATCH v2 4/5] PCI: Remove reset_fn field from pci_dev

2021-04-09 Thread Amey Narkhede
reset_fn field is used to indicate whether the device supports any reset mechanism or not. Deprecate use of reset_fn in favor of new reset_methods array which can be used to keep track of all supported reset mechanisms of a device and their ordering. The octeon driver is incorrectly using reset_fn

[PATCH v2 3/5] PCI: Add new array for keeping track of ordering of reset methods

2021-04-09 Thread Amey Narkhede
Introduce a new array reset_methods in struct pci_dev to keep track of reset mechanisms supported by the device and their ordering. Also refactor probing and reset functions to take advantage of calling convention of reset functions. Reviewed-by: Alex Williamson Reviewed-by: Raphael Norwitz Co-d

[PATCH v2 2/5] PCI: Add pcie_reset_flr to follow calling convention of other reset methods

2021-04-09 Thread Amey Narkhede
Currently there is separate function pcie_has_flr to probe if pcie flr is supported by the device which does not match the calling convention followed by reset methods which use second function argument to decide whether to probe or not. Add new function pcie_reset_flr that follows the calling conv

[PATCH v2 1/5] PCI: merge slot and bus reset implementations

2021-04-09 Thread Amey Narkhede
From: Raphael Norwitz Slot resets are bus resets with additional logic to prevent a device from being removed during the reset. Currently slot and bus resets have separate implementations in pci.c, complicating higher level logic. As discussed on the mailing list, they should be combined into a g

[PATCH v2 0/5] Expose and manage PCI device reset

2021-04-09 Thread Amey Narkhede
PCI and PCIe devices may support a number of possible reset mechanisms for example Function Level Reset (FLR) provided via Advanced Feature or PCIe capabilities, Power Management reset, bus reset, or device specific reset. Currently the PCI subsystem creates a policy prioritizing these reset method

Re: [PATCH v3 3/8] dt-bindings:iio:adc: update motorola,cpcap-adc.yaml reference

2021-04-09 Thread Rob Herring
On Fri, 09 Apr 2021 14:47:47 +0200, Mauro Carvalho Chehab wrote: > Changeset 1ca9d1b1342d ("dt-bindings:iio:adc:motorola,cpcap-adc yaml > conversion") > renamed: Documentation/devicetree/bindings/iio/adc/cpcap-adc.txt > to: Documentation/devicetree/bindings/iio/adc/motorola,cpcap-adc.yaml. > > Up

Re: [PATCH v2 09/21] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:48:21AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 13:26, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote: >> >Take steps towards defining a coherent API to separate the KCS device >> >drivers from the userspace interface. Decr

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

2021-04-09 Thread Florian Fainelli
On 4/9/2021 2:53 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.111 release. > There are 23 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 20:40 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 09:48:33AM -0400, David Malcolm wrote: > > You tried __pure on arch_static_branch; did you try it on > > static_branch_unlikely? > > static_branch_unlikely() is a CPP macro that expands to a statement > expression,

[PATCH] MIPS: generic: Update node names to avoid unit addresses

2021-04-09 Thread Nathan Chancellor
With the latest mkimage from U-Boot 2021.04, the generic defconfigs no longer build, failing with: /usr/bin/mkimage: verify_header failed for FIT Image support with exit code 1 This is expected after the linked U-Boot commits because '@' is forbidden in the node names due to the way that libfdt t

[PATCH v12 4/4] MAINTAINERS: add MT7621 CLOCK maintainer

2021-04-09 Thread Sergio Paracuellos
Adding myself as maintainer for mt7621 clock driver. Signed-off-by: Sergio Paracuellos --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 809a68af5efd..ecad5d972122 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11288,6 +11288,12 @@ L: l

[PATCH v12 2/4] staging: mt7621-dts: make use of new 'mt7621-clk'

2021-04-09 Thread Sergio Paracuellos
Clocks for SoC mt7621 have been properly integrated so there is no need to declare fixed clocks at all in the device tree. Remove all of them, add new device tree nodes for mt7621-clk and update the rest of the nodes to use them. Acked-by: Greg Kroah-Hartman Signed-off-by: Sergio Paracuellos ---

[PATCH v12 3/4] staging: mt7621-dts: use valid vendor 'mediatek' instead of invalid 'mtk'

2021-04-09 Thread Sergio Paracuellos
Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml' contains 'mediatek' as a valid vendor string. Some nodes in the device tree are using an invalid vendor string vfor 'mtk' instead. Fix all of them in dts file. Update also ralink mt7621 related code to properly match new string

[PATCH v12 1/4] clk: ralink: add clock driver for mt7621 SoC

2021-04-09 Thread Sergio Paracuellos
The documentation for this SOC only talks about two registers regarding to the clocks: * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped refclock. PLL and dividers used for CPU and some sort of BUS. * SYSC_REG_CPLL_CLKCFG1 - a banch of gates to enable/disable clocks for all or s

[PATCH v12 0/4] MIPS: ralink: add CPU clock detection and clock driver for MT7621

2021-04-09 Thread Sergio Paracuellos
This patchset ports CPU clock detection for MT7621 from OpenWrt and adds a complete clock plan for the mt7621 SOC. The documentation for this SOC only talks about two registers regarding to the clocks: * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped refclock. PLL and dividers

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Heiner Kallweit
On 09.04.2021 20:41, Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. > > Signed-off-by: Radu Pirea (NXP OSS) > --- > MAINTAINERS | 6 + > drivers/net/phy/Kconfig | 6 + > drivers/net/phy/Makefile | 1 + > drivers/net/phy/nxp-c45.c |

Re: [PATCH v3 2/8] dt-bindings: fix references for iio-bindings.txt

2021-04-09 Thread Rob Herring
On Fri, 09 Apr 2021 14:47:46 +0200, Mauro Carvalho Chehab wrote: > The iio-bindings.txt was converted into two files and merged > at the dt-schema git tree at: > > https://github.com/devicetree-org/dt-schema > > Yet, some documents still refer to the old file. Fix their > references, in ord

Re: [PATCH v3 1/8] dt-bindings: don't use ../dir for doc references

2021-04-09 Thread Rob Herring
On Fri, 09 Apr 2021 14:47:45 +0200, Mauro Carvalho Chehab wrote: > As documents have been renamed and moved around, their > references will break, but this will be unnoticed, as the > script which checks for it won't handle "../" references. > > So, replace them by the full patch. > > Signed-off-

[gustavoars-linux:testing/xfs-fixed] BUILD SUCCESS 29cccbe7974279cab3786063db20a1146b1c4918

2021-04-09 Thread kernel test robot
randconfig-a006-20210409 i386 randconfig-a003-20210409 i386 randconfig-a001-20210409 i386 randconfig-a004-20210409 i386 randconfig-a002-20210409 i386 randconfig-a005-20210409 x86_64 randconfig

[PATCH v7 28/28] mm/filemap: Convert page wait queues to be folios

2021-04-09 Thread Matthew Wilcox (Oracle)
Reinforce that if we're waiting for a bit in a struct page, that's actually in the head page by changing the type from page to folio. Increases the size of cachefiles by two bytes, but the kernel core is unchanged in size. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Ack

Re: Problem in pfmemalloc skb handling in net/core/dev.c

2021-04-09 Thread Xie He
On Fri, Apr 9, 2021 at 4:50 AM Eric Dumazet wrote: > > On 4/9/21 12:14 PM, Xie He wrote: > > Then simply copy the needed logic. No, there's no such thing as "sockets" in some of the protocols. There is simply no way to copy "the needed logic". > > Also, I think this is a problem in net/core/dev.

[PATCH v7 27/28] mm/filemap: Convert wake_up_page_bit to wake_up_folio_bit

2021-04-09 Thread Matthew Wilcox (Oracle)
All callers have a folio, so use it directly. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- mm/filemap.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 8f07e21a8f2

[PATCH v7 26/28] mm/filemap: Convert wait_on_page_bit to wait_on_folio_bit

2021-04-09 Thread Matthew Wilcox (Oracle)
We must always wait on the folio, otherwise we won't be woken up. This commit shrinks the kernel by 691 bytes, mostly due to moving the page waitqueue lookup into wait_on_folio_bit_common(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- includ

[PATCH v7 25/28] mm/writeback: Add wait_for_stable_folio

2021-04-09 Thread Matthew Wilcox (Oracle)
Move wait_for_stable_page() into the folio compatibility file. wait_for_stable_folio() avoids a call to compound_head() and is 14 bytes smaller than wait_for_stable_page() was. The net text size grows by 24 bytes as a result of this patch. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Chri

[PATCH v7 24/28] mm/writeback: Add wait_on_folio_writeback

2021-04-09 Thread Matthew Wilcox (Oracle)
wait_on_page_writeback_killable() only has one caller, so convert it to call wait_on_folio_writeback_killable(). For the wait_on_page_writeback() callers, add a compatibility wrapper around wait_on_folio_writeback(). Turning PageWriteback() into FolioWriteback() eliminates a call to compound_head

[PATCH v7 23/28] mm/filemap: Add end_folio_writeback

2021-04-09 Thread Matthew Wilcox (Oracle)
Add an end_page_writeback() wrapper function for users that are not yet converted to folios. end_folio_writeback() is less than half the size of end_page_writeback() at just 105 bytes compared to 213 bytes, due to removing all the compound_head() calls. The 30 byte wrapper function makes this a n

[PATCH v7 22/28] mm/filemap: Add wait_on_folio_locked

2021-04-09 Thread Matthew Wilcox (Oracle)
Also add wait_on_folio_locked_killable(). Turn wait_on_page_locked() and wait_on_page_locked_killable() into wrappers. This eliminates a call to compound_head() from each call-site, reducing text size by 200 bytes for me. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Ac

[PATCH v7 21/28] mm/filemap: Add __lock_folio_or_retry

2021-04-09 Thread Matthew Wilcox (Oracle)
Convert __lock_page_or_retry() to __lock_folio_or_retry(). This actually saves 4 bytes in the only caller of lock_page_or_retry() (due to better register allocation) and saves the 20 byte cost of calling page_folio() in __lock_folio_or_retry() for a total saving of 24 bytes. Signed-off-by: Matthe

[PATCH v7 20/28] mm/filemap: Add __lock_folio_async

2021-04-09 Thread Matthew Wilcox (Oracle)
There aren't any actual callers of lock_page_async(), so remove it. Convert filemap_update_page() to call __lock_folio_async(). __lock_folio_async() is 21 bytes smaller than __lock_page_async(), but the real savings come from using a folio in filemap_update_page(), shrinking it from 514 bytes to 4

[PATCH v7 19/28] mm/filemap: Add lock_folio_killable

2021-04-09 Thread Matthew Wilcox (Oracle)
This is like lock_page_killable() but for use by callers who know they have a folio. Convert __lock_page_killable() to be __lock_folio_killable(). This saves one call to compound_head() per contended call to lock_page_killable(). __lock_folio_killable() is 20 bytes smaller than __lock_page_killa

[PATCH v3.2 02/10] erofs: introduce multipage per-CPU buffers

2021-04-09 Thread Gao Xiang
From: Gao Xiang To deal the with the cases which inplace decompression is infeasible for some inplace I/O. Per-CPU buffers was introduced to get rid of page allocation latency and thrash for low-latency decompression algorithms such as lz4. For the big pcluster feature, introduce multipage per-C

[PATCH v7 18/28] mm/filemap: Add lock_folio

2021-04-09 Thread Matthew Wilcox (Oracle)
This is like lock_page() but for use by callers who know they have a folio. Convert __lock_page() to be __lock_folio(). This saves one call to compound_head() per contended call to lock_page(). Saves 362 bytes of text; mostly from improved register allocation and inlining decisions. __lock_folio

Re: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove

2021-04-09 Thread David Hildenbrand
zone_pcp_reset still needs to exist to drain the remaining vmstats or it'll break 5a883813845a ("memory-hotplug: fix zone stat mismatch"). Are you sure we are reseting vmstats in the hotremove. I do not see anything like that. Maybe this was needed at the time. I will double check. zone_pcp_re

[PATCH v7 17/28] mm/filemap: Add unlock_folio

2021-04-09 Thread Matthew Wilcox (Oracle)
Convert unlock_page() to call unlock_folio(). By using a folio we avoid a call to compound_head(). This shortens the function from 39 bytes to 25 and removes 4 instructions on x86-64. Because we still have unlock_page(), it's a net increase of 24 bytes of text for the kernel as a whole, but any

[PATCH v7 16/28] mm/memcg: Add folio wrappers for various functions

2021-04-09 Thread Matthew Wilcox (Oracle)
Add new wrapper functions folio_memcg(), lock_folio_memcg(), unlock_folio_memcg(), mem_cgroup_folio_lruvec() and count_memcg_folio_event() Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/memcontrol.h | 30 +++

[PATCH v7 15/28] mm: Add folio_mapcount

2021-04-09 Thread Matthew Wilcox (Oracle)
This is the folio equivalent of page_mapcount(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/mm.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 143b354c3f4a..

[PATCH v7 14/28] mm/util: Add folio_mapping and folio_file_mapping

2021-04-09 Thread Matthew Wilcox (Oracle)
These are the folio equivalent of page_mapping() and page_file_mapping(). Add an out-of-line page_mapping() wrapper around folio_mapping() in order to prevent the page_folio() call from bloating every caller of page_mapping(). Adjust page_file_mapping() and page_mapping_file() to use folios intern

[PATCH v7 13/28] mm/filemap: Add folio_offset and folio_file_offset

2021-04-09 Thread Matthew Wilcox (Oracle)
These are just wrappers around their page counterpart. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/pagemap.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > Co-developed-by: Jesper Dangaard Brouer > > Co-developed-by: Matteo Croce > > Signed-off-by: Ilias Apalodimas > > Checkpatch says we need sign-offs from all authors. > Es

[PATCH v7 12/28] mm/filemap: Add folio_next_index

2021-04-09 Thread Matthew Wilcox (Oracle)
This helper returns the page index of the next folio in the file (ie the end of this folio, plus one). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/pagemap.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/includ

[Outreachy kernel][PATCH 1/2] staging: media: omap4iss: Align line break to the open parenthesis in file iss.c

2021-04-09 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/omap4iss/iss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/d

[Outreachy kernel][PATCH 2/2] staging: media: omap4iss: Align line break to the open parenthesis in file iss_video.c

2021-04-09 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/omap4iss/iss_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/omap4iss/

[PATCH v7 11/28] mm/filemap: Add folio_index, folio_file_page and folio_contains

2021-04-09 Thread Matthew Wilcox (Oracle)
folio_index() is the equivalent of page_index() for folios. folio_file_page() is the equivalent of find_subpage(). folio_contains() is the equivalent of thp_contains(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/pagemap.h | 53

[PATCH v7 10/28] mm: Handle per-folio private data

2021-04-09 Thread Matthew Wilcox (Oracle)
Add folio_private() and set_folio_private() which mirror page_private() and set_page_private() -- ie folio private data is the same as page private data. The only difference is that these return a void * instead of an unsigned long, which matches the majority of users. Turn attach_page_private()

Re: [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events

2021-04-09 Thread David Hildenbrand
On 09.04.21 12:14, Oscar Salvador wrote: On Thu, Apr 08, 2021 at 11:52:51AM +0200, Oscar Salvador wrote: I am not really into PMEM, and I ignore whether we need CONFIG_MEMORY_HOTPLUG in order to have such memory on the system. If so, the following can be partly ignored. Ok, I refreshed by memo

[PATCH v7 09/28] mm: Create FolioFlags

2021-04-09 Thread Matthew Wilcox (Oracle)
These new functions are the folio analogues of the PageFlags functions. If CONFIG_DEBUG_VM_PGFLAGS is enabled, we check the folio is not a tail page at every invocation. Note that this will also catch the PagePoisoned case as a poisoned page has every bit set, which would include PageTail. This s

[PATCH v7 08/28] mm: Add get_folio

2021-04-09 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call get_folio() instead of get_page() and save the overhead of calling compound_head(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/mm.h | 26 +- 1

Re: [PATCH v16 00/17] KVM RISC-V Support

2021-04-09 Thread Palmer Dabbelt
On Wed, 31 Mar 2021 02:21:58 PDT (-0700), pbonz...@redhat.com wrote: On 30/03/21 07:48, Anup Patel wrote: It seems Andrew does not want to freeze H-extension until we have virtualization aware interrupt controller (such as RISC-V AIA specification) and IOMMU. Lot of us feel that these things ca

Re: [PATCH 3/3] nvmem: eeprom: add documentation for FRAM

2021-04-09 Thread Rob Herring
On Fri, 09 Apr 2021 17:47:20 +0200, Jiri Prchal wrote: > Added dt binding documentation. > > Signed-off-by: Jiri Prchal > --- > Documentation/devicetree/bindings/eeprom/at25.yaml | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKE

[PATCH v7 07/28] mm: Add put_folio

2021-04-09 Thread Matthew Wilcox (Oracle)
If we know we have a folio, we can call put_folio() instead of put_page() and save the overhead of calling compound_head(). Also skips the devmap checks. This commit looks like it should be a no-op, but actually saves 1312 bytes of text with the distro-derived config that I'm testing. Some funct

Re: [PATCH 02/11] mm/page_alloc: Convert per-cpu list protection to local_lock

2021-04-09 Thread Peter Zijlstra
On Fri, Apr 09, 2021 at 02:32:56PM +0100, Mel Gorman wrote: > That said, there are some curious users already. > fs/squashfs/decompressor_multi_percpu.c looks like it always uses the > local_lock in CPU 0's per-cpu structure instead of stabilising a per-cpu > pointer. I'm not sure how you read th

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > Co-developed-by: Jesper Dangaard Brouer > Co-developed-by: Matteo Croce > Signed-off-by: Ilias Apalodimas Checkpatch says we need sign-offs from all authors. Especially you since you're posting.

[PATCH v7 06/28] mm: Add folio reference count functions

2021-04-09 Thread Matthew Wilcox (Oracle)
These functions mirror their page reference counterparts. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- Documentation/core-api/mm-api.rst | 1 + include/linux/page_ref.h | 88 ++- 2 files changed, 88 insert

Re: [PATCH 1/3] dt-bindings: mfd: pm8008: Add IRQ listing

2021-04-09 Thread Rob Herring
On Fri, Apr 09, 2021 at 10:55:19AM -0500, Bjorn Andersson wrote: > On Thu 08 Apr 19:38 CDT 2021, Guru Das Srinagesh wrote: > > > Add a header file listing all of the IRQs that Qualcomm Technologies, > > Inc. PM8008 supports. The constants defined in this file may be used in > > the client device t

[PATCH v7 05/28] mm/debug: Add VM_BUG_ON_FOLIO and VM_WARN_ON_ONCE_FOLIO

2021-04-09 Thread Matthew Wilcox (Oracle)
These are the folio equivalents of VM_BUG_ON_PAGE and VM_WARN_ON_ONCE_PAGE. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/mmdebug.h | 20 1 file changed, 20 insertions(+) diff --git a/inc

Re: [PATCH v2] integrity: Add declarations to init_once void arguments.

2021-04-09 Thread Mimi Zohar
Hi Jiele, On Wed, 2021-04-07 at 01:44 +, Jiele Zhao wrote: > init_once is a callback to kmem_cache_create. The parameter > type of this function is void *, so it's better to give a > explicit cast here. > > Signed-off-by: Jiele Zhao > --- > security/integrity/iint.c | 2 +- > securi

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote: > From: Matteo Croce > > use the new helper macro skb_for_each_frag() which allows to iterate > through all the SKB fragments. > > The patch was created with Coccinelle, this was the semantic patch: Bunch of set but not used warnings here.

[PATCH v7 04/28] mm/vmstat: Add functions to account folio statistics

2021-04-09 Thread Matthew Wilcox (Oracle)
Allow page counters to be more readily modified by callers which have a folio. Name these wrappers with 'stat' instead of 'state' as requested by Linus here: https://lore.kernel.org/linux-mm/CAHk-=wj847sudr-kt+46ft3+xffgiwpgthvm7djwgdi4cvr...@mail.gmail.com/ Signed-off-by: Matthew Wilcox (Oracle)

[PATCH v7 03/28] mm: Add folio_pgdat and folio_zone

2021-04-09 Thread Matthew Wilcox (Oracle)
These are just convenience wrappers for callers with folios; pgdat and zone can be reached from tail pages as well as head pages. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Zi Yan Reviewed-by: Christoph Hellwig Acked-by: Jeff Layton --- include/linux/mm.h | 10 ++ 1 file chan

Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote: > dt_binding_check reports the below error with the latest schema: > > Documentation/devicetree/bindings/media/renesas,drif.yaml: > properties:clock-names:maxItems: False schema does not allow 1 > Documentation/devicetree/bindings/media/

[PATCH v7 02/28] mm: Introduce struct folio

2021-04-09 Thread Matthew Wilcox (Oracle)
A struct folio is a new abstraction to replace the venerable struct page. A function which takes a struct folio argument declares that it will operate on the entire (possibly compound) page, not just PAGE_SIZE bytes. In return, the caller guarantees that the pointer it is passing does not point to

Re: [PATCH 14/15] dt-bindings: remoteproc: qcom: pas: Add binding for SDX55

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 22:34:56 +0530, Manivannan Sadhasivam wrote: > Add devicetree binding for SDX55 remoteproc. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 4 > 1 file chang

[PATCH v7 01/28] mm: Optimise nth_page for contiguous memmap

2021-04-09 Thread Matthew Wilcox (Oracle)
If the memmap is virtually contiguous (either because we're using a virtually mapped memmap or because we don't support a discontig memmap at all), then we can implement nth_page() by simple addition. Contrary to popular belief, the compiler is not able to optimise this itself for a vmemmap configu

Re: [PATCH 12/15] dt-bindings: arm: qcom: Add binding for Thundercomm T55 kit

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 22:34:54 +0530, Manivannan Sadhasivam wrote: > Add devicetree binding for Thundercomm T55 Dev kit based on SDX55. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 fi

Re: [PATCH 10/15] dt-bindings: arm: qcom: Add binding for Telit FN980 TLB board

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 22:34:52 +0530, Manivannan Sadhasivam wrote: > Add devicetree binding for Telit FN980 TLB board based on SDX55. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file

Re: [PATCH 06/15] dt-bindings: firmware: scm: Add compatible for SDX55

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 22:34:48 +0530, Manivannan Sadhasivam wrote: > Add devicetree compatible for SCM present in SDX55 platform. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + > 1

[PATCH v7 00/28] Memory Folios

2021-04-09 Thread Matthew Wilcox (Oracle)
git/shortlog/refs/heads/folio (contains another ~100 patches on top of this batch, not all of which are in good shape for submission) v7: - Rebase on next-20210409 - keep up with afs changes - wait_on_page_fscache() no longer needs to be modified - unlock_page_private_2() changed to end_page_

Re: [PATCH v2 3/3] dt-bindings: qcom: geni-se: document iommus

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 16:21:14 +, Caleb Connolly wrote: > Document the iommus property for QCOM Geni SE. > > Signed-off-by: Caleb Connolly > --- > Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring

Re: [PATCH V4 XRT Alveo 09/20] fpga: xrt: management physical function driver (root)

2021-04-09 Thread Max Zhen
Hi Tom, On 3/31/21 6:03 AM, Tom Rix wrote: On 3/23/21 10:29 PM, Lizhi Hou wrote: The PCIE device driver which attaches to management function on Alveo devices. It instantiates one or more group drivers which, in turn, instantiate platform drivers. The instantiation of group and platform driver

[PATCH 3/3] staging: iio: cdc: ad7746: use dt binding to set the excitation level

2021-04-09 Thread Lucas Stankus
Set device excitation level using properties from device tree binding instead of using platform_data. As this replaces the last instance where the platform_data struct was used, remove ad7746.h header file since it's no longer needed. Signed-off-by: Lucas Stankus --- drivers/staging/iio/cdc/ad77

Re: [PATCH V2 4/4] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml

2021-04-09 Thread Rob Herring
On Thu, Apr 08, 2021 at 05:01:09PM +0530, satya priya wrote: > Convert qcom pm8941 power key binding from .txt to .yaml format. > > Signed-off-by: satya priya > --- > Changes in V2: > - Fixed bot errors, took reference from input.yaml for "linux,code" > - Added one complete example for powerkey

[PATCH 1/3] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746

2021-04-09 Thread Lucas Stankus
Add device tree binding documentation for AD7746 cdc in YAML format. Signed-off-by: Lucas Stankus --- .../bindings/iio/cdc/adi,ad7746.yaml | 79 +++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml diff --git

[PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-09 Thread Lucas Stankus
Ditch platform_data fields in favor of device tree properties for configuring EXCA and EXCB output. This also removes the fields from the platform_data struct, since they're not used anymore. Signed-off-by: Lucas Stankus --- drivers/staging/iio/cdc/ad7746.c | 33 +---

Re: [PATCH v2] ima: Fix function name error in comment.

2021-04-09 Thread Mimi Zohar
On Tue, 2021-04-06 at 02:12 +, Jiele Zhao wrote: > The original function name was ima_path_check(). The policy parsing > still supports PATH_CHECK. Commit 9bbb6cad0173 ("ima: rename > ima_path_check to ima_file_check") renamed the function to > ima_file_check(), but missed modifying the func

[PATCH 0/3] staging: iio: cdc: ad7746: remove platform_data in favor of device tree bindings

2021-04-09 Thread Lucas Stankus
This patch series aims to replace the platform_struct for the ad7746 driver in favor of device tree bindings, creating the dt-bindings documentation in the process. Since the header file was only used to define the struct and the excitation level values, it was possible to remove the file entirely

Re: [PATCH v4 0/3] ima: kernel build support for loading the kernel module signing key

2021-04-09 Thread Mimi Zohar
On Fri, 2021-04-09 at 10:35 -0400, Nayna Jain wrote: > Kernel modules are currently only signed when CONFIG_MODULE_SIG is enabled. > The kernel module signing key is a self-signed CA only loaded onto the > .builtin_trusted_key keyring. On secure boot enabled systems with an arch > specific IMA pol

Re: [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded

2021-04-09 Thread Wei Xu
On Fri, Apr 9, 2021 at 8:50 AM Dave Hansen wrote: > I also considered passing NULL to mean "I don't care about > nr_succeeded". I mostly avoided it to reduce churn. But, looking at it > here, it does seem cleaner. > > Any objections to moving over to Oscar's suggestion? I like this approach (ma

Re: [PATCH V2 2/4] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 17:01:07 +0530, satya priya wrote: > From: David Collins > > Add power key and resin compatible strings for the PMK8350 PMIC. > These are needed to distinguish key PON_HLOS register differences > between PMK8350 and previous PMIC PON modules. > > Signed-off-by: David Collins

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-09 Thread Rob Herring
On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: > Add optional brcm,ccode-map property to support translation from ISO3166 > country code to brcmfmac firmware country code and revision. > > Signed-off-by: Shawn Guo > --- > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7

[PATCH v2 2/2] staging: media: zoran: remove and add comments; align code

2021-04-09 Thread Mitali Borkar
Removed comments from the same line and added them to new line above the blocks, aligned everything properly by using tabs to make code neater and improve readability. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36057.h | 293 ++ 1 file changed, 162 ins

[PATCH v2 1/2] media: zoran: add spaces around '<<'

2021-04-09 Thread Mitali Borkar
No changes required in this patch. In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding style Signed-off-by: Mitali Borkar --- Changes from v1:- No changes required in this patch. Below is the git diff of v1. drivers/staging/media/zoran/zr36057.h | 14

[PATCH v2 0/2] staging: media: zoran: aligned the code and block comment changes

2021-04-09 Thread Mitali Borkar
This patch fixes the cleanup style issues. Changes from v1:- In [PATCH v2 1/2]:- No changes made/required. In [PATCH v2 2/2]:- Aligned the code using tabs and spaces and readjusted comment line. Mitali Borkar (2): media: zoran: add spaces around '<<' staging: media: zoran: remove and add comment

Re: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 17:07:08 +0800 Joakim Zhang wrote: > This patch set adds new properties for of_get_mac_address from nvmem. Apart from addressing Rob's (and potentially other comments to come) please also make sure to rebase before posting. This series doesn't seem to apply to net-next.

Re: [PATCH 3/6] dt-bindings: usb: mtk-xhci: add wakeup interrupt

2021-04-09 Thread Rob Herring
On Thu, 08 Apr 2021 17:35:11 +0800, Chunfeng Yun wrote: > Add an interrupt which is EINT usually to support runtime PM, > meanwhile add "interrupt-names" property, for backward > compatibility, it's optional and used when wakeup interrupt > exists > > Signed-off-by: Chunfeng Yun > --- > .../devi

[PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Radu Pirea (NXP OSS)
Add driver for tja1103 driver and for future NXP C45 PHYs. Signed-off-by: Radu Pirea (NXP OSS) --- MAINTAINERS | 6 + drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/nxp-c45.c | 622 ++ 4 files changed, 635

Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio

2021-04-09 Thread Rob Herring
On Thu, Apr 08, 2021 at 09:52:17AM +0800, Steven Lee wrote: > AST2600-A2 EVB provides the reference design for enabling SD bus power > and toggling SD bus signal voltage by GPIO pins. > Add the definition and example for power-gpio and power-switch-gpio > properties. > > In the reference design, G

[GIT PULL] perf tools fixes for v5.12: 3rd batch

2021-04-09 Thread Arnaldo Carvalho de Melo
Hi Linus, Please consider pulling, Best regards, - Arnaldo Test results at the end of this message, as usual. The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread Peter Zijlstra
On Fri, Apr 09, 2021 at 09:48:33AM -0400, David Malcolm wrote: > You tried __pure on arch_static_branch; did you try it on > static_branch_unlikely? static_branch_unlikely() is a CPP macro that expands to a statement expression, or as with the later patch, a _Generic(). I'm not sure how to apply t

Re: [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition

2021-04-09 Thread Rob Herring
On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote: > To allow slow charger loops to comply to pSnkStby requirement, > this patch introduces slow-charger-loop which when set makes > the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY > (instead of 3A or the 1.5A durin

<    1   2   3   4   5   6   7   8   9   10   >