Hi Alexis,
On Mon, 09 Sep 2024 22:02:07 +0200
Alexis Lothoré (eBPF Foundation) wrote:
> test_xdp_features.sh is a shell script allowing to test that xdp features
> advertised by an interface are indeed delivered. The test works by starting
> two instance of the same program, both attaching speci
implemented with support for PAL and NTSC autodetection.
Signed-off-by: Maxime Chevallier
---
v1 -> v2: Set the media entity type to decoder, and implement the
s_std/g_std ops
V2 ->V3 : Fix coding-style issues, and remove the use of the bulk API
for regulators. Make the driver select the
Add prefix for Techwell, Inc.
Acked-by: Rob Herring
Signed-off-by: Maxime Chevallier
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings
he notable
addition of the querystd ops for standard detection.
Any feedback is appreciated,
Thanks,
Maxime
Maxime Chevallier (3):
dt-bindings: vendor-prefixes: Add techwell vendor prefix
media: dt-bindings: media: i2c: Add bindings for TW9900
media: i2c: Introduce a driver for the Techw
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Techwell TW9900 NTSC/PAL/SECAM video decoder
+
+maintainers:
+ - Maxime Chevallier
+
+description:
+ The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM
+ standards with auto-detection features.
Hi Hans, and thanks for the review.
On Thu, 4 Mar 2021 16:37:53 +0100
Hans Verkuil wrote:
>Hi Maxime,
>
>Some more code review comments:
>
>> +static int tw9900_set_fmt(struct v4l2_subdev *sd,
>> + struct v4l2_subdev_pad_config *cfg,
>> + struct v4l2_su
The Techwell video decoder supports PAL, NTSC and SECAM input formats,
and outputs a BT.656 signal.
This commit adds support for this device, with basic support for NTSC
and PAL, along with brightness and contrast controls.
Signed-off-by: Maxime Chevallier
---
v1 -> v2: Set the media ent
ong with a
binding example validation error.
Any feedback is appreciated,
Thanks,
Maxime
Maxime Chevallier (3):
dt-bindings: vendor-prefixes: Add techwell vendor prefix
media: dt-bindings: media: i2c: Add bindings for TW9900
media: i2c: Introduce a driver for the Techwell TW99
aml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Techwell TW9900 NTSC/PAL/SECAM video decoder
+
+maintainers:
+ - Maxime
Add prefix for Techwell, Inc.
Acked-by: Rob Herring
Signed-off-by: Maxime Chevallier
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings
Implement a basic MQPrio support, inserting rules in RX that translate
the TC to prio mapping into vlan prio to queues.
The TX logic stays the same as when we don't offload the qdisc.
Signed-off-by: Maxime Chevallier
---
V2 : Fixed the reverse xmas tree, as per Andrew's review.
left to be dealt with.
The second patch implements the MQPrio offloading for the receive path.
Changes in V2 :
- Add a Fixes tag for the first patch
- Fix some warnings and the xmas tree in the second patch
Thanks,
Maxime
Maxime Chevallier (2):
net: mvneta: Remove per-cpu queue mapping for A
the CPUs in
the system, both in the init path and in the cpu_hotplug path.
Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC")
Signed-off-by: Maxime Chevallier
---
V2: Added Fixes tag, as per Pali's review
drivers/net/ethernet/marvell/mvneta.c | 9 -
Hi Andrew,
On Sat, 13 Feb 2021 20:45:25 +0100
Andrew Lunn wrote:
>On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote:
>> +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp)
>> +{
>> +int i;
>> +u32 val = 0;
>
>Hi Maxime
>
arking
>this commit with Fixes line? E.g.:
>
>Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700
> SoC")
Yes you're correct, I'll add that to the V2 !
Thanks for the review,
Maxime
--
Maxime Chevallier, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
the CPUs in
the system, both in the init path and in the cpu_hotplug path.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvneta.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell
Implement a basic MQPrio support, inserting rules in RX that translate
the TC to prio mapping into vlan prio to queues.
The TX logic stays the same as when we don't offload the qdisc.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvneta.c | 65 +
ements the MQPrio offloading for the receive path.
Thanks !
Maxime
Maxime Chevallier (2):
net: mvneta: Remove per-cpu queue mapping for Armada 3700
net: mvneta: Implement mqprio support
drivers/net/ethernet/marvell/mvneta.c | 74 ++-
1 file changed, 73 insertions(+),
The PX30 has a camera interface, supporting CSI2 and BT656
modes. Add a DT description for this interface.
Signed-off-by: Maxime Chevallier
---
V3 : Renamed the controlled
V4: Fixed the clock names
v5: No change
arch/arm64/boot/dts/rockchip/px30.dtsi | 12
1 file changed, 12
ng" mode of the controller, which is a
double-buffering mechanism.
Signed-off-by: Maxime Chevallier
---
V3:
- renamed the driver
- Took Hans, Robin and Ezequiel's reviews into account
- Implemented the ouble-buffering mode
v4:
- Took Ezequiel's reviews into account
- Reworked
Add a documentation for the Rockchip Camera Interface controller
binding.
This controller can be found on platforms such as the PX30 or the
RK3288, the PX30 being the only platform supported so far.
Signed-off-by: Maxime Chevallier
---
v3: Renamed the controller to "vip"
v4: fixed t
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported)
Total for rk_vip device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
Once again, any review is welcome :)
Thanks a lot,
Maxime
Maxime Chevallier (3):
media: dt-bindings: media: Document Rockchip VIP bindings
Add prefix for Techwell, Inc.
Acked-by: Rob Herring
Signed-off-by: Maxime Chevallier
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings
The Techwell video decoder supports PAL, NTSC and SECAM input formats,
and outputs a BT.656 signal.
This commit adds support for this device, with basic support for NTSC
and PAL, along with brightness and contrast controls.
Signed-off-by: Maxime Chevallier
---
v1 -> v2: Set the media ent
OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Techwell TW9900 NTSC/PAL/SECAM video decoder
+
+maintainers:
+ - Maxime Chevallier
+
+description:
+ The tw9900 is a multi-standard video
fixes the
example binding.
Any feedback is appreciated,
Thanks,
Maxime
Maxime Chevallier (3):
dt-bindings: vendor-prefixes: Add techwell vendor prefix
media: dt-bindings: media: i2c: Add bindings for TW9900
media: i2c: Introduce a driver for the Techwell TW9900 decoder
.../devicetree/bind
ng" mode of the controller, which is a
double-buffering mechanism.
Signed-off-by: Maxime Chevallier
---
V3:
- renamed the driver
- Took Hans, Robin and Ezequiel's reviews into account
- Implemented the ouble-buffering mode
v4:
- Took Ezequiel's reviews into account
- Reworked
The PX30 has a camera interface, supporting CSI2 and BT656
modes. Add a DT description for this interface.
Signed-off-by: Maxime Chevallier
---
V3 : Renamed the controlled
V4: Fixed the clock names
arch/arm64/boot/dts/rockchip/px30.dtsi | 12
1 file changed, 12 insertions
Add a documentation for the Rockchip Camera Interface controller
binding.
This controller can be found on platforms such as the PX30 or the
RK3288, the PX30 being the only platform supported so far.
Signed-off-by: Maxime Chevallier
---
v3: Renmed the controller to "vip"
v4: fixed t
ased on a BSP driver, and I'm not fully familiar with the media
and V4L2 frameworks, so I guess some review is still needed.
On top of the previous series, this series addresses most of the reviews
by Ezequiel (Thanks again), and was tested on a PX30 chip.
Maxime
Maxime Chevallier (3):
media
gt;> + struct vb2_v4l2_buffer *vb_done)
>> +{
>> + vb2_set_plane_payload(&vb_done->vb2_buf, 0,
>> + stream->pixm.plane_fmt[0].sizeimage);
>> + vb_done->vb2_buf.timestamp = ktime_get_ns();
>
>
and changed the
media entity type from sensor to decoder following Hans' review.
Any feedback is appreciated,
Thanks,
Maxime
Maxime Chevallier (3):
dt-bindings: vendor-prefixes: Add techwell vendor prefix
media: dt-bindings: media: i2c: Add bindings for TW9900
media: i2c: Introduce a dri
The Techwell video decoder supports PAL, NTSC and SECAM input formats,
and outputs a BT.656 signal.
This commit adds support for this device, with basic support for NTSC
and PAL, along with brightness and contrast controls.
Signed-off-by: Maxime Chevallier
---
v1 -> v2: Set the media ent
id: http://devicetree.org/schemas/media/i2c/tw9900.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Techwell TW9900 NTSC/PAL/SECAM video decoder
+
+maintainers:
+ - Maxime Chevallier
+
+description:
+ The tw9900 is a multi-standard video decoder, supporting NTSC, PAL a
Add prefix for Techwell, Inc.
Acked-by: Rob Herring
Signed-off-by: Maxime Chevallier
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings
Hi Hans,
On Fri, 25 Sep 2020 14:52:25 +0200
Hans Verkuil wrote:
>Hi Maxime,
>
>Some comments below, this driver needs to be changed:
Thanks for the review !
>On 18/09/2020 16:24, Maxime Chevallier wrote:
>> The Techwell video decoder supports PAL, NTSC and SECAM input forma
Add a documentation for the Rockchip Camera Interface controller
binding.
This controller can be found on platforms such as the PX30 or the
RK3288, the PX30 being the only platform supported so far.
Signed-off-by: Maxime Chevallier
---
V3 :
- renamed the controller
.../bindings/media
ng" mode of the controller, which is a
double-buffering mechanism.
Signed-off-by: Maxime Chevallier
---
V3:
- renamed the driver
- Took Hans, Robin and Ezequiel's reviews into account
- Implemented the ouble-buffering mode
drivers/media/platform/Kconfig| 13 +
driv
The PX30 has a camera interface, supporting CSI2 and BT656
modes. Add a DT description for this interface.
Signed-off-by: Maxime Chevallier
---
V3: Renamed the driver
arch/arm64/boot/dts/rockchip/px30.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts
on a BSP driver, and I'm not fully familiar with the media
and V4L2 frameworks, so I guess some review is still needed.
This new series adds some stability fixes, and introduces the
double-buffering frame handling, giving better performances.
Thanks to everyone who reviewed the first t
Add prefix for Techwell, Inc.
Signed-off-by: Maxime Chevallier
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index
.
Signed-off-by: Maxime Chevallier
---
drivers/media/i2c/Kconfig | 9 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/tw9900.c | 671 +
3 files changed, 681 insertions(+)
create mode 100644 drivers/media/i2c/tw9900.c
diff --git a/drivers/media/i2c/Kconfig
w9900.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Techwell TW9900 NTSC/PAL/SECAM video decoder
+
+maintainers:
+ - Maxime Chevallier
+
+description:
+ The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM
+ standards with auto-detection fea
d contrast.
Thanks,
Maxime
Maxime Chevallier (3):
dt-bindings: vendor-prefixes: Add techwell vendor prefix
media: dt-bindings: media: i2c: Add bindings for TW9900
media: i2c: Introduce a driver for the Techwell TW9900 decoder
.../devicetree/bindings/media/i2c/tw9900.yaml | 59 ++
.../devicetre
i, 29 May 2020 at 10:05, Maxime Chevallier
> wrote:
>>
>> Introduce a driver for the camera interface on some Rockchip platforms.
>>
>> This controller supports CSI2, Parallel and BT656 interfaces, but for
>> now only the parallel interface could be tested, hence it&#x
tainer)
>
>A quick review below...
>
>On 03/04/2020 16:21, Maxime Chevallier wrote:
>> Introduce a driver for the camera interface on some Rockchip platforms.
>>
>> This controller supports CSI2, Parallel and BT656 interfaces, but for
>> now only the parallel interf
rs for more suitable ones
- Rebased on 5.7-rc7
Maxime Chevallier (3):
media: dt-bindings: media: Document Rockchip CIF bindings
media: rockchip: Introduce driver for Rockhip's camera interface
arm64: dts: rockchip: Add the camera interface description of the PX30
.../binding
The PX30 has a camera interface, supporting CSI2, BT656 and Parallel
modes. Add a DT description for this interface.
Signed-off-by: Maxime Chevallier
---
Changes since V1:
- Updated the clock and reset names
- Reordered the properties to have clocks and resets bundled together
arch/arm64
doesn't support cropping nor scaling, and is only
designed with one sensor being attached to it a any time.
Signed-off-by: Maxime Chevallier
---
Changes since V1 :
- Convert to the bulk APIs for clocks and resets
- remove useless references to priv data
- Move around some init functio
Add a documentation for the Rockchip Camera Interface controller
binding.
This controller can be found on platforms such as the PX30 or the
RK3288, the PX30 being the only platform supported so far.
Signed-off-by: Maxime Chevallier
---
Changes since V1
- Updated the clock and reset names
PPv2's XLGMAC can wait for 3 idle frames before triggering a link up
event. This can cause the link to be stuck low when there's traffic on
the interface, so disable this feature.
Fixes: 4bb043262878 ("net: mvpp2: phylink support")
Signed-off-by: Maxime Chevallier
---
_FLOW enum value and
the relevant classifier flow entries.
Thanks,
Maxime
Maxime Chevallier (2):
net: mvpp2: cls: Report an error for unsupported flow types
net: mvpp2: cls: Add support for ETHER_FLOW
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 6 ++
1 file changed, 6 inser
e corresponding entries in the classifier.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 6c088c903
Add a missing check to detect flow types that we don't support, so that
user can be informed of this.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls
Hi Christoph,
On Fri, 28 Jun 2019 08:59:46 -0700
Christoph Hellwig wrote:
>I'd much rather bite the bullet and make dev->dma_mask a scalar
>instead of a pointer. The pointer causes way to much boiler plate code,
>and the semantics are way to subtile.
I agree that this the real solution, it jus
T.
Suggested-by: Russell King
Signed-off-by: Maxime Chevallier
---
Hi everyone,
This patch, if suitable, would require a lot of testing to detect
drivers that rely on the streaming mask being the same as the coherent
mask.
Thanks,
Maxime
drivers/base/platform.c | 17 +
drive
vlan tag are also possible, but
they are specified using the special FLOW_EXT flag.
Signed-off-by: Maxime Chevallier
---
V2 : Add src and dst mac address parsing, as suggested by Pablo.
net/core/ethtool.c | 24
1 file changed, 24 insertions(+)
diff --git a/net/core
Hi Pablo,
On Wed, 26 Jun 2019 10:58:46 +0200
Pablo Neira Ayuso wrote:
>On Wed, Jun 26, 2019 at 10:44:03AM +0200, Maxime Chevallier wrote:
>> When parsing an ethtool_rx_flow_spec, users can specify an ethernet flow
>> which could contain matches based on the ethernet header, suc
FLOW_EXT and FLOW_MAC_EXT flags.
Signed-off-by: Maxime Chevallier
---
net/core/ethtool.c | 12
1 file changed, 12 insertions(+)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 4d1011b2e24f..01ceba556341 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -2883,6
Hello David,
On Thu, 20 Jun 2019 11:42:45 +0200
Maxime Chevallier wrote:
>The Header Parser allows identifying various fields in the packet
>headers, used for various kind of filtering and classification
>steps.
>
>This is a re-entrant process, where the offset in the packet hea
rvell Armada 375 network
unit")
Suggested-by: Alan Winkowski
Signed-off-by: Maxime Chevallier
---
V2 : Fix a typo in the commit log, reported by Sergei.
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mar
rvell Armada 375 network
unit")
Suggested-by: Alan Winkowski
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
b/drivers/net/ethernet/mar
Hello Nathan,
On Tue, 18 Jun 2019 09:09:10 -0700
Nathan Huckleberry wrote:
>There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
>Added a usage consistent with other fops to dump pmap
>to userspace.
Thanks for sending a fix. Besides the typo preventing your patch from
compiling, you should
e key.
This commit adds the vlan priotity as a compatible HEK field for
tagged traffic, meaning that we limit the possibility of extracting this
field only to the flows that contain tagged traffic.
Signed-off-by: Maxime Chevallier
---
.../net/ethernet/marvell/mvpp2/mvpp2_cls.c
bytes, such as the vlan tag which is 12 bits wide, or the priority which
is 3 bits wide.
Finally, patch 4 adds support for steering based on both vlan id and
priority, extracted from the outermost tag.
Maxime Chevallier (4):
net: mvpp2: cls: Use a dedicated lu_type for the RSS lookup
net: mvpp2
we want to insert it into. As an example,
classifying on VLAN tag can only be done on flows used for tagged
traffic.
This commit makes sure we don't insert rules in flows we aren't
compatible with.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 +
s.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 7cd9d6da0319..c4c467f5f
make sure the RSS match doesn't interfere with other
classification lookups, hence we use a dedicated lookup_type for it.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 ++--
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 5 +
2 files changed, 7
f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure
translator")
Reported-by: Michał Mirosław
Signed-off-by: Maxime Chevallier
---
V1 -> V2: Use "DEI" instead of the old name "CFI", as suggested by Toshiaki.
Perform endianness swap on the constan
_flow_spec to flow_rule structure
translator")
Reported-by: Michał Mirosław
Signed-off-by: Maxime Chevallier
---
Hi all,
Although this prevents information to be silently discarded when parsing
an ethtool_flow_spec, this information doesn't seem to be used by any
driver that converts
g for VLAN filtering")
Suggested-by: Yuri Chipchev
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
b/drivers/net/ethernet/marvell/mvpp2/m
cond patch makes so that we don't invalidate the wrong TCAM
entries when clearing the whole whitelist.
Maxime Chevallier (2):
net: mvpp2: prs: Fix parser range for VID filtering
net: mvpp2: prs: Use the correct helpers when removing all VID filters
.../net/ethernet/marvell/mvpp2/mvpp
the whitelist from all ports of the same PPv2
instance.
Fixes: 56beda3db602 ("net: mvpp2: Add hardware offloading for VLAN filtering")
Suggested-by: Yuri Chipchev
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 17 -
1 file
Hello David,
On Mon, 10 Jun 2019 09:23:00 -0700 (PDT)
David Miller wrote:
>Please start providing proper header postings with each and every patch
>series, explaining at a high level what the patch series is doing, how
>it is doing it, and why it is doing it that way.
Sure, I'll resend with a p
the whitelist from all ports of the same PPv2
instance.
Fixes: 56beda3db602 ("net: mvpp2: Add hardware offloading for VLAN filtering")
Suggested-by: Yuri Chipchev
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 17 -
1 file
g for VLAN filtering")
Suggested-by: Yuri Chipchev
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
b/drivers/net/ethernet/marvell/mvpp2/m
Besides the MIB counters, some other useful counters can be exposed to
the user. This commit adds support for :
- Per-port counters, that indicate FIFO drops and classifier drops,
- Per-rxq counters,
- Per-txq counters
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2
ch as when reconfiguring the interface mode with the PHY.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
b/drivers/net/ethernet/mar
Since we'll be adding support for other kind of internal counters, make
clear that the currently supported counters are the MIB counters.
Signed-off-by: Maxime Chevallier
---
.../net/ethernet/marvell/mvpp2/mvpp2_main.c | 21 ++-
1 file changed, 11 insertions(+), 10 dele
This series adds support for more ethtool counters in PPv2 :
- Per port counters, including one indicating the classifier drops
- Per RXQ and per TXQ counters
The first 2 patches perform some light rework and renaming, and the 3rd
adds the extra counters.
Maxime Chevallier (3):
net: mvpp2
Use a safe strscpy call to copy the ethtool stat strings into the
relevant buffers, instead of a memcpy that will be accessing
out-of-bound data.
Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mv
none of the users of ethtool_rx_flow_rule_create are using the
VLAN dissector, I don't think this qualifies as a regression.
Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure
translator")
Signed-off-by: Maxime Chevallier
---
This patch was pre
none of the users of ethtool_rx_flow_rule_create are using the
VLAN dissector, I don't think this qualifies as a regression.
Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure
translator")
Signed-off-by: Maxime Chevallier
---
V2: Added Fixes: tag, ta
On Wed, 29 May 2019 16:10:44 +0200
Maxime Chevallier wrote:
>When parsing an ethtool flow spec to build a flow_rule, the code checks
>if both the vlan etype and the vlan tci are specified by the user to add
>a FLOW_DISSECTOR_KEY_VLAN match.
>
>However, when the user only specifi
none of the users of ethtool_rx_flow_rule_create are using the
VLAN dissector, I don't think this qualifies as a regression.
Signed-off-by: Maxime Chevallier
---
net/core/ethtool.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/net
orted-by: Dan Carpenter
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index cd0daad011ce..bd19a910dc90 1
allocating too much room to store the
classification rules, the second one configuring the C2 engine as
suggested by the PPv2 functionnal specs.
Patches 3 to 5 introduce support for RSS contexts in mvpp2, allowing us
to steer traffic to dedicated RSS tables.
Thanks,
Maxime
Maxime Chevallier (5):
net
ed for RSS :
ethtool -N eth0 rx-flow-hash udp4 sdfn
When an RSS context is removed while there are active classification
rules using this context, these rules are removed.
Signed-off-by: Maxime Chevallier
---
.../net/ethernet/marvell/mvpp2/mvpp2_cls.c| 58 +--
1 file changed, 54
number of rules.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 2 +-
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 ++--
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net
The C2 TCAM has internal FIFOs that are only useful for the built-in
self-tests. Disable these FIFOS at init, as recommended in the
functionnal specs.
Suggested-by: Alan Winkowski
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 2 ++
drivers/net/ethernet
ctx 0 will be applied to all contexts.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h| 16 +-
.../net/ethernet/marvell/mvpp2/mvpp2_cls.c| 200 +++---
.../net/ethernet/marvell/mvpp2/mvpp2_cls.h| 15 +-
.../net/ethernet/marvell/mvpp2/mv
ethtool_rx_flow_rule_create takes into parameter the ethtool flow spec,
which doesn't contain the rss context id. We therefore need to extract
it ourself before parsing the ethtool rule.
The FLOW_RSS flag is only set in info->fs.flow_type, and not
info->flow_type.
Signed-off
ethtool ops get_rxfh_context and set_rxfh_context are used to create,
remove and access parameters associated to RSS contexts, in a similar
fashion to get_rxfh and set_rxfh.
Add a small descritopn of these callbacks in the struct ethtool_ops doc.
Signed-off-by: Maxime Chevallier
---
include
The flow_rule is only used when configuring the classification tables,
and should be free'd once we're done using it. The current code only
frees it in the error path.
Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support")
Signed-off-by: Maxime Chevalli
C/MC filtering, which are performed during the Parsing step, and
therefore take precedence over classification actions.
Signed-off-by: Maxime Chevallier
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h| 1 +
.../net/ethernet/marvell/mvpp2/mvpp2_cls.c| 29 +--
.../net/ethernet/
the "steer to rxq" action.
Signed-off-by: Maxime Chevallier
---
V2: - Re-arranged struct mvpp2_rfs_rule to minimize gaps on 64 bits systems,
as suggested by David.
- Fixed a smatch error indicating a possible out-of-bound array access
when accessing the internal lis
ports but the 9 and 10, and because modes supported by 6390
ports 9 and 10 are a subset of those supported on 6390X.
This was tested on 6390X using RXAUI mode.
Fixes: 364e9d7776a3 ("net: dsa: mv88e6xxx: Power on/off SERDES on cmode change")
Signed-off-by: Maxime Chevallier
---
drive
, since it doesn't have the
issue with the wrong abilities being reported.
Maxime Chevallier (2):
net: phy: marvell10g: Let genphy_c45_pma_read_abilities set Aneg bit
net: phy: marvell10g: Use the generic C45 helper to read the 2110
features
drivers/net/phy/marvell10g.c | 12 +-
The genphy_c45_pma_read_abilities helper now sets the Autoneg ability
in phydev->supported according to what the AN MMD reports.
We therefore don't need to manually do that in mv3310_get_features().
Signed-off-by: Maxime Chevallier
Suggested-by: Heiner Kallweit
---
drivers
Contrary to the 3310, the 2110 PHY correctly reports it's 2.5G/5G
abilities. We can therefore use the genphy_c45_pma_read_abilities helper
to build the list of features.
Signed-off-by: Maxime Chevallier
---
drivers/net/phy/marvell10g.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
1 - 100 of 208 matches
Mail list logo
