Re: [PATCH v3 0/3] gpio / pinctrl: cherryview: Fix missing events from EC

2016-10-10 Thread Phidias Chiang
Sorry for late response, the fix works like a charm :), thank you very much!

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-12 Thread Phidias Chiang
On Mon, Sep 12, 2016 at 12:04:01PM +0300, Mika Westerberg wrote: > > OK, I see what is going on now. When I changed handle_simple_irq to > handle_bad_irq, the IRQ core in __irq_do_set_handler() thinks the > handler is uninstalled and masks the line. > > If you change handle_bad_irq to handle_simp

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-11 Thread Phidias Chiang
On Sun, Sep 11, 2016 at 11:05:06AM +0300, Mika Westerberg wrote: > On Fri, Sep 09, 2016 at 11:58:32AM +0300, Mika Westerberg wrote: > > On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote: > > > > Only other place where we touch INTMASK register is > > chv_

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-09 Thread Phidias Chiang
On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote: > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > > Hmm, how can that happen? The patch removes clearing of INTMASK and only > other place where it is cleared temporarily is on resume. Can you ad

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-08 Thread Phidias Chiang
On Thu, Sep 08, 2016 at 01:24:02PM +0300, Mika Westerberg wrote: > On Thu, Sep 08, 2016 at 06:13:03PM +0800, Phidias Chiang wrote: > > On Thu, Aug 18, 2016 at 04:58:13PM +0300, Mika Westerberg wrote: > > > On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote: > >

Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe

2016-09-08 Thread Phidias Chiang
On Thu, Aug 18, 2016 at 04:58:13PM +0300, Mika Westerberg wrote: > On Thu, Aug 18, 2016 at 03:52:57PM +0200, Anisse Astier wrote: > > On Thu, Aug 18, 2016 at 2:13 PM, Mika Westerberg > > wrote: > > > On Wed, Aug 17, 2016 at 03:42:58PM +0200, Anisse Astier wrote: > > >> pin 25 (GPIO_SUS6) GPIO ctrl