[PATCH v5 18/18] linux/compiler.h: Remove redundant '#else'

2020-05-11 Thread Will Deacon
The '#else' clause after checking '#ifdef __KERNEL__' is empty in linux/compiler.h, so remove it. Signed-off-by: Will Deacon --- include/linux/compiler.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index d21a82

[PATCH v5 06/18] netfilter: Avoid assigning 'const' pointer to non-const pointer

2020-05-11 Thread Will Deacon
~~~ Follow the pattern used elsewhere in this file and add a cast to 'void *' to squash the warning. Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: "David S. Miller" Reviewed-by: Nick Desaulniers Signed-off-by: Will Deacon --- net/netfilter/core.c | 2 +- 1 f

[PATCH v5 01/18] sparc32: mm: Fix argument checking in __srmmu_get_nocache()

2020-05-11 Thread Will Deacon
The 'size' argument to __srmmu_get_nocache() is a number of bytes not a shift value, so fix up the sanity checking to treat it properly. Cc: "David S. Miller" Cc: Peter Zijlstra Signed-off-by: Will Deacon --- arch/sparc/mm/srmmu.c | 12 ++-- 1 file changed

[PATCH v5 07/18] net: tls: Avoid assigning 'const' pointer to non-const pointer

2020-05-11 Thread Will Deacon
p;saved_tcpv6_prot, prot); | |^ Drop the const qualifier from the local 'prot' variable, as it isn't needed. Cc: Boris Pismenny Cc: Aviad Yehezkel Cc: John Fastabend Cc: Daniel Borkmann Signed-off-by: Will Deacon --- net/tls/tls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v5 04/18] sparc32: mm: Reduce allocation size for PMD and PTE tables

2020-05-11 Thread Will Deacon
Now that the page table allocator can free page table allocations smaller than PAGE_SIZE, reduce the size of the PMD and PTE allocations to avoid needlessly wasting memory. Cc: "David S. Miller" Cc: Peter Zijlstra Signed-off-by: Will Deacon --- arch/sparc/include/asm/pgtsrmmu.h |

Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock

2020-05-11 Thread Will Deacon
On Mon, May 11, 2020 at 10:29:18AM -0700, Paul E. McKenney wrote: > On Mon, May 11, 2020 at 05:52:17PM +0100, Will Deacon wrote: > > On Mon, May 11, 2020 at 09:43:19AM -0700, Paul E. McKenney wrote: > > > On Mon, May 11, 2020 at 04:58:13PM +0100, Will Deacon wrote: > > >

Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock

2020-05-11 Thread Will Deacon
On Mon, May 11, 2020 at 12:44:26PM -0400, Qian Cai wrote: > > > > On May 11, 2020, at 11:58 AM, Will Deacon wrote: > > > > I'm fine with the data_race() placement, but I don't find the comment > > very helpful. We assign the result of a READ_ONCE() to

Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock

2020-05-11 Thread Will Deacon
On Mon, May 11, 2020 at 09:43:19AM -0700, Paul E. McKenney wrote: > On Mon, May 11, 2020 at 04:58:13PM +0100, Will Deacon wrote: > > On Sat, May 09, 2020 at 02:36:54PM -0700, Paul E. McKenney wrote: > > > diff --git a/kernel/locking/osq_lock.c b/kernel/locking/osq_lock.c &

Re: [PATCH v3 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-11 Thread Will Deacon
On Mon, 11 May 2020 18:31:55 +0530, Amit Daniel Kachhap wrote: > Recently arm64 linux kernel added support for Armv8.3-A Pointer > Authentication feature. If this feature is enabled in the kernel and the > hardware supports address authentication then the return addresses are > signed and stored in

Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock

2020-05-11 Thread Will Deacon
On Sat, May 09, 2020 at 02:36:54PM -0700, Paul E. McKenney wrote: > On Sat, May 09, 2020 at 12:53:38PM -0400, Qian Cai wrote: > > > > > > > On May 9, 2020, at 12:12 PM, Paul E. McKenney wrote: > > > > > > Ah, and I forgot to ask. Why "if (data_race(prev->next == node)" instead > > > of "if (da

Re: [PATCH v3 05/11] arm64: Add call_break_hook() to early_brk64() for early kgdb

2020-05-11 Thread Will Deacon
Hi Doug, On Tue, Apr 28, 2020 at 02:13:45PM -0700, Douglas Anderson wrote: > diff --git a/arch/arm64/kernel/debug-monitors.c > b/arch/arm64/kernel/debug-monitors.c > index 48222a4760c2..59c353dfc8e9 100644 > --- a/arch/arm64/kernel/debug-monitors.c > +++ b/arch/arm64/kernel/debug-monitors.c > @@

Re: [PATCH bpf-next v2 0/3] arm64 BPF JIT Optimizations

2020-05-11 Thread Will Deacon
On Fri, 8 May 2020 11:15:43 -0700, Luke Nelson wrote: > This patch series introduces several optimizations to the arm64 BPF JIT. > The optimizations make use of arm64 immediate instructions to avoid > loading BPF immediates to temporary registers, when possible. > > In the process, we discovered t

Re: [PATCH 1/2] mm: remove the specific name of arm64

2020-05-11 Thread Will Deacon
On Mon, May 11, 2020 at 02:28:19PM +0800, Zong Li wrote: > UXN is the name of arm64 page-table descriptors. > > Signed-off-by: Zong Li > CC: Will Deacon > --- > mm/Kconfig.debug | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig

Re: [PATCH 06/15] arm64: kvm: Move __smccc_workaround_1_smc to .rodata

2020-05-11 Thread Will Deacon
On Mon, May 11, 2020 at 11:04:59AM +0100, Marc Zyngier wrote: > On Thu, 30 Apr 2020 15:48:22 +0100 > David Brazdil wrote: > > > This snippet of assembly is used by cpu_errata.c to overwrite parts of KVM > > hyp > > vector. It is never directly executed, so move it from .text to .rodata. > > > >

Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec

2020-05-11 Thread Will Deacon
[+James and Catalin] On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > The second argument is the end "pointer", not the length. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/machine_kexec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64

Re: [RFC PATCH bpf-next 1/3] arm64: insn: Fix two bugs in encoding 32-bit logical immediates

2020-05-08 Thread Will Deacon
On Thu, May 07, 2020 at 02:48:07PM -0700, Luke Nelson wrote: > Thanks for the comments! Responses below: > > > It's a bit grotty spreading the checks out now. How about we tweak things > > slightly along the lines of: > > > > > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > >

Re: [PATCHv4 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 07:44:01PM +0530, Sibi Sankar wrote: > On 2020-05-07 18:32, Will Deacon wrote: > > On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote: > > > From: Sibi Sankar > > > > > > The Q6 modem sub-system has direct access to DD

Re: [PATCH] arm64: vdso: Add --eh-frame-hdr to ldflags

2020-05-07 Thread Will Deacon
On Thu, 7 May 2020 11:40:49 +0100, Vincenzo Frascino wrote: > LLVM's unwinder depends on the .eh_frame_hdr being present for > unwinding. However, when compiling Linux with GCC, the section > is not present in the vdso library object and when compiling > with Clang, it is present, but it has zero l

Re: [PATCHv4 0/6] iommu/arm-smmu: Allow client devices to select identity mapping

2020-05-07 Thread Will Deacon
On Tue, 21 Apr 2020 00:03:48 +0530, Sai Prakash Ranjan wrote: > This series allows DRM, Modem devices to set a default > identity mapping in qcom smmu implementation. > > Patch 1 is cleanup to support other SoCs to call into > QCOM specific implementation. > Patch 2 sets the default identity doma

Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative

2020-05-07 Thread Will Deacon
On Thu, 23 Apr 2020 15:25:31 +0530, Sai Prakash Ranjan wrote: > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with

Re: [PATCH] arm64: stacktrace: Factor out some common code info on_stack()

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 05:28:19PM +0800, Yunfeng Ye wrote: > diff --git a/arch/arm64/include/asm/stacktrace.h > b/arch/arm64/include/asm/stacktrace.h > index fdb913cc0bcb..b92bef2fb6cd 100644 > --- a/arch/arm64/include/asm/stacktrace.h > +++ b/arch/arm64/include/asm/stacktrace.h > @@ -69,27 +69,4

Re: [PATCHv4 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-07 Thread Will Deacon
On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote: > From: Sibi Sankar > > The Q6 modem sub-system has direct access to DDR through memnoc. > Also SMMU is not expected to provide access control/translation > for these SIDs (sandboxing of the modem is achieved through XPUs > engag

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > Add stall implementation hook to enable stalling > > > faults on QCOM platforms which supports it without > > > causing any kind

Re: [PATCHv4 0/6] iommu/arm-smmu: Allow client devices to select identity mapping

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 03:58:06PM +0530, Sai Prakash Ranjan wrote: > Hi Will, Joerg > > On 2020-04-21 00:03, Sai Prakash Ranjan wrote: > > This series allows DRM, Modem devices to set a default > > identity mapping in qcom smmu implementation. > > > > Patch 1 is cleanup to support other SoCs to

Re: [PATCH] kgdb: Fix spurious true from in_dbg_master()

2020-05-07 Thread Will Deacon
s also allows us to replace raw_smp_processor_id() > with smp_processor_id() since the short circuit logic will prevent > warnings from PREEMPT_DEBUG. > > Fixes: dcc7871128e9 ("kgdb: core changes to support kdb") > Suggested-by: Will Deacon > Signed-off-by: Daniel Thompson &g

Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 10:15:59AM +1000, Gavin Shan wrote: > On 5/6/20 5:19 PM, Will Deacon wrote: > > On Wed, May 06, 2020 at 12:36:43PM +0530, Anshuman Khandual wrote: > > > > > > > > > On 05/06/2020 12:16 PM, Gavin Shan wrote: > > > &g

Re: [RFC PATCH bpf-next 1/3] arm64: insn: Fix two bugs in encoding 32-bit logical immediates

2020-05-07 Thread Will Deacon
Hi Luke, Thanks for the patches. On Wed, May 06, 2020 at 06:05:01PM -0700, Luke Nelson wrote: > This patch fixes two issues present in the current function for encoding > arm64 logical immediates when using the 32-bit variants of instructions. > > First, the code does not correctly reject an all

Re: Please can I have a stable KCSAN branch for 5.8?

2020-05-06 Thread Will Deacon
Hi Paul, Cheers for the quick reply! On Wed, May 06, 2020 at 07:36:16AM -0700, Paul E. McKenney wrote: > On Wed, May 06, 2020 at 02:28:17PM +0100, Will Deacon wrote: > > I'm looking to rebase my READ_ONCE() series [1] on top of the KCSAN patches > > so that we can get them

Re: [patch V4 part 1 06/36] compiler: Simple READ/WRITE_ONCE() implementations

2020-05-06 Thread Will Deacon
On Tue, May 05, 2020 at 03:16:08PM +0200, Thomas Gleixner wrote: > READ/WRITE_ONCE_NOCHECK() is required for atomics in code which cannot be > instrumented like the x86 int3 text poke code. As READ/WRITE_ONCE() is > undergoing a rewrite, provide __{READ,WRITE}_ONCE_SCALAR(). > > Signed-off-by: Pet

Please can I have a stable KCSAN branch for 5.8?

2020-05-06 Thread Will Deacon
Hi TIP folks, I'm looking to rebase my READ_ONCE() series [1] on top of the KCSAN patches so that we can get them in for 5.8. However, tip/locking/kcsan seems to be missing some bits: * An update to checkpatch.pl to warn about missing comments for data_race(): https://lore.kernel.org/r

Re: Reqeust export symbol for API in arch/arm64/*

2020-05-06 Thread Will Deacon
On Wed, May 06, 2020 at 09:46:45PM +0900, �ֵ���/DONGHYEOK CHOE wrote: > I am software engineer in charge of BSP (Samsung SOC vendor). > > Recently, Google introduced GKI from Android R version. > We cannot use mainline API without 'export symbol' by the GKI policy. > But we want to make an arm64 s

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-06 Thread Will Deacon
On Wed, May 06, 2020 at 05:32:56PM +0530, Amit Kachhap wrote: > On 5/4/20 10:47 PM, Will Deacon wrote: > > On Mon, Apr 27, 2020 at 11:55:01AM +0530, Amit Daniel Kachhap wrote: > > > diff --git a/arch/arm64/include/asm/compiler.h > > > b/arch/arm64/include/asm/com

Re: [PATCH V2 1/3] arm64/mm: Drop __HAVE_ARCH_HUGE_PTEP_GET

2020-05-06 Thread Will Deacon
ped along > with it's __HAVE_ARCH_HUGE_PTEP_GET subscription. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Andrew Morton > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux...@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual >

Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-06 Thread Will Deacon
On Wed, May 06, 2020 at 12:36:43PM +0530, Anshuman Khandual wrote: > > > On 05/06/2020 12:16 PM, Gavin Shan wrote: > > The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), > > avoids to register duplicated huge page states for same size. However, > > the same logic has been include

Re: [PATCH] firmware: arm_scmi: fix psci dependency

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 04:04:21PM +0100, Sudeep Holla wrote: > On Tue, May 05, 2020 at 04:08:08PM +0200, Arnd Bergmann wrote: > > When CONFIG_ARM_PSCI_FW is disabled but CONFIG_HAVE_ARM_SMCCC is enabled, > > arm-scmi runs into a link failure: > > > > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi

Re: [PATCH v2 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-05 Thread Will Deacon
On Mon, May 04, 2020 at 10:29:05AM +0100, Sudeep Holla wrote: > diff --git a/drivers/firmware/psci/soc_id.c b/drivers/firmware/psci/soc_id.c > new file mode 100644 > index ..b45f2d78e12e > --- /dev/null > +++ b/drivers/firmware/psci/soc_id.c > @@ -0,0 +1,165 @@ > +// SPDX-License-Identi

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-05 Thread Will Deacon
On Mon, 4 May 2020 18:05:18 +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is flawed:

Re: [PATCH] kcsan: fix section mismatch for __write_once_size/blacklisted_initcalls

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 05:05:36PM +0200, Arnd Bergmann wrote: > On Tue, May 5, 2020 at 4:17 PM 'Marco Elver' via Clang Built Linux > wrote: > > On Tue, 5 May 2020 at 16:11, Arnd Bergmann wrote: > > > So far, my randconfig checks found two such instances, one for read_once > > > and one for write

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 03:15:29PM +0100, Daniel Thompson wrote: > On Mon, May 04, 2020 at 09:48:04PM +0100, Will Deacon wrote: > > On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > > > diff --git a/arch/arm64/include/asm/cacheflush.h > > > b/arch/arm

Re: [PATCH V3 04/16] arm64/cpufeature: Introduce ID_PFR2 CPU register

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 12:50:54PM +0100, Mark Rutland wrote: > On Tue, May 05, 2020 at 12:27:19PM +0100, Will Deacon wrote: > > On Tue, May 05, 2020 at 12:16:07PM +0100, Mark Rutland wrote: > > > On Tue, May 05, 2020 at 12:12:41PM +0100, Will Deacon wrote: > > > >

Re: [PATCH V3 04/16] arm64/cpufeature: Introduce ID_PFR2 CPU register

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 12:16:07PM +0100, Mark Rutland wrote: > On Tue, May 05, 2020 at 12:12:41PM +0100, Will Deacon wrote: > > On Sat, May 02, 2020 at 07:03:53PM +0530, Anshuman Khandual wrote: > > > This adds basic building blocks required for ID_PFR2 CPU register wh

Re: [PATCH V3 08/16] arm64/cpufeature: Add remaining feature bits in ID_MMFR4 register

2020-05-05 Thread Will Deacon
On Sat, May 02, 2020 at 07:03:57PM +0530, Anshuman Khandual wrote: > Enable all remaining feature bits like EVT, CCIDX, LSM, HPDS, CnP, XNX, > SpecSEI in ID_MMFR4 register per ARM DDI 0487F.a. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Suzuki K Pou

Re: [PATCH V3 04/16] arm64/cpufeature: Introduce ID_PFR2 CPU register

2020-05-05 Thread Will Deacon
> per ARM DDI 0487F.a specification. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: James Morse > Cc: Suzuki K Poulose > Cc: kvm...@lists.cs.columbia.edu > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.

Re: [PATCH V3 03/16] arm64/cpufeature: Make doublelock a signed feature in ID_AA64DFR0

2020-05-05 Thread Will Deacon
e this must > be a signed feature instead. Also change FTR_EXACT to FTR_LOWER_SAFE. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Suzuki K Poulose > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > > Suggested-by: Suzu

Re: [PATCH 1/2] arm64: Sort vendor-specific errata

2020-05-05 Thread Will Deacon
On Thu, Apr 16, 2020 at 03:06:55PM +0200, Arnd Bergmann wrote: > On Thu, Apr 16, 2020 at 1:57 PM Geert Uytterhoeven > wrote: > > > > Sort configuration options for vendor-specific errata by vendor, to > > increase uniformity. > > Move ARM64_WORKAROUND_REPEAT_TLBI up, as it is also selected by > >

Re: [PATCH V3 02/16] arm64/cpufeature: Drop TraceFilt feature exposure from ID_DFR0 register

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 12:20:41PM +0530, Anshuman Khandual wrote: > On 05/05/2020 01:54 AM, Will Deacon wrote: > > On Sat, May 02, 2020 at 07:03:51PM +0530, Anshuman Khandual wrote: > >> ID_DFR0 based TraceFilt feature should not be exposed to guests. Hence lets > >

Re: [PATCH] firmware: arm_sdei: Drop check for /firmware/ node and always register driver

2020-05-04 Thread Will Deacon
On Wed, 22 Apr 2020 13:28:23 +0100, Sudeep Holla wrote: > As with most of the drivers, let us register this driver unconditionally > by dropping the checks for presence of firmware nodes(DT) or entries(ACPI). > > Further, as mentioned in the commit acafce48b07b ("firmware: arm_sdei: > Fix DT platf

Re: [PATCH] arm64/cpuinfo: Move device_initcall() near cpuinfo_regs_init()

2020-05-04 Thread Will Deacon
. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Brown > Cc: Mark Rutland > Cc: Suzuki Poulose > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Applied to arm64 (for-next/misc), thanks! [1/1] arm64/cpuinfo: Move device_initcall() nea

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-04 Thread Will Deacon
On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is

Re: [PATCH V3 06/16] arm64/cpufeature: Introduce ID_MMFR5 CPU register

2020-05-04 Thread Will Deacon
I 0487F.a > specification. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: James Morse > Cc: Suzuki K Poulose > Cc: kvm...@lists.cs.columbia.edu > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org >

Re: [PATCH V3 02/16] arm64/cpufeature: Drop TraceFilt feature exposure from ID_DFR0 register

2020-05-04 Thread Will Deacon
On Sat, May 02, 2020 at 07:03:51PM +0530, Anshuman Khandual wrote: > ID_DFR0 based TraceFilt feature should not be exposed to guests. Hence lets > drop it. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: James Morse > Cc: Su

Re: [PATCH v2 2/2] Documentation/vmcoreinfo: Add documentation for 'KERNELPACMASK'

2020-05-04 Thread Will Deacon
> Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Dave Young > Cc: Baoquan He > Signed-off-by: Amit Daniel Kachhap > --- > Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Doc

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-04 Thread Will Deacon
stacktrace purpose as well as to resolve the symbol name. > > This patch is similar to commit ec6e822d1a22d0eef ("arm64: expose user PAC > bit positions via ptrace") which exposes pac mask information via ptrace > interfaces. > > Cc: Catalin Marinas > Cc: Wil

Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Will Deacon
On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > On Fri, Apr 24, 2020 at 12:21:14PM +0100, Will Deacon wrote: > > Also, since you mentioned the lack of redzoning, isn't it a bit dodgy > > allocating blindly out of the kmem_cache? It means we don't have a re

Re: [PATCH v2 1/2] init/kconfig: Add LD_VERSION Kconfig

2020-05-04 Thread Will Deacon
On Mon, May 04, 2020 at 09:11:12AM +0200, Geert Uytterhoeven wrote: > On Mon, Mar 30, 2020 at 1:42 PM Amit Daniel Kachhap > wrote: > > This option can be used in Kconfig files to compare the ld version > > and enable/disable incompatible config options if required. > > > > This option is used in t

Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer

2020-05-01 Thread Will Deacon
On Sat, May 02, 2020 at 12:10:50AM +0800, Leo Yan wrote: > On Fri, May 01, 2020 at 04:26:09PM +0100, Will Deacon wrote: > > [...] > > > > > > Let me try and understand your particular problem better. > > > > > > > > I think the lo

Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer

2020-05-01 Thread Will Deacon
On Fri, May 01, 2020 at 11:14:48PM +0800, Leo Yan wrote: > On Thu, Apr 30, 2020 at 05:18:15PM +0100, Will Deacon wrote: > > On Thu, Apr 30, 2020 at 06:04:36PM +0200, Peter Zijlstra wrote: > > > On Thu, Apr 30, 2020 at 04:29:23PM +0100, Marc Zyngier wrote: > > > > >

Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

2020-05-01 Thread Will Deacon
On Thu, Apr 30, 2020 at 02:23:32PM +0200, Joerg Roedel wrote: > On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote: > > Thanks, not sure how I managed to screw this up in the original patch! > > > > Acked-by: Will Deacon > > > > Joerg -- can you pick t

Re: [PATCH v10 00/13] arm64: Branch Target Identification support

2020-04-30 Thread Will Deacon
On Tue, Apr 28, 2020 at 05:01:43PM +0100, Will Deacon wrote: > On Tue, Apr 28, 2020 at 04:58:12PM +0100, Mark Brown wrote: > > On Tue, Apr 28, 2020 at 04:18:16PM +0100, Will Deacon wrote: > > > On Tue, Apr 28, 2020 at 04:12:05PM +0100, Mark Brown wrote: > > > > >

Re: [PATCH] perf:Avoid duplicate printouts

2020-04-30 Thread Will Deacon
On Thu, 2 Apr 2020 19:59:40 +0800, Tang Bin wrote: > Because platform_get_irq() has dev_err(),so this place > should be removed. Applied to arm64 (for-next/perf), thanks! [1/1] drivers/perf: arm_dsu_pmu: Avoid duplicate printouts https://git.kernel.org/arm64/c/5810f00ade49 Cheers, -- Will

Re: [PATCH] perf:arm_spe:Avoid duplicate printouts

2020-04-30 Thread Will Deacon
On Thu, 2 Apr 2020 20:03:30 +0800, Tang Bin wrote: > Because platform_get_irq() has dev_err(),so this place > should be removed. Applied to arm64 (for-next/perf), thanks! [1/1] drivers/perf: arm_spe_pmu: Avoid duplicate printouts https://git.kernel.org/arm64/c/1f0d97bb7082 Cheers, -- Will

Re: [PATCH v2 0/2] Make memory size reporting in kexec_file_load() accurate

2020-04-30 Thread Will Deacon
On Thu, 30 Apr 2020 18:31:40 +0200, =?UTF-8?q?=C5=81ukasz=20Stelmach?= wrote: > Calling kexec_add_buffer() page-alligns the value of kbuf.memsz, so it > is not same as the requested value. Hence both bufsz and memsz should > after kexec_add_buffer() is called should be be reported separately. > >

Re: [PATCH v2] arm: mm: use __pfn_to_section() to get mem_section

2020-04-30 Thread Will Deacon
On Fri, 1 May 2020 06:18:58 +1400, Guixiong Wei wrote: > __pfn_to_section() helper which already wraps around > __nr_to_section(pfn_to_section_nr(pfn)), should be used > directly instead. Applied to arm64 (for-next/misc), thanks! [1/1] arm: mm: use __pfn_to_section() to get mem_section http

Re: [PATCH V2 00/16] arm64/cpufeature: Introduce ID_PFR2, ID_DFR1, ID_MMFR5 and other changes

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 08:29:44AM +0530, Anshuman Khandual wrote: > On 04/30/2020 02:56 AM, Will Deacon wrote: > > On Wed, Apr 29, 2020 at 03:07:15PM +0530, Anshuman Khandual wrote: > >> On 04/14/2020 03:18 PM, Anshuman Khandual wrote: > >>> Changes in V2: > &

Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 06:27:50PM +0200, Peter Zijlstra wrote: > On Thu, Apr 30, 2020 at 03:58:24PM +0100, Will Deacon wrote: > > On Fri, Mar 20, 2020 at 05:35:45PM +0800, Leo Yan wrote: > > > + /* > > > + * Since arch timer is enabled ealier than sched clock regist

Re: [PATCH] x86/asm: Provide a Kconfig symbol for disabling old assembly annotations

2020-04-30 Thread Will Deacon
On Thu, Apr 16, 2020 at 07:24:02PM +0100, Mark Brown wrote: > As x86 was converted to use the modern SYM_ annotations for assembly ifdefs > were added to remove the generic definitions of the old style annotations > on x86. Rather than collect a list of architectures in the ifdefs as more > archite

Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 06:04:36PM +0200, Peter Zijlstra wrote: > On Thu, Apr 30, 2020 at 04:29:23PM +0100, Marc Zyngier wrote: > > > I wonder if we could/should make __sched_clock_offset available even when > > CONFIG_HAVE_UNSTABLE_SCHED_CLOCK isn't defined. It feels like it would > > help with t

Re: [PATCH] arm64: perf_event: Fix time_offset for arch timer

2020-04-30 Thread Will Deacon
Hi Leo, [+Maz and tglx in case I'm barking up the wrong tree] On Fri, Mar 20, 2020 at 05:35:45PM +0800, Leo Yan wrote: > Between the system powering on and kernel's sched clock registration, > the arch timer usually has been enabled at the early time and its > counter is incremented during the pe

Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

2020-04-30 Thread Will Deacon
rt should > also be _GPL like the others. > > Cc: Will Deacon > Cc: Joerg Roedel > Cc: John Garry > Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit > modular drivers") > Signed-off-by: Greg Kroah-Hartman > --- > driver

Re: [PATCH] arm64: kexec_file: print appropriate variable

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 12:50:34PM +0200, Łukasz Stelmach wrote: > Fixes: 4312057681929 ("arm64: kexec_file: load initrd and device-tree") > Signed-off-by: Łukasz Stelmach -ENOCOMMITMSG > --- > arch/arm64/kernel/machine_kexec_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [RFC/PATCH 1/1] virtio: Introduce MMIO ops

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 04:04:46PM +0530, Srivatsa Vaddagiri wrote: > * Will Deacon [2020-04-30 11:14:32]: > > > > +#ifdef CONFIG_VIRTIO_MMIO_OPS > > > > > > +static struct virtio_mmio_ops *mmio_ops; > > > + > > > +#define virtio_readb(a

Re: [RFC/PATCH 0/1] virtio_mmio: hypervisor specific interfaces for MMIO

2020-04-30 Thread Will Deacon
Hi Vatsa, On Thu, Apr 30, 2020 at 03:59:39PM +0530, Srivatsa Vaddagiri wrote: > * Will Deacon [2020-04-30 11:08:22]: > > > > This patch is meant to seek comments. If its considered to be in right > > > direction, will work on making it more complete and send the next

Re: [RFC/PATCH 1/1] virtio: Introduce MMIO ops

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 03:32:56PM +0530, Srivatsa Vaddagiri wrote: > Some hypervisors may not support MMIO transport i.e trap config > space access and have it be handled by backend driver. They may > allow other ways to interact with backend such as message-queue > or doorbell API. This patch all

Re: [RFC/PATCH 0/1] virtio_mmio: hypervisor specific interfaces for MMIO

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 03:32:55PM +0530, Srivatsa Vaddagiri wrote: > The Type-1 hypervisor we are dealing with does not allow for MMIO transport. > [1] summarizes some of the problems we have in making virtio work on such > hypervisors. This patch proposes a solution for transport problem viz how

Re: [PATCH] arm64: kvm: fix gcc-10 shift warning

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 07:39:10PM +1000, Stephen Rothwell wrote: > On Thu, 30 Apr 2020 09:29:28 +0100 Will Deacon wrote: > > On Thu, Apr 30, 2020 at 09:02:51AM +0100, Marc Zyngier wrote: > > > On Wed, 29 Apr 2020 20:56:20 +0200 > > > Arnd Bergmann wrote: > >

Re: [PATCH] arm64: kvm: fix gcc-10 shift warning

2020-04-30 Thread Will Deacon
On Thu, Apr 30, 2020 at 09:02:51AM +0100, Marc Zyngier wrote: > On Wed, 29 Apr 2020 20:56:20 +0200 > Arnd Bergmann wrote: > > > gcc-10 warns that the 32-bit zero cannot be shifted more than > > 32 bits to the right: > > > > arch/arm64/kvm/../../../virt/kvm/arm/mmu.c: In function > > 'clear_hyp_

Re: [PATCH V2 00/16] arm64/cpufeature: Introduce ID_PFR2, ID_DFR1, ID_MMFR5 and other changes

2020-04-29 Thread Will Deacon
w > > if anything needs to change. Thank you. > > > > [1] https://patchwork.kernel.org/patch/11287805/ > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Mark Rutland > > Cc: Marc Zyngier > > Cc: James Morse > > Cc: Suzuki

Re: [PATCH] arm64: kvm: fix gcc-10 shift warning

2020-04-29 Thread Will Deacon
/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -507,7 +507,7 @@ static void clear_hyp_pgd_entry(pgd_t *pgd) > > static void clear_hyp_p4d_entry(p4d_t *p4d) > { > - pud_t *pud_table __maybe_unused = pud_offset(p4d, 0); > + pud_t *pud_table __maybe_unused = pud_offset(p4d, 0UL); > VM_BUG_ON(p4d_huge(*p4d)); > p4d_clear(p4d); > pud_free(NULL, pud_table); > -- > 2.26.0 Acked-by: Will Deacon Will

Re: [PATCH v10 00/13] arm64: Branch Target Identification support

2020-04-28 Thread Will Deacon
On Tue, Apr 28, 2020 at 04:58:12PM +0100, Mark Brown wrote: > On Tue, Apr 28, 2020 at 04:18:16PM +0100, Will Deacon wrote: > > On Tue, Apr 28, 2020 at 04:12:05PM +0100, Mark Brown wrote: > > > > It's probably easier for me if you just use the existing branch, I've &

Re: [PATCH v10 00/13] arm64: Branch Target Identification support

2020-04-28 Thread Will Deacon
On Tue, Apr 28, 2020 at 04:12:05PM +0100, Mark Brown wrote: > On Tue, Apr 28, 2020 at 02:28:05PM +0100, Will Deacon wrote: > > > I'm happy either way, but it would be nice to base other BTI patches on > > top of this branch. Mark -- is it easier for you to refresh the seri

Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK

2020-04-28 Thread Will Deacon
On Wed, 15 Apr 2020 18:57:46 +0800, Zenghui Yu wrote: > The only user of PTE_S2_MEMATTR_MASK macro had been removed since > commit a501e32430d4 ("arm64: Clean up the default pgprot setting"). > It has been about six years and no one has used it again. > > Let's drop it. Applied to arm64 (for-next

Re: [PATCH] arm64: entry: remove unneeded semicolon in el1_sync_handler()

2020-04-28 Thread Will Deacon
On Sat, 18 Apr 2020 16:19:09 +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > arch/arm64/kernel/entry-common.c:97:2-3: Unneeded semicolon Applied to arm64 (for-next/misc), thanks! [1/1] arm64: entry: remove unneeded semicolon in el1_sync_handler() https://git.kernel.org/

Re: [PATCH -next] arm64: smp: Make cpus_stuck_in_kernel static

2020-04-28 Thread Will Deacon
On Thu, 23 Apr 2020 14:33:26 +0800, Zou Wei wrote: > Fix the following sparse warning: > > arch/arm64/kernel/smp.c:68:5: warning: symbol 'cpus_stuck_in_kernel' > was not declared. Should it be static? Applied to arm64 (for-next/misc), thanks! [1/1] arm64: smp: Make cpus_stuck_in_kernel static

Re: [PATCH v2] arm64: kexec_file: Avoid temp buffer for RNG seed

2020-04-28 Thread Will Deacon
On Mon, 30 Mar 2020 17:38:01 +, George Spelvin wrote: > After using get_random_bytes(), you want to wipe the buffer > afterward so the seed remains secret. > > In this case, we can eliminate the temporary buffer entirely. > fdt_setprop_placeholder() returns a pointer to the property value > bu

Re: [PATCH v2] arm64/kernel: Fix range on invalidating dcache for boot page tables

2020-04-28 Thread Will Deacon
On Tue, 28 Apr 2020 09:57:00 +1000, Gavin Shan wrote: > Prior to commit 8eb7e28d4c642c31 ("arm64/mm: move runtime pgds to > rodata"), idmap_pgd_dir, tramp_pg_dir, reserved_ttbr0, swapper_pg_dir, > and init_pg_dir were contiguous at the end of the kernel image. The > maintenance at the end of __crea

Re: [PATCH v2] arm64/mm: Use phys_to_page() to access pgtable memory

2020-04-28 Thread Will Deacon
On Tue, 28 Apr 2020 09:46:55 +1000, Gavin Shan wrote: > The macros {pgd, pud, pmd}_page() retrieves the page struct of the > corresponding page frame, which is reserved as page table. There > is already a macro (phys_to_page), defined in memory.h as below, > to convert the physical address to the p

Re: [PATCH v10 00/13] arm64: Branch Target Identification support

2020-04-28 Thread Will Deacon
On Wed, Apr 22, 2020 at 05:29:54PM +0100, Catalin Marinas wrote: > On Wed, Apr 22, 2020 at 04:44:36PM +0100, Mark Brown wrote: > > On Mon, Mar 16, 2020 at 04:50:42PM +, Mark Brown wrote: > > > This patch series implements support for ARMv8.5-A Branch Target > > > Identification (BTI), which is

Re: arm64: imx8qm: tlb SW workaround for IMX8QM

2020-04-28 Thread Will Deacon
On Mon, Apr 27, 2020 at 03:03:28PM +0200, Oliver Graute wrote: > On 27/04/20, Oliver Graute wrote: > > Hello, > > > > is this nxp software workaround already proposed to linux community? can > > someone point me to the discussion if available. > > > > https://source.codeaurora.org/external/imx/li

Re: [PATCH] arm64/mm: Reject invalid NUMA option

2020-04-28 Thread Will Deacon
On Tue, Apr 28, 2020 at 02:35:20PM +1000, Gavin Shan wrote: > On 4/28/20 1:09 PM, Steven Rostedt wrote: > > [...] > > > > > Could this be a bug in the implementation of strncmp() in > > arch/arm64/lib/strncmp.S. As I don't know arm64 assembly, I have no idea > > what it is trying to do. > > > >

Re: [PATCH] perf tests: Fix a typo

2019-10-23 Thread Will Deacon
On Wed, Oct 23, 2019 at 04:33:24PM +0800, Leo Yan wrote: > Correct typo in comment: s/suck/stuck. > > Signed-off-by: Leo Yan > --- > tools/perf/tests/bp_signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c

Re: [tip: perf/core] perf tests: Disable bp_signal testing for arm64

2019-10-22 Thread Will Deacon
|instruction and > |trap to kernel > single_step_handler()| > `-> reinstall_suspended_bps() | >| __test_function() -> hit >

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

2019-10-22 Thread Will Deacon
> #define ARM_DEBUG_ARCH_V7_1 5 > #define ARM_DEBUG_ARCH_V86 > +#define ARM_DEBUG_ARCH_V8_1 7 > +#define ARM_DEBUG_ARCH_V8_2 8 Looks like you can also add: #define ARM_DEBUG_ARCH_V8_4 9 and treat that the same way. With that, and a fix to $SUBJECT: Acked-by: Will Deacon Pl

Re: [PATCH v2 04/12] arm64: docs: cpu-feature-registers: Document ID_AA64PFR1_EL1

2019-10-22 Thread Will Deacon
On Mon, Oct 21, 2019 at 08:18:18PM +0100, Mark Brown wrote: > On Fri, Oct 11, 2019 at 03:51:49PM +0100, Dave Martin wrote: > > On Fri, Oct 11, 2019 at 02:19:48PM +0100, Alex Bennée wrote: > > > > > - 4) ID_AA64ISAR1_EL1 - Instruction set attribute register 1 > > > > + 5) ID_AA64ISAR1_EL1 - Instr

Re: read_barrier_depends() usage in vhost.c

2019-10-18 Thread Will Deacon
On Thu, Oct 17, 2019 at 10:17:18AM +0800, Jason Wang wrote: > On 2019/10/17 上午7:33, Will Deacon wrote: > > In an attempt to remove the remaining traces of [smp_]read_barrier_depends() > > following my previous patches to strengthen READ_ONCE() for Alpha [1], I > > ended up t

Re: [GIT PULL] arm64: Fixes for -rc4

2019-10-18 Thread Will Deacon
On Thu, Oct 17, 2019 at 05:06:54PM -0700, Linus Torvalds wrote: > On Thu, Oct 17, 2019 at 4:43 PM Will Deacon wrote: > > > > Note that the workaround code ended up being based on -rc2, so I had a > > bit of a faff trying to generate the right diffstat for this pull request &

[GIT PULL] arm64: Fixes for -rc4

2019-10-17 Thread Will Deacon
: hibernate: check pgd table allocation Will Deacon (2): arm64: tags: Preserve tags for addresses translated via TTBR1 Merge branch 'errata/tx2-219' into for-next/fixes Yang Yingliang (1): arm64: sysreg: fix incorrect definition of SYS_PAR_EL1_F Documentation/arm64/silicon

Re: [PATCH 0/3] arm64: Fix support for systems without FP/SIMD

2019-10-16 Thread Will Deacon
On Thu, Oct 10, 2019 at 06:15:14PM +0100, Suzuki K Poulose wrote: > This series fixes the original support for systems without FP/SIMD. > We have three set of issues with the current code : > > 1) We detect the absence of FP/SIMD after the SMP cpus are brought > online (i.e, SYSTEM scope). This me

Re: [PATCH v10 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-10-16 Thread Will Deacon
Hey Palmer, On Wed, Oct 16, 2019 at 04:21:59PM -0700, Palmer Dabbelt wrote: > On Tue, 08 Oct 2019 05:39:44 PDT (-0700), w...@kernel.org wrote: > > On Tue, Oct 08, 2019 at 02:19:05AM +, Justin He (Arm Technology China) > > wrote: > > > > On Mon, Sep 30, 2019 at 09:57:40AM +0800, Jia He wrote:

Re: read_barrier_depends() usage in vhost.c

2019-10-16 Thread Will Deacon
[Bah: I typoed the LKML address, so I've fixed it for this one] On Thu, Oct 17, 2019 at 12:33:40AM +0100, Will Deacon wrote: > Hi all, > > In an attempt to remove the remaining traces of [smp_]read_barrier_depends() > following my previous patches to strengthen READ_ONCE()

[RESEND PATCH] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

2019-10-16 Thread Will Deacon
Cc: Mauro Carvalho Chehab Cc: Dmitry Vyukov Cc: Kostya Serebryany Cc: Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver") Reported-by: Andrey Konovalov Link: https://lore.kernel.org/linux-media/caaehk+z+si69jur+n-sjn9q4o+o5kfinmanqea-pjuta7eo...@mail.gmail.com/ Signed-

<    10   11   12   13   14   15   16   17   18   19   >