Re: [PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Paul Gortmaker
On Thu, Mar 14, 2013 at 6:34 PM, Frederic Weisbecker wrote: > 2013/3/14 Paul Gortmaker : >> On Thu, Mar 14, 2013 at 4:39 PM, Andrew Morton >> wrote: >>> On Thu, 14 Mar 2013 15:26:29 +0100 Frederic Weisbecker >>> wrote: >>> wake_up_klogd() is useless when CONFIG_PRINTK=n because neithe

Re: [PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Frederic Weisbecker
2013/3/14 Paul Gortmaker : > On Thu, Mar 14, 2013 at 4:39 PM, Andrew Morton > wrote: >> On Thu, 14 Mar 2013 15:26:29 +0100 Frederic Weisbecker >> wrote: >> >>> wake_up_klogd() is useless when CONFIG_PRINTK=n because >>> neither printk() nor printk_sched() are in use and there >>> are actually no

Re: [PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Paul Gortmaker
On Thu, Mar 14, 2013 at 4:39 PM, Andrew Morton wrote: > On Thu, 14 Mar 2013 15:26:29 +0100 Frederic Weisbecker > wrote: > >> wake_up_klogd() is useless when CONFIG_PRINTK=n because >> neither printk() nor printk_sched() are in use and there >> are actually no waiter on log_wait waitqueue. It sho

Re: [PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Frederic Weisbecker
2013/3/14 Andrew Morton : > On Thu, 14 Mar 2013 15:26:29 +0100 Frederic Weisbecker > wrote: > >> wake_up_klogd() is useless when CONFIG_PRINTK=n because >> neither printk() nor printk_sched() are in use and there >> are actually no waiter on log_wait waitqueue. It should >> be a stub in this case

Re: [PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Andrew Morton
On Thu, 14 Mar 2013 15:26:29 +0100 Frederic Weisbecker wrote: > wake_up_klogd() is useless when CONFIG_PRINTK=n because > neither printk() nor printk_sched() are in use and there > are actually no waiter on log_wait waitqueue. It should > be a stub in this case for users like bust_spinlocks(). >

[PATCH 2/2] printk: Provide a wake_up_klogd() off-case

2013-03-14 Thread Frederic Weisbecker
wake_up_klogd() is useless when CONFIG_PRINTK=n because neither printk() nor printk_sched() are in use and there are actually no waiter on log_wait waitqueue. It should be a stub in this case for users like bust_spinlocks(). Otherwise this results in this warning when CONFIG_PRINTK=n and CONFIG_IR