Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-12 Thread Ralph Sennhauser
Hi Linus, On Sun, 11 Jun 2017 23:48:34 +0200 Linus Walleij wrote: > On Fri, Jun 9, 2017 at 10:03 AM, Ralph Sennhauser > wrote: > > On Fri, 9 Jun 2017 09:37:55 +0200 > > Linus Walleij wrote: > > > >> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > >> wrote: > >> > >> > The blink counter A

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-11 Thread Linus Walleij
On Fri, Jun 9, 2017 at 10:03 AM, Ralph Sennhauser wrote: > On Fri, 9 Jun 2017 09:37:55 +0200 > Linus Walleij wrote: > >> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud >> wrote: >> >> > The blink counter A was always selected because 0 was forced in the >> > blink select counter register. >> > T

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 Thread Ralph Sennhauser
On Fri, 9 Jun 2017 09:37:55 +0200 Linus Walleij wrote: > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > wrote: > > > The blink counter A was always selected because 0 was forced in the > > blink select counter register. > > The variable 'set' was obviously there to be used as the register > >

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 Thread Richard Genoud
2017-06-09 9:37 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. >> The variable 'set' was obviously there to be used as the register value, >> selecting t

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 Thread Linus Walleij
On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud wrote: > The blink counter A was always selected because 0 was forced in the > blink select counter register. > The variable 'set' was obviously there to be used as the register value, > selecting the B counter when id==1 and A counter when id==0. >

[PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-01 Thread Richard Genoud
The blink counter A was always selected because 0 was forced in the blink select counter register. The variable 'set' was obviously there to be used as the register value, selecting the B counter when id==1 and A counter when id==0. Tested on clearfog-pro (Marvell 88F6828) Fixes: 757642f9a584 ("g