RE: [PATCH] perf arm pmu: fix build error on MUSL libc

2020-12-08 Thread Chanho Park
org; linux-arm- > ker...@lists.infradead.org; linux-kernel ; > Mike Leach ; Leo Yan ; John > Garry ; Peter Zijlstra ; Ingo > Molnar ; Arnaldo Carvalho de Melo ; > Mark Rutland ; Khem Raj > Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc > > On Mon, Dec 07, 2020 at 09:31:

Re: [PATCH] perf arm pmu: fix build error on MUSL libc

2020-12-07 Thread Jiri Olsa
On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote: > Hi Chanho, > > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park wrote: > > > > Hi Will, > > > > > Looks like other files just include this unconditionally, but have a > > > comment explaining why. See util/branch.h and util/event.h. Maybe

Re: [PATCH] perf arm pmu: fix build error on MUSL libc

2020-12-07 Thread Namhyung Kim
Hi Chanho, On Mon, Dec 7, 2020 at 8:58 PM Chanho Park wrote: > > Hi Will, > > > Looks like other files just include this unconditionally, but have a > > comment explaining why. See util/branch.h and util/event.h. Maybe we > > should do the same for util/pmu.h, which is already included here? > >

RE: [PATCH] perf arm pmu: fix build error on MUSL libc

2020-12-07 Thread Chanho Park
Hi Will, > Looks like other files just include this unconditionally, but have a > comment explaining why. See util/branch.h and util/event.h. Maybe we > should do the same for util/pmu.h, which is already included here? I found below files which perf includes . Instead of doing same for all, we'

Re: [PATCH] perf arm pmu: fix build error on MUSL libc

2020-12-07 Thread Will Deacon
On Sun, Dec 06, 2020 at 11:45:27PM +0900, Chanho Park wrote: > __always_inline can cause build error on musl libc. The fix patch has > submitted but not merged yet[1]. To build perf tool with musl libc, > inclusion is necessary and it should be included before > perf_event.h. > > from /usr/includ