Re: [PATCH] Fix comment for virtio-9p

2025-05-26 Thread Junichi Uekawa 
On Tue, 27 May 2025 15:11:36 +0900,
Michael Tokarev wrote:
> 
> 27.05.2025 07:11, [email protected] wrote:
> > From: Junichi Uekawa 
> > 
> > virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> > like an artifact of old copy-and-paste error.
> 
> > -#define VIRTIO_ID_9P   9 /* 9p virtio console */
> > +#define VIRTIO_ID_9P   9 /* virtio 9p */
> 
> While the old one was obviously wrong, I don't think the new
> wording makes much sense, since it merely repeats the name of
> the constant :)
> 
> How about "virtio 9p file sharing protocol" instead ? :)

Sounds better!

I also found another case, added to the follow-up.

[PATCH] Fix comment for virtio-9p

2025-05-26 Thread dancer 
From: Junichi Uekawa 

virtio-9p is not a console protocol, it's a file sharing protocol. Seems
like an artifact of old copy-and-paste error.

Fixes: 3ca4f5ca7305 ("virtio: add virtio IDs file")
Signed-off-by: Junichi Uekawa 
---
 include/uapi/linux/virtio_ids.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
index 7aa2eb766205..747e93a91920 100644
--- a/include/uapi/linux/virtio_ids.h
+++ b/include/uapi/linux/virtio_ids.h
@@ -37,7 +37,7 @@
 #define VIRTIO_ID_IOMEM6 /* virtio ioMemory */
 #define VIRTIO_ID_RPMSG7 /* virtio remote processor 
messaging */
 #define VIRTIO_ID_SCSI 8 /* virtio scsi */
-#define VIRTIO_ID_9P   9 /* 9p virtio console */
+#define VIRTIO_ID_9P   9 /* virtio 9p file sharing protocol */
 #define VIRTIO_ID_MAC80211_WLAN10 /* virtio WLAN MAC */
 #define VIRTIO_ID_RPROC_SERIAL 11 /* virtio remoteproc serial link */
 #define VIRTIO_ID_CAIF 12 /* Virtio caif */
@@ -79,6 +79,6 @@
 #define VIRTIO_TRANS_ID_CONSOLE0x1003 /* transitional virtio 
console */
 #define VIRTIO_TRANS_ID_SCSI   0x1004 /* transitional virtio SCSI */
 #define VIRTIO_TRANS_ID_RNG0x1005 /* transitional virtio rng */
-#define VIRTIO_TRANS_ID_9P 0x1009 /* transitional virtio 9p 
console */
+#define VIRTIO_TRANS_ID_9P 0x1009 /* transitional virtio 9p file 
sharing protocol */
 
 #endif /* _LINUX_VIRTIO_IDS_H */
-- 
2.39.5

Re: [PATCH] Fix comment for virtio-9p

2025-05-26 Thread Michael Tokarev 

27.05.2025 07:11, [email protected] wrote:

From: Junichi Uekawa 

virtio-9p is not a console protocol, it's a file sharing protocol. Seems
like an artifact of old copy-and-paste error.



-#define VIRTIO_ID_9P   9 /* 9p virtio console */
+#define VIRTIO_ID_9P   9 /* virtio 9p */


While the old one was obviously wrong, I don't think the new
wording makes much sense, since it merely repeats the name of
the constant :)

How about "virtio 9p file sharing protocol" instead ? :)

/mjt

[PATCH] Fix comment for virtio-9p

2025-05-26 Thread dancer 
From: Junichi Uekawa 

virtio-9p is not a console protocol, it's a file sharing protocol. Seems
like an artifact of old copy-and-paste error.

Fixes: 3ca4f5ca7305 ("virtio: add virtio IDs file")
Signed-off-by: Junichi Uekawa 
---
 include/uapi/linux/virtio_ids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
index 7aa2eb766205..deb9dfa52944 100644
--- a/include/uapi/linux/virtio_ids.h
+++ b/include/uapi/linux/virtio_ids.h
@@ -37,7 +37,7 @@
 #define VIRTIO_ID_IOMEM6 /* virtio ioMemory */
 #define VIRTIO_ID_RPMSG7 /* virtio remote processor 
messaging */
 #define VIRTIO_ID_SCSI 8 /* virtio scsi */
-#define VIRTIO_ID_9P   9 /* 9p virtio console */
+#define VIRTIO_ID_9P   9 /* virtio 9p */
 #define VIRTIO_ID_MAC80211_WLAN10 /* virtio WLAN MAC */
 #define VIRTIO_ID_RPROC_SERIAL 11 /* virtio remoteproc serial link */
 #define VIRTIO_ID_CAIF 12 /* Virtio caif */
-- 
2.49.0.1164.gab81da1b16-goog