Re: [PATCH] kunit: skb: use "gfp" variable instead of hardcoding GFP_KERNEL

[Kuan-Wei Chiu]

On Mon, Nov 04, 2024 at 08:16:30PM +0300, Dan Carpenter wrote:
> The intent here was clearly to use the gfp variable flags instead of
> hardcoding GFP_KERNEL.  All the callers pass GFP_KERNEL as the gfp
> flags so this doesn't affect runtime.
> 
> Fixes: b3231d353a51 ("kunit: add a convenience allocation wrapper for SKBs")
> Signed-off-by: Dan Carpenter 

The kernel doc comment for kunit_zalloc_skb() is missing a mention of
the gfp parameter. Additionally, the comment says "Allocate a new
struct sk_buff with GFP_KERNEL," which should replace GFP_KERNEL with
@gfp. It might be better to fix both issues in the comment together.
With the above corrections:

Reviewed-by: Kuan-Wei Chiu 

Regards,
Kuan-Wei
> ---
>  include/kunit/skbuff.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/kunit/skbuff.h b/include/kunit/skbuff.h
> index 44d12370939a..345e1e8f0312 100644
> --- a/include/kunit/skbuff.h
> +++ b/include/kunit/skbuff.h
> @@ -29,7 +29,7 @@ static void kunit_action_kfree_skb(void *p)
>  static inline struct sk_buff *kunit_zalloc_skb(struct kunit *test, int len,
>  gfp_t gfp)
>  {
> - struct sk_buff *res = alloc_skb(len, GFP_KERNEL);
> + struct sk_buff *res = alloc_skb(len, gfp);
>  
>   if (!res || skb_pad(res, len))
>   return NULL;
> -- 
> 2.45.2
> 
> 

Re: [PATCH] kunit: skb: use "gfp" variable instead of hardcoding GFP_KERNEL

[David Gow]

On Tue, 5 Nov 2024 at 01:16, Dan Carpenter  wrote:
>
> The intent here was clearly to use the gfp variable flags instead of
> hardcoding GFP_KERNEL.  All the callers pass GFP_KERNEL as the gfp
> flags so this doesn't affect runtime.
>
> Fixes: b3231d353a51 ("kunit: add a convenience allocation wrapper for SKBs")
> Signed-off-by: Dan Carpenter \
> ---

Nice catch, thanks.

Reviewed-by: David Gow 

Cheers,
-- David


>  include/kunit/skbuff.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/skbuff.h b/include/kunit/skbuff.h
> index 44d12370939a..345e1e8f0312 100644
> --- a/include/kunit/skbuff.h
> +++ b/include/kunit/skbuff.h
> @@ -29,7 +29,7 @@ static void kunit_action_kfree_skb(void *p)
>  static inline struct sk_buff *kunit_zalloc_skb(struct kunit *test, int len,
>gfp_t gfp)
>  {
> -   struct sk_buff *res = alloc_skb(len, GFP_KERNEL);
> +   struct sk_buff *res = alloc_skb(len, gfp);
>
> if (!res || skb_pad(res, len))
> return NULL;
> --
> 2.45.2
>


smime.p7s
Description: S/MIME Cryptographic Signature

[PATCH] kunit: skb: use "gfp" variable instead of hardcoding GFP_KERNEL

[Dan Carpenter]

The intent here was clearly to use the gfp variable flags instead of
hardcoding GFP_KERNEL.  All the callers pass GFP_KERNEL as the gfp
flags so this doesn't affect runtime.

Fixes: b3231d353a51 ("kunit: add a convenience allocation wrapper for SKBs")
Signed-off-by: Dan Carpenter 
---
 include/kunit/skbuff.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/kunit/skbuff.h b/include/kunit/skbuff.h
index 44d12370939a..345e1e8f0312 100644
--- a/include/kunit/skbuff.h
+++ b/include/kunit/skbuff.h
@@ -29,7 +29,7 @@ static void kunit_action_kfree_skb(void *p)
 static inline struct sk_buff *kunit_zalloc_skb(struct kunit *test, int len,
   gfp_t gfp)
 {
-   struct sk_buff *res = alloc_skb(len, GFP_KERNEL);
+   struct sk_buff *res = alloc_skb(len, gfp);
 
if (!res || skb_pad(res, len))
return NULL;
-- 
2.45.2