Re: [PATCH 0/6] KUnit test moves / renames

2025-02-09 Thread Stephen Rothwell 
Hi all,

On Mon, 10 Feb 2025 04:43:28 +0530 Shuah Khan  wrote:
>
> On Sun, Feb 9, 2025, 2:44 AM Kees Cook  wrote:
> 
> > On Fri, Oct 11, 2024 at 07:53:43AM -0600, Shuah Khan wrote:  
> > > On 10/11/24 01:25, David Gow wrote:  
> > > > As discussed in [1], the KUnit test naming scheme has changed to avoid
> > > > name conflicts (and tab-completion woes) with the files being tested.
> > > > These renames and moves have caused a nasty set of merge conflicts, so
> > > > this series collates and rebases them all to be applied via
> > > > mm-nonmm-unstable alongside any lib/ changes[2].
> >
> > Shall I carry this in the hardening tree? I didn't see it land in the
> > merge window, and I still don't see it in -next?
> >  
> 
> My thinking was that this series would go through Andrew's tree to avoid
> conflicts. Please take it through yours.

If they have been rebased onto mm-nonmm-unstable, then they really need
to go through Andrew' tree (since mm-nonmm-unstable gets rebased often).

-- 
Cheers,
Stephen Rothwell


pgp6J5AZ7185E.pgp
Description: OpenPGP digital signature

Re: [PATCH 0/6] KUnit test moves / renames

2025-02-08 Thread Kees Cook 
On Fri, Oct 11, 2024 at 07:53:43AM -0600, Shuah Khan wrote:
> On 10/11/24 01:25, David Gow wrote:
> > As discussed in [1], the KUnit test naming scheme has changed to avoid
> > name conflicts (and tab-completion woes) with the files being tested.
> > These renames and moves have caused a nasty set of merge conflicts, so
> > this series collates and rebases them all to be applied via
> > mm-nonmm-unstable alongside any lib/ changes[2].
> > 
> > Thanks to everyone whose patches appear here, and everyone who reviewed
> > on the original series. I hope I didn't break them too much during the
> > rebase!
> > 
> > Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ 
> > [1]
> > Link: 
> > https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
> >  [2]
> > ---
> > 
> > Bruno Sobreira França (1):
> >lib/math: Add int_log test suite
> > 
> > Diego Vieira (1):
> >lib/tests/kfifo_kunit.c: add tests for the kfifo structure
> > 
> > Gabriela Bittencourt (2):
> >unicode: kunit: refactor selftest to kunit tests
> >unicode: kunit: change tests filename and path
> > 
> > Kees Cook (1):
> >lib: Move KUnit tests into tests/ subdirectory
> > 
> > Luis Felipe Hernandez (1):
> >lib: math: Move kunit tests into tests/ subdir
> 
> 
> These look good to me. Thank you.
> 
> Acked-by: Shuah Khan 

Shall I carry this in the hardening tree? I didn't see it land in the
merge window, and I still don't see it in -next?

-Kees

-- 
Kees Cook

Re: [PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-02 Thread Rae Moar 
On Mon, Dec 2, 2024 at 2:55 AM David Gow  wrote:
>
> As discussed in [1], the KUnit test naming scheme has changed to avoid
> name conflicts (and tab-completion woes) with the files being tested.
> These renames and moves have caused a nasty set of merge conflicts, so
> this series collates and rebases them all on top of v6.13-rc1, to be
> applied minimising any further conflicts. [2,3]
>
> Thanks to everyone whose patches appear here, and everyone who reviewed
> on the original series. I hope I didn't break them too much during the
> rebase!
>

Hello!

This series looks good to me. Tests are passed both built-in and as modules.

One comment: The second patch in the series "[PATCH v2 2/6] lib/math:
Add int_log test suite" applies with a warning of an extra EOF blank
line.

Other than that small nit,

Reviewed-by: Rae Moar 

Thanks!
-Rae


> Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1]
> Link: 
> https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
>  [2]
> Link: 
> https://lore.kernel.org/linux-kselftest/CABVgOSkhD6=5k72ol_n35cuemhbsiqjz6ds+euqmjggbtvt...@mail.gmail.com/
>  [3]
>
> Bruno Sobreira França (1):
>   lib/math: Add int_log test suite
>
> Diego Vieira (1):
>   lib/tests/kfifo_kunit.c: add tests for the kfifo structure
>
> Gabriela Bittencourt (2):
>   unicode: kunit: refactor selftest to kunit tests
>   unicode: kunit: change tests filename and path
>
> Kees Cook (1):
>   lib: Move KUnit tests into tests/ subdirectory
>
> Luis Felipe Hernandez (1):
>   lib: math: Move kunit tests into tests/ subdir
>
>  MAINTAINERS   |  19 +-
>  fs/unicode/Kconfig|   5 +-
>  fs/unicode/Makefile   |   2 +-
>  fs/unicode/tests/.kunitconfig |   3 +
>  .../{utf8-selftest.c => tests/utf8_kunit.c}   | 149 ++--
>  fs/unicode/utf8-norm.c|   2 +-
>  lib/Kconfig.debug |  27 ++-
>  lib/Makefile  |  39 +--
>  lib/math/Makefile |   4 +-
>  lib/math/tests/Makefile   |   4 +-
>  lib/math/tests/int_log_kunit.c|  75 ++
>  .../rational_kunit.c} |   0
>  lib/tests/Makefile|  41 
>  lib/{ => tests}/bitfield_kunit.c  |   0
>  lib/{ => tests}/checksum_kunit.c  |   0
>  lib/{ => tests}/cmdline_kunit.c   |   0
>  lib/{ => tests}/cpumask_kunit.c   |   0
>  lib/{ => tests}/crc16_kunit.c |   0
>  lib/{ => tests}/fortify_kunit.c   |   0
>  lib/{ => tests}/hashtable_test.c  |   0
>  lib/{ => tests}/is_signed_type_kunit.c|   0
>  lib/tests/kfifo_kunit.c   | 224 ++
>  lib/{ => tests}/kunit_iov_iter.c  |   0
>  lib/{ => tests}/list-test.c   |   0
>  lib/{ => tests}/memcpy_kunit.c|   0
>  lib/{ => tests}/overflow_kunit.c  |   0
>  lib/{ => tests}/siphash_kunit.c   |   0
>  lib/{ => tests}/slub_kunit.c  |   0
>  lib/{ => tests}/stackinit_kunit.c |   0
>  lib/{ => tests}/string_helpers_kunit.c|   0
>  lib/{ => tests}/string_kunit.c|   0
>  lib/{ => tests}/test_bits.c   |   0
>  lib/{ => tests}/test_fprobe.c |   0
>  lib/{ => tests}/test_hash.c   |   0
>  lib/{ => tests}/test_kprobes.c|   0
>  lib/{ => tests}/test_linear_ranges.c  |   0
>  lib/{ => tests}/test_list_sort.c  |   0
>  lib/{ => tests}/test_sort.c   |   0
>  lib/{ => tests}/usercopy_kunit.c  |   0
>  lib/{ => tests}/util_macros_kunit.c   |   0
>  40 files changed, 459 insertions(+), 135 deletions(-)
>  create mode 100644 fs/unicode/tests/.kunitconfig
>  rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (64%)
>  create mode 100644 lib/math/tests/int_log_kunit.c
>  rename lib/math/{rational-test.c => tests/rational_kunit.c} (100%)
>  rename lib/{ => tests}/bitfield_kunit.c (100%)
>  rename lib/{ => tests}/checksum_kunit.c (100%)
>  rename lib/{ => tests}/cmdline_kunit.c (100%)
>  rename lib/{ => tests}/cpumask_kunit.c (100%)
>  rename lib/{ => tests}/crc16_kunit.c (100%)
>  rename lib/{ => tests}/fortify_kunit.c (100%)
>  rename lib/{ => tests}/hashtable_test.c (100%)
>  rename lib/{ => tests}/is_signed_type_kunit.c (100%)
>  create mode 100644 lib/tests/kfifo_kunit.c
>  rename lib/{ => tests}/kunit_iov_iter.c (100%)
>  rename lib/{ => tests}/list-test.c (100%)
>  rename lib/{ => tests}/memcpy_kunit.c (100%)
>  rename lib/{ => tests}/overflow_kunit.c (100%)
>  rename lib/{ => tests}/siphash_kunit.c (100%)
>  rename lib/{ => tests}/slub_kunit.c (100%)
>  rename lib/{ => tests}/stackinit_kunit.c (100%)
>  rename lib/{ => tests}/stri

Re: [PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-02 Thread Andy Shevchenko 
On Mon, Dec 02, 2024 at 03:55:37PM +0800, David Gow wrote:
> As discussed in [1], the KUnit test naming scheme has changed to avoid
> name conflicts (and tab-completion woes) with the files being tested.
> These renames and moves have caused a nasty set of merge conflicts, so
> this series collates and rebases them all on top of v6.13-rc1, to be
> applied minimising any further conflicts. [2,3]
> 
> Thanks to everyone whose patches appear here, and everyone who reviewed
> on the original series. I hope I didn't break them too much during the
> rebase!
> 
> Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1]
> Link: 
> https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
>  [2]
> Link: 
> https://lore.kernel.org/linux-kselftest/CABVgOSkhD6=5k72ol_n35cuemhbsiqjz6ds+euqmjggbtvt...@mail.gmail.com/
>  [3]
> 
> Bruno Sobreira França (1):
>   lib/math: Add int_log test suite
> 
> Diego Vieira (1):
>   lib/tests/kfifo_kunit.c: add tests for the kfifo structure
> 
> Gabriela Bittencourt (2):
>   unicode: kunit: refactor selftest to kunit tests
>   unicode: kunit: change tests filename and path
> 
> Kees Cook (1):
>   lib: Move KUnit tests into tests/ subdirectory
> 
> Luis Felipe Hernandez (1):
>   lib: math: Move kunit tests into tests/ subdir

Can we deduplicate test/kunit in the file names please?

See df7f9acd8646 ("platform/x86: intel: Add 'intel' prefix to the modules
automatically") for the details how to achieve that in non-verbose way.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-01 Thread David Gow 
As discussed in [1], the KUnit test naming scheme has changed to avoid
name conflicts (and tab-completion woes) with the files being tested.
These renames and moves have caused a nasty set of merge conflicts, so
this series collates and rebases them all on top of v6.13-rc1, to be
applied minimising any further conflicts. [2,3]

Thanks to everyone whose patches appear here, and everyone who reviewed
on the original series. I hope I didn't break them too much during the
rebase!

Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1]
Link: 
https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
 [2]
Link: 
https://lore.kernel.org/linux-kselftest/CABVgOSkhD6=5k72ol_n35cuemhbsiqjz6ds+euqmjggbtvt...@mail.gmail.com/
 [3]

Bruno Sobreira França (1):
  lib/math: Add int_log test suite

Diego Vieira (1):
  lib/tests/kfifo_kunit.c: add tests for the kfifo structure

Gabriela Bittencourt (2):
  unicode: kunit: refactor selftest to kunit tests
  unicode: kunit: change tests filename and path

Kees Cook (1):
  lib: Move KUnit tests into tests/ subdirectory

Luis Felipe Hernandez (1):
  lib: math: Move kunit tests into tests/ subdir

 MAINTAINERS   |  19 +-
 fs/unicode/Kconfig|   5 +-
 fs/unicode/Makefile   |   2 +-
 fs/unicode/tests/.kunitconfig |   3 +
 .../{utf8-selftest.c => tests/utf8_kunit.c}   | 149 ++--
 fs/unicode/utf8-norm.c|   2 +-
 lib/Kconfig.debug |  27 ++-
 lib/Makefile  |  39 +--
 lib/math/Makefile |   4 +-
 lib/math/tests/Makefile   |   4 +-
 lib/math/tests/int_log_kunit.c|  75 ++
 .../rational_kunit.c} |   0
 lib/tests/Makefile|  41 
 lib/{ => tests}/bitfield_kunit.c  |   0
 lib/{ => tests}/checksum_kunit.c  |   0
 lib/{ => tests}/cmdline_kunit.c   |   0
 lib/{ => tests}/cpumask_kunit.c   |   0
 lib/{ => tests}/crc16_kunit.c |   0
 lib/{ => tests}/fortify_kunit.c   |   0
 lib/{ => tests}/hashtable_test.c  |   0
 lib/{ => tests}/is_signed_type_kunit.c|   0
 lib/tests/kfifo_kunit.c   | 224 ++
 lib/{ => tests}/kunit_iov_iter.c  |   0
 lib/{ => tests}/list-test.c   |   0
 lib/{ => tests}/memcpy_kunit.c|   0
 lib/{ => tests}/overflow_kunit.c  |   0
 lib/{ => tests}/siphash_kunit.c   |   0
 lib/{ => tests}/slub_kunit.c  |   0
 lib/{ => tests}/stackinit_kunit.c |   0
 lib/{ => tests}/string_helpers_kunit.c|   0
 lib/{ => tests}/string_kunit.c|   0
 lib/{ => tests}/test_bits.c   |   0
 lib/{ => tests}/test_fprobe.c |   0
 lib/{ => tests}/test_hash.c   |   0
 lib/{ => tests}/test_kprobes.c|   0
 lib/{ => tests}/test_linear_ranges.c  |   0
 lib/{ => tests}/test_list_sort.c  |   0
 lib/{ => tests}/test_sort.c   |   0
 lib/{ => tests}/usercopy_kunit.c  |   0
 lib/{ => tests}/util_macros_kunit.c   |   0
 40 files changed, 459 insertions(+), 135 deletions(-)
 create mode 100644 fs/unicode/tests/.kunitconfig
 rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (64%)
 create mode 100644 lib/math/tests/int_log_kunit.c
 rename lib/math/{rational-test.c => tests/rational_kunit.c} (100%)
 rename lib/{ => tests}/bitfield_kunit.c (100%)
 rename lib/{ => tests}/checksum_kunit.c (100%)
 rename lib/{ => tests}/cmdline_kunit.c (100%)
 rename lib/{ => tests}/cpumask_kunit.c (100%)
 rename lib/{ => tests}/crc16_kunit.c (100%)
 rename lib/{ => tests}/fortify_kunit.c (100%)
 rename lib/{ => tests}/hashtable_test.c (100%)
 rename lib/{ => tests}/is_signed_type_kunit.c (100%)
 create mode 100644 lib/tests/kfifo_kunit.c
 rename lib/{ => tests}/kunit_iov_iter.c (100%)
 rename lib/{ => tests}/list-test.c (100%)
 rename lib/{ => tests}/memcpy_kunit.c (100%)
 rename lib/{ => tests}/overflow_kunit.c (100%)
 rename lib/{ => tests}/siphash_kunit.c (100%)
 rename lib/{ => tests}/slub_kunit.c (100%)
 rename lib/{ => tests}/stackinit_kunit.c (100%)
 rename lib/{ => tests}/string_helpers_kunit.c (100%)
 rename lib/{ => tests}/string_kunit.c (100%)
 rename lib/{ => tests}/test_bits.c (100%)
 rename lib/{ => tests}/test_fprobe.c (100%)
 rename lib/{ => tests}/test_hash.c (100%)
 rename lib/{ => tests}/test_kprobes.c (100%)
 rename lib/{ => tests}/test_linear_ranges.c (100%)
 rename lib/{ => tests}/test_list_sort.c (100%)
 rename lib/{ => tests}/test_sort.c (100%)
 rename lib/{ => tests}/usercopy_kunit.c (100%)
 rename lib/{ => tests}/util_macros_kunit.c (100%)

-- 
2.47.0.338.g60cca15819-goog

Re: [PATCH 0/6] KUnit test moves / renames

2024-10-11 Thread Shuah Khan 

On 10/11/24 01:25, David Gow wrote:

As discussed in [1], the KUnit test naming scheme has changed to avoid
name conflicts (and tab-completion woes) with the files being tested.
These renames and moves have caused a nasty set of merge conflicts, so
this series collates and rebases them all to be applied via
mm-nonmm-unstable alongside any lib/ changes[2].

Thanks to everyone whose patches appear here, and everyone who reviewed
on the original series. I hope I didn't break them too much during the
rebase!

Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1]
Link: 
https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
 [2]
---

Bruno Sobreira França (1):
   lib/math: Add int_log test suite

Diego Vieira (1):
   lib/tests/kfifo_kunit.c: add tests for the kfifo structure

Gabriela Bittencourt (2):
   unicode: kunit: refactor selftest to kunit tests
   unicode: kunit: change tests filename and path

Kees Cook (1):
   lib: Move KUnit tests into tests/ subdirectory

Luis Felipe Hernandez (1):
   lib: math: Move kunit tests into tests/ subdir



These look good to me. Thank you.

Acked-by: Shuah Khan 

thanks,
-- Shuah

[PATCH 0/6] KUnit test moves / renames

2024-10-11 Thread David Gow 
As discussed in [1], the KUnit test naming scheme has changed to avoid
name conflicts (and tab-completion woes) with the files being tested.
These renames and moves have caused a nasty set of merge conflicts, so
this series collates and rebases them all to be applied via
mm-nonmm-unstable alongside any lib/ changes[2].

Thanks to everyone whose patches appear here, and everyone who reviewed
on the original series. I hope I didn't break them too much during the
rebase!

Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1]
Link: 
https://lore.kernel.org/lkml/CABVgOSmbSzcGUi=e4pisojh3a4_0gje0faybqkjtygbe9be...@mail.gmail.com/
 [2]
---

Bruno Sobreira França (1):
  lib/math: Add int_log test suite

Diego Vieira (1):
  lib/tests/kfifo_kunit.c: add tests for the kfifo structure

Gabriela Bittencourt (2):
  unicode: kunit: refactor selftest to kunit tests
  unicode: kunit: change tests filename and path

Kees Cook (1):
  lib: Move KUnit tests into tests/ subdirectory

Luis Felipe Hernandez (1):
  lib: math: Move kunit tests into tests/ subdir

 MAINTAINERS   |  19 +-
 arch/m68k/configs/amiga_defconfig |   2 +-
 arch/m68k/configs/apollo_defconfig|   2 +-
 arch/m68k/configs/atari_defconfig |   2 +-
 arch/m68k/configs/bvme6000_defconfig  |   2 +-
 arch/m68k/configs/hp300_defconfig |   2 +-
 arch/m68k/configs/mac_defconfig   |   2 +-
 arch/m68k/configs/multi_defconfig |   2 +-
 arch/m68k/configs/mvme147_defconfig   |   2 +-
 arch/m68k/configs/mvme16x_defconfig   |   2 +-
 arch/m68k/configs/q40_defconfig   |   2 +-
 arch/m68k/configs/sun3_defconfig  |   2 +-
 arch/m68k/configs/sun3x_defconfig |   2 +-
 arch/powerpc/configs/ppc64_defconfig  |   2 +-
 fs/unicode/Kconfig|   5 +-
 fs/unicode/Makefile   |   2 +-
 fs/unicode/tests/.kunitconfig |   3 +
 .../{utf8-selftest.c => tests/utf8_kunit.c}   | 149 ++--
 fs/unicode/utf8-norm.c|   2 +-
 lib/Kconfig.debug |  31 ++-
 lib/Makefile  |  36 +--
 lib/math/Makefile |   5 +-
 lib/math/tests/Makefile   |   6 +-
 .../{test_div64.c => tests/div64_kunit.c} |   0
 lib/math/tests/int_log_kunit.c|  75 ++
 .../mul_u64_u64_div_u64_kunit.c}  |   2 +-
 .../rational_kunit.c} |   0
 lib/tests/Makefile|  39 +++
 lib/{ => tests}/bitfield_kunit.c  |   0
 lib/{ => tests}/checksum_kunit.c  |   0
 lib/{ => tests}/cmdline_kunit.c   |   0
 lib/{ => tests}/cpumask_kunit.c   |   0
 lib/{ => tests}/fortify_kunit.c   |   0
 lib/{ => tests}/hashtable_test.c  |   0
 lib/{ => tests}/is_signed_type_kunit.c|   0
 lib/tests/kfifo_kunit.c   | 224 ++
 lib/{ => tests}/kunit_iov_iter.c  |   0
 lib/{ => tests}/list-test.c   |   0
 lib/{ => tests}/memcpy_kunit.c|   0
 lib/{ => tests}/overflow_kunit.c  |   0
 lib/{ => tests}/siphash_kunit.c   |   0
 lib/{ => tests}/slub_kunit.c  |   0
 lib/{ => tests}/stackinit_kunit.c |   0
 lib/{ => tests}/string_helpers_kunit.c|   0
 lib/{ => tests}/string_kunit.c|   0
 lib/{ => tests}/test_bits.c   |   0
 lib/{ => tests}/test_fprobe.c |   0
 lib/{ => tests}/test_hash.c   |   0
 lib/{ => tests}/test_kprobes.c|   0
 lib/{ => tests}/test_linear_ranges.c  |   0
 lib/{ => tests}/test_list_sort.c  |   0
 lib/{ => tests}/test_sort.c   |   0
 lib/{ => tests}/usercopy_kunit.c  |   0
 53 files changed, 474 insertions(+), 150 deletions(-)
 create mode 100644 fs/unicode/tests/.kunitconfig
 rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (64%)
 rename lib/math/{test_div64.c => tests/div64_kunit.c} (100%)
 create mode 100644 lib/math/tests/int_log_kunit.c
 rename lib/math/{test_mul_u64_u64_div_u64.c => 
tests/mul_u64_u64_div_u64_kunit.c} (98%)
 rename lib/math/{rational-test.c => tests/rational_kunit.c} (100%)
 create mode 100644 lib/tests/Makefile
 rename lib/{ => tests}/bitfield_kunit.c (100%)
 rename lib/{ => tests}/checksum_kunit.c (100%)
 rename lib/{ => tests}/cmdline_kunit.c (100%)
 rename lib/{ => tests}/cpumask_kunit.c (100%)
 rename lib/{ => tests}/fortify_kunit.c (100%)
 rename lib/{ => tests}/hashtable_test.c (100%)
 rename lib/{ => tests}/is_signed_type_kunit.c (100%)
 create mode 100644 lib/tests/kfifo_kunit.c
 rename lib/{ => tests}/kunit_iov_iter.c (100%)
 rename lib/{ => tests}/list-test.c (100%)
 rename lib/{ => tests}/memcpy_kunit.c (100%)