Re: [PATCH 1/4] kselftest/mm: Clarify errors for pipe()

2025-06-11 Thread David Hildenbrand

On 10.06.25 16:13, Mark Brown wrote:

Specify that errors reported from pipe() failures are the result of
failures.

Suggested-by: David Hildenbrand 
Signed-off-by: Mark Brown 
---


Acked-by: David Hildenbrand 

--
Cheers,

David / dhildenb




[PATCH 1/4] kselftest/mm: Clarify errors for pipe()

2025-06-10 Thread Mark Brown
Specify that errors reported from pipe() failures are the result of
failures.

Suggested-by: David Hildenbrand 
Signed-off-by: Mark Brown 
---
 tools/testing/selftests/mm/cow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
index dbbcc5eb3dce..0adc0ab142c1 100644
--- a/tools/testing/selftests/mm/cow.c
+++ b/tools/testing/selftests/mm/cow.c
@@ -113,11 +113,11 @@ struct comm_pipes {
 static int setup_comm_pipes(struct comm_pipes *comm_pipes)
 {
if (pipe(comm_pipes->child_ready) < 0) {
-   ksft_perror("pipe()");
+   ksft_perror("pipe() failed");
return -errno;
}
if (pipe(comm_pipes->parent_ready) < 0) {
-   ksft_perror("pipe()");
+   ksft_perror("pipe() failed");
close(comm_pipes->child_ready[0]);
close(comm_pipes->child_ready[1]);
return -errno;

-- 
2.39.5