Re: [PATCH 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm

[David Hildenbrand]

On 22.05.25 19:38, Mark Brown wrote:

The cow and gup_longterm test programs open code something that looks a
lot like the standard ksft_finished() helper to summarise the test
results and provide an exit code, convert to use ksft_finished().

Signed-off-by: Mark Brown 
---


Acked-by: David Hildenbrand 

--
Cheers,

David / dhildenb

[PATCH 1/4] selftests/mm: Use standard ksft_finished() in cow and gup_longterm

[Mark Brown]

The cow and gup_longterm test programs open code something that looks a
lot like the standard ksft_finished() helper to summarise the test
results and provide an exit code, convert to use ksft_finished().

Signed-off-by: Mark Brown 
---
 tools/testing/selftests/mm/cow.c  | 7 +--
 tools/testing/selftests/mm/gup_longterm.c | 8 ++--
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
index b6cfe0a4b7df..e70cd3d900cc 100644
--- a/tools/testing/selftests/mm/cow.c
+++ b/tools/testing/selftests/mm/cow.c
@@ -1771,7 +1771,6 @@ static int tests_per_non_anon_test_case(void)
 
 int main(int argc, char **argv)
 {
-   int err;
struct thp_settings default_settings;
 
ksft_print_header();
@@ -1811,9 +1810,5 @@ int main(int argc, char **argv)
thp_restore_settings();
}
 
-   err = ksft_get_fail_cnt();
-   if (err)
-   ksft_exit_fail_msg("%d out of %d tests failed\n",
-  err, ksft_test_num());
-   ksft_exit_pass();
+   ksft_finished();
 }
diff --git a/tools/testing/selftests/mm/gup_longterm.c 
b/tools/testing/selftests/mm/gup_longterm.c
index 21595b20bbc3..e60e62809186 100644
--- a/tools/testing/selftests/mm/gup_longterm.c
+++ b/tools/testing/selftests/mm/gup_longterm.c
@@ -455,7 +455,7 @@ static int tests_per_test_case(void)
 
 int main(int argc, char **argv)
 {
-   int i, err;
+   int i;
 
pagesize = getpagesize();
nr_hugetlbsizes = detect_hugetlb_page_sizes(hugetlbsizes,
@@ -469,9 +469,5 @@ int main(int argc, char **argv)
for (i = 0; i < ARRAY_SIZE(test_cases); i++)
run_test_case(&test_cases[i]);
 
-   err = ksft_get_fail_cnt();
-   if (err)
-   ksft_exit_fail_msg("%d out of %d tests failed\n",
-  err, ksft_test_num());
-   ksft_exit_pass();
+   ksft_finished();
 }

-- 
2.39.5