Re: [PATCH V2 00/19] virtio_ring in order support
On Wed, May 28, 2025 at 8:51 PM Michael S. Tsirkin wrote: > > On Wed, May 28, 2025 at 02:42:15PM +0800, Jason Wang wrote: > > Hello all: > > > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > > virtio_ring. This is done by introducing virtqueue ops so we can > > implement separate helpers for different virtqueue layout/features > > then the in-order were implemented on top. > > > > Tests shows 3%-5% imporvment with packed virtqueue PPS with KVM guest > > testpmd on the host. > > ok this looks quite clean. We are in the merge window so not merging new > intrusive stuff, but after rc2 or so pls ping me I will put it in next. Ok, I will post a new v3 at that time since build bot found an issue. Thanks > > > Changes since V1: > > > > - use const global array of function pointers to avoid indirect > > branches to eliminate retpoline when mitigation is enabled > > - fix used length calculation when processing used ids in a batch > > - fix sparse warnings > > > > Please review. > > > > Thanks > > > > Jason Wang (19): > > virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() > > virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants > > virtio_ring: unify logic of virtqueue_poll() and more_used() > > virtio_ring: switch to use vring_virtqueue for virtqueue resize > > variants > > virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare > > variants > > virtio_ring: switch to use vring_virtqueue for virtqueue_add variants > > virtio: switch to use vring_virtqueue for virtqueue_add variants > > virtio_ring: switch to use vring_virtqueue for enable_cb_prepare > > variants > > virtio_ring: use vring_virtqueue for enable_cb_delayed variants > > virtio_ring: switch to use vring_virtqueue for disable_cb variants > > virtio_ring: switch to use vring_virtqueue for detach_unused_buf > > variants > > virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() > > virtio_ring: introduce virtqueue ops > > virtio_ring: determine descriptor flags at one time > > virtio_ring: factor out core logic of buffer detaching > > virtio_ring: factor out core logic for updating last_used_idx > > virtio_ring: factor out split indirect detaching logic > > virtio_ring: factor out split detaching logic > > virtio_ring: add in order support > > > > drivers/virtio/virtio_ring.c | 896 ++- > > 1 file changed, 684 insertions(+), 212 deletions(-) > > > > -- > > 2.31.1 >
Re: [PATCH V2 00/19] virtio_ring in order support
On Wed, May 28, 2025 at 02:42:15PM +0800, Jason Wang wrote: > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were implemented on top. > > Tests shows 3%-5% imporvment with packed virtqueue PPS with KVM guest > testpmd on the host. ok this looks quite clean. We are in the merge window so not merging new intrusive stuff, but after rc2 or so pls ping me I will put it in next. > Changes since V1: > > - use const global array of function pointers to avoid indirect > branches to eliminate retpoline when mitigation is enabled > - fix used length calculation when processing used ids in a batch > - fix sparse warnings > > Please review. > > Thanks > > Jason Wang (19): > virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() > virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants > virtio_ring: unify logic of virtqueue_poll() and more_used() > virtio_ring: switch to use vring_virtqueue for virtqueue resize > variants > virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare > variants > virtio_ring: switch to use vring_virtqueue for virtqueue_add variants > virtio: switch to use vring_virtqueue for virtqueue_add variants > virtio_ring: switch to use vring_virtqueue for enable_cb_prepare > variants > virtio_ring: use vring_virtqueue for enable_cb_delayed variants > virtio_ring: switch to use vring_virtqueue for disable_cb variants > virtio_ring: switch to use vring_virtqueue for detach_unused_buf > variants > virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() > virtio_ring: introduce virtqueue ops > virtio_ring: determine descriptor flags at one time > virtio_ring: factor out core logic of buffer detaching > virtio_ring: factor out core logic for updating last_used_idx > virtio_ring: factor out split indirect detaching logic > virtio_ring: factor out split detaching logic > virtio_ring: add in order support > > drivers/virtio/virtio_ring.c | 896 ++- > 1 file changed, 684 insertions(+), 212 deletions(-) > > -- > 2.31.1
Re: [PATCH V2 00/19] virtio_ring in order support
On Wed, May 28, 2025 at 8:42 AM Jason Wang wrote: > > Hello all: > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > virtio_ring. This is done by introducing virtqueue ops so we can > implement separate helpers for different virtqueue layout/features > then the in-order were implemented on top. > > Tests shows 3%-5% imporvment with packed virtqueue PPS with KVM guest > testpmd on the host. > > Changes since V1: > > - use const global array of function pointers to avoid indirect > branches to eliminate retpoline when mitigation is enabled > - fix used length calculation when processing used ids in a batch > - fix sparse warnings > > Please review. > Reviewed-by: Eugenio Pérez Thanks! > Thanks > > Jason Wang (19): > virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() > virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants > virtio_ring: unify logic of virtqueue_poll() and more_used() > virtio_ring: switch to use vring_virtqueue for virtqueue resize > variants > virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare > variants > virtio_ring: switch to use vring_virtqueue for virtqueue_add variants > virtio: switch to use vring_virtqueue for virtqueue_add variants > virtio_ring: switch to use vring_virtqueue for enable_cb_prepare > variants > virtio_ring: use vring_virtqueue for enable_cb_delayed variants > virtio_ring: switch to use vring_virtqueue for disable_cb variants > virtio_ring: switch to use vring_virtqueue for detach_unused_buf > variants > virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() > virtio_ring: introduce virtqueue ops > virtio_ring: determine descriptor flags at one time > virtio_ring: factor out core logic of buffer detaching > virtio_ring: factor out core logic for updating last_used_idx > virtio_ring: factor out split indirect detaching logic > virtio_ring: factor out split detaching logic > virtio_ring: add in order support > > drivers/virtio/virtio_ring.c | 896 ++- > 1 file changed, 684 insertions(+), 212 deletions(-) > > -- > 2.31.1 > >
[PATCH V2 00/19] virtio_ring in order support
Hello all: This sereis tries to implement the VIRTIO_F_IN_ORDER to virtio_ring. This is done by introducing virtqueue ops so we can implement separate helpers for different virtqueue layout/features then the in-order were implemented on top. Tests shows 3%-5% imporvment with packed virtqueue PPS with KVM guest testpmd on the host. Changes since V1: - use const global array of function pointers to avoid indirect branches to eliminate retpoline when mitigation is enabled - fix used length calculation when processing used ids in a batch - fix sparse warnings Please review. Thanks Jason Wang (19): virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants virtio_ring: unify logic of virtqueue_poll() and more_used() virtio_ring: switch to use vring_virtqueue for virtqueue resize variants virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants virtio_ring: switch to use vring_virtqueue for virtqueue_add variants virtio: switch to use vring_virtqueue for virtqueue_add variants virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants virtio_ring: use vring_virtqueue for enable_cb_delayed variants virtio_ring: switch to use vring_virtqueue for disable_cb variants virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() virtio_ring: introduce virtqueue ops virtio_ring: determine descriptor flags at one time virtio_ring: factor out core logic of buffer detaching virtio_ring: factor out core logic for updating last_used_idx virtio_ring: factor out split indirect detaching logic virtio_ring: factor out split detaching logic virtio_ring: add in order support drivers/virtio/virtio_ring.c | 896 ++- 1 file changed, 684 insertions(+), 212 deletions(-) -- 2.31.1
