Re: [PATCH V4 05/17] nvdimm/label: Skip region label during ns label DPA reservation
On 17/12/25 02:33PM, Jonathan Cameron wrote: On Wed, 19 Nov 2025 13:22:43 +0530 Neeraj Kumar wrote: If Namespace label is present in LSA during nvdimm_probe() then DPA reservation is required. But this reservation is not required by region label. Therefore if LSA scanning finds any region label, skip it. It would be good to have a little more explanation of why these two types of label put different requirements here. I'd rather not go spec diving to find out! Otherwise LGTM. Thanks Jonathan for review, I have added further explanation in commit message Regards, Neeraj
Re: [PATCH V4 05/17] nvdimm/label: Skip region label during ns label DPA reservation
On Wed, 19 Nov 2025 13:22:43 +0530 Neeraj Kumar wrote: > If Namespace label is present in LSA during nvdimm_probe() then DPA > reservation is required. But this reservation is not required by region > label. Therefore if LSA scanning finds any region label, skip it. It would be good to have a little more explanation of why these two types of label put different requirements here. I'd rather not go spec diving to find out! Otherwise LGTM. > > Signed-off-by: Neeraj Kumar > --- > drivers/nvdimm/label.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c > index 6ccc51552822..e90e48672da3 100644 > --- a/drivers/nvdimm/label.c > +++ b/drivers/nvdimm/label.c > @@ -469,6 +469,10 @@ int nd_label_reserve_dpa(struct nvdimm_drvdata *ndd) > lsa_label = to_lsa_label(ndd, slot); > nd_label = &lsa_label->ns_label; > > + /* Skip region label. DPA reservation is for NS label only */ > + if (is_region_label(ndd, lsa_label)) > + continue; > + > if (!slot_valid(ndd, lsa_label, slot)) > continue; >
Re: [PATCH V4 05/17] nvdimm/label: Skip region label during ns label DPA reservation
On 11/19/25 12:52 AM, Neeraj Kumar wrote: > If Namespace label is present in LSA during nvdimm_probe() then DPA > reservation is required. But this reservation is not required by region > label. Therefore if LSA scanning finds any region label, skip it. > > Signed-off-by: Neeraj Kumar Reviewed-by: Dave Jiang > --- > drivers/nvdimm/label.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c > index 6ccc51552822..e90e48672da3 100644 > --- a/drivers/nvdimm/label.c > +++ b/drivers/nvdimm/label.c > @@ -469,6 +469,10 @@ int nd_label_reserve_dpa(struct nvdimm_drvdata *ndd) > lsa_label = to_lsa_label(ndd, slot); > nd_label = &lsa_label->ns_label; > > + /* Skip region label. DPA reservation is for NS label only */ > + if (is_region_label(ndd, lsa_label)) > + continue; > + > if (!slot_valid(ndd, lsa_label, slot)) > continue; >
[PATCH V4 05/17] nvdimm/label: Skip region label during ns label DPA reservation
If Namespace label is present in LSA during nvdimm_probe() then DPA reservation is required. But this reservation is not required by region label. Therefore if LSA scanning finds any region label, skip it. Signed-off-by: Neeraj Kumar --- drivers/nvdimm/label.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c index 6ccc51552822..e90e48672da3 100644 --- a/drivers/nvdimm/label.c +++ b/drivers/nvdimm/label.c @@ -469,6 +469,10 @@ int nd_label_reserve_dpa(struct nvdimm_drvdata *ndd) lsa_label = to_lsa_label(ndd, slot); nd_label = &lsa_label->ns_label; + /* Skip region label. DPA reservation is for NS label only */ + if (is_region_label(ndd, lsa_label)) + continue; + if (!slot_valid(ndd, lsa_label, slot)) continue; -- 2.34.1
