Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

2025-06-17 Thread patchwork-bot+netdevbpf
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski :

On Wed, 11 Jun 2025 21:56:49 +0200 you wrote:
> Increase the coverage of a test implemented in commit 301a62dfb0d0
> ("vsock/test: Add test for UAF due to socket unbinding"). Take this
> opportunity to factor out some utility code, drop a redundant sync between
> client and server, and introduce a /proc/kallsyms harvesting logic for
> auto-detecting registered vsock transports.
> 
> Signed-off-by: Michal Luczaj 
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] vsock/test: Introduce vsock_bind_try() helper
https://git.kernel.org/netdev/net-next/c/d56a8dbff8fe
  - [net-next,v3,2/3] vsock/test: Introduce get_transports()
https://git.kernel.org/netdev/net-next/c/3070c05b7afd
  - [net-next,v3,3/3] vsock/test: Cover more CIDs in transport_uaf test
https://git.kernel.org/netdev/net-next/c/0cb6db139f39

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

2025-06-17 Thread Stefano Garzarella

On Mon, Jun 16, 2025 at 02:57:29PM -0700, Jakub Kicinski wrote:

On Wed, 11 Jun 2025 21:56:49 +0200 Michal Luczaj wrote:

Increase the coverage of a test implemented in commit 301a62dfb0d0
("vsock/test: Add test for UAF due to socket unbinding"). Take this
opportunity to factor out some utility code, drop a redundant sync between
client and server, and introduce a /proc/kallsyms harvesting logic for
auto-detecting registered vsock transports.


Hi Stefano! Sorry to ping, are these on your radar?
I'm wondering if the delay is because of devconf.cz or you consider
the Suggested-by tags a strong enough indication of support :)



Yeah, it's because devconf.cz. I'm going to review today, thanks for the 
reminder :-)


Stefano




Re: [PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

2025-06-16 Thread Jakub Kicinski
On Wed, 11 Jun 2025 21:56:49 +0200 Michal Luczaj wrote:
> Increase the coverage of a test implemented in commit 301a62dfb0d0
> ("vsock/test: Add test for UAF due to socket unbinding"). Take this
> opportunity to factor out some utility code, drop a redundant sync between
> client and server, and introduce a /proc/kallsyms harvesting logic for
> auto-detecting registered vsock transports.

Hi Stefano! Sorry to ping, are these on your radar?
I'm wondering if the delay is because of devconf.cz or you consider 
the Suggested-by tags a strong enough indication of support :)



[PATCH net-next v3 0/3] vsock/test: Improve transport_uaf test

2025-06-11 Thread Michal Luczaj
Increase the coverage of a test implemented in commit 301a62dfb0d0
("vsock/test: Add test for UAF due to socket unbinding"). Take this
opportunity to factor out some utility code, drop a redundant sync between
client and server, and introduce a /proc/kallsyms harvesting logic for
auto-detecting registered vsock transports.

Signed-off-by: Michal Luczaj 
---
Changes in v3:
- Drop "RFC" prefix, rebase, amend commit logs
- get_transports(): don't look for a symbol that was already found
- Expand testcase comments, clean up the code [Stefano]
- Streamline `enum transport` and `transport_ksyms` [Stefano]
- Move KALLSYMS_* defines from utils.h to utils.c [Stefano]
- Link to v2: 
https://lore.kernel.org/r/[email protected]

Changes in v2:
- Speed up: don't bother checking EINTR or respecting timeout on connect()s
- Introduce get_transports(), warn on unsupported setup [Stefano]
- Comment the code, drop the sync, introduce vsock_bind_try() [Stefano]
- Link to v1: 
https://lore.kernel.org/r/[email protected]

---
Michal Luczaj (3):
  vsock/test: Introduce vsock_bind_try() helper
  vsock/test: Introduce get_transports()
  vsock/test: Cover more CIDs in transport_uaf test

 tools/testing/vsock/util.c   | 80 --
 tools/testing/vsock/util.h   | 30 +
 tools/testing/vsock/vsock_test.c | 93 
 3 files changed, 181 insertions(+), 22 deletions(-)
---
base-commit: 0097c4195b1d0ca57d15979626c769c74747b5a0
change-id: 20250326-vsock-test-inc-cov-b823822bdb78

Best regards,
-- 
Michal Luczaj