Re: [PATCH v2 11/16] selftests: vDSO: parse_vdso: Drop vdso_init_from_auxv()

[Vincenzo Frascino]

On 26/02/2025 11:44, Thomas Weißschuh wrote:
> There are no users left.
> 
> This also removes the usage of ElfXX_auxv_t,
> which is not formally standardized.
> 
> Signed-off-by: Thomas Weißschuh 

Reviewed-by: Vincenzo Frascino 

> ---
>  tools/testing/selftests/vDSO/parse_vdso.c | 14 --
>  tools/testing/selftests/vDSO/parse_vdso.h |  1 -
>  2 files changed, 15 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.c 
> b/tools/testing/selftests/vDSO/parse_vdso.c
> index 
> 2fe5e983cb22f1ed066d0310a54f6aef2ed77ed8..3638fe605e80ca41b29d43c6ac452964eef35d56
>  100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.c
> +++ b/tools/testing/selftests/vDSO/parse_vdso.c
> @@ -297,17 +297,3 @@ void *vdso_sym(const char *version, const char *name)
>  
>   return 0;
>  }
> -
> -void vdso_init_from_auxv(void *auxv)
> -{
> - ELF(auxv_t) *elf_auxv = auxv;
> - for (int i = 0; elf_auxv[i].a_type != AT_NULL; i++)
> - {
> - if (elf_auxv[i].a_type == AT_SYSINFO_EHDR) {
> - vdso_init_from_sysinfo_ehdr(elf_auxv[i].a_un.a_val);
> - return;
> - }
> - }
> -
> - vdso_info.valid = false;
> -}
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.h 
> b/tools/testing/selftests/vDSO/parse_vdso.h
> index 
> de0453067d7cd0d8b63f7d3738842f60370db813..09d068ed11f97f0c5c8f4e7b341f08fa261c9735
>  100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.h
> +++ b/tools/testing/selftests/vDSO/parse_vdso.h
> @@ -26,6 +26,5 @@
>   */
>  void *vdso_sym(const char *version, const char *name);
>  void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> -void vdso_init_from_auxv(void *auxv);
>  
>  #endif
> 

-- 
Regards,
Vincenzo

[PATCH v2 11/16] selftests: vDSO: parse_vdso: Drop vdso_init_from_auxv()

[Thomas Weißschuh]

There are no users left.

This also removes the usage of ElfXX_auxv_t,
which is not formally standardized.

Signed-off-by: Thomas Weißschuh 
---
 tools/testing/selftests/vDSO/parse_vdso.c | 14 --
 tools/testing/selftests/vDSO/parse_vdso.h |  1 -
 2 files changed, 15 deletions(-)

diff --git a/tools/testing/selftests/vDSO/parse_vdso.c 
b/tools/testing/selftests/vDSO/parse_vdso.c
index 
2fe5e983cb22f1ed066d0310a54f6aef2ed77ed8..3638fe605e80ca41b29d43c6ac452964eef35d56
 100644
--- a/tools/testing/selftests/vDSO/parse_vdso.c
+++ b/tools/testing/selftests/vDSO/parse_vdso.c
@@ -297,17 +297,3 @@ void *vdso_sym(const char *version, const char *name)
 
return 0;
 }
-
-void vdso_init_from_auxv(void *auxv)
-{
-   ELF(auxv_t) *elf_auxv = auxv;
-   for (int i = 0; elf_auxv[i].a_type != AT_NULL; i++)
-   {
-   if (elf_auxv[i].a_type == AT_SYSINFO_EHDR) {
-   vdso_init_from_sysinfo_ehdr(elf_auxv[i].a_un.a_val);
-   return;
-   }
-   }
-
-   vdso_info.valid = false;
-}
diff --git a/tools/testing/selftests/vDSO/parse_vdso.h 
b/tools/testing/selftests/vDSO/parse_vdso.h
index 
de0453067d7cd0d8b63f7d3738842f60370db813..09d068ed11f97f0c5c8f4e7b341f08fa261c9735
 100644
--- a/tools/testing/selftests/vDSO/parse_vdso.h
+++ b/tools/testing/selftests/vDSO/parse_vdso.h
@@ -26,6 +26,5 @@
  */
 void *vdso_sym(const char *version, const char *name);
 void vdso_init_from_sysinfo_ehdr(uintptr_t base);
-void vdso_init_from_auxv(void *auxv);
 
 #endif

-- 
2.48.1