Re: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-12 Thread Zi Yan
On 11 Jun 2025, at 23:54, Baolin Wang wrote:

> Currently, we only test anonymous memory collapse by default. We should also
> add shmem collapse as a default test item to catch issues that could break
> the test cases.
>
> Signed-off-by: Baolin Wang 
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 4 
>  1 file changed, 4 insertions(+)
>

Acked-by: Zi Yan 


Best Regards,
Yan, Zi



Re: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-12 Thread David Hildenbrand

On 12.06.25 05:54, Baolin Wang wrote:

Currently, we only test anonymous memory collapse by default. We should also
add shmem collapse as a default test item to catch issues that could break
the test cases.

Signed-off-by: Baolin Wang 
---
  tools/testing/selftests/mm/run_vmtests.sh | 4 
  1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh 
b/tools/testing/selftests/mm/run_vmtests.sh
index 33fc7fafa8f9..a38c984103ce 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -485,6 +485,10 @@ CATEGORY="thp" run_test ./khugepaged
  
  CATEGORY="thp" run_test ./khugepaged -s 2
  
+CATEGORY="thp" run_test ./khugepaged all:shmem

+
+CATEGORY="thp" run_test ./khugepaged -s 4 all:shmem


Ahh, there we have it already, nice :)

Acked-by: David Hildenbrand 

--
Cheers,

David / dhildenb




Re: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-11 Thread Baolin Wang




On 2025/6/12 12:20, Bird, Tim wrote:

collpase in the subject line should be collapse


Good catch. Will fix the typo. Thanks.


-Original Message-
From: Baolin Wang 
Subject: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

Currently, we only test anonymous memory collapse by default. We should also 
add shmem collapse as a default test item to catch issues that
could break the test cases. Signed-off-by: Baolin Wang  --- tools/testing/selftests/mm/run_vmtests. sh

Currently, we only test anonymous memory collapse by default. We should also
add shmem collapse as a default test item to catch issues that could break
the test cases.

Signed-off-by: Baolin Wang 
---
  tools/testing/selftests/mm/run_vmtests.sh | 4 
  1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh 
b/tools/testing/selftests/mm/run_vmtests.sh
index 33fc7fafa8f9..a38c984103ce 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -485,6 +485,10 @@ CATEGORY="thp" run_test ./khugepaged

  CATEGORY="thp" run_test ./khugepaged -s 2

+CATEGORY="thp" run_test ./khugepaged all:shmem
+
+CATEGORY="thp" run_test ./khugepaged -s 4 all:shmem
+
  CATEGORY="thp" run_test ./transhuge-stress -d 20

  # Try to create XFS if not provided
--
2.43.5





Re: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-11 Thread Dev Jain



On 12/06/25 9:24 am, Baolin Wang wrote:

Currently, we only test anonymous memory collapse by default. We should also
add shmem collapse as a default test item to catch issues that could break
the test cases.

Signed-off-by: Baolin Wang 
---
  tools/testing/selftests/mm/run_vmtests.sh | 4 
  1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh 
b/tools/testing/selftests/mm/run_vmtests.sh
index 33fc7fafa8f9..a38c984103ce 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -485,6 +485,10 @@ CATEGORY="thp" run_test ./khugepaged
  
  CATEGORY="thp" run_test ./khugepaged -s 2
  
+CATEGORY="thp" run_test ./khugepaged all:shmem

+
+CATEGORY="thp" run_test ./khugepaged -s 4 all:shmem
+
  CATEGORY="thp" run_test ./transhuge-stress -d 20
  
  # Try to create XFS if not provided


Reviewed-by: Dev Jain 
Tested-by: Dev Jain 




RE: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item

2025-06-11 Thread Bird, Tim
collpase in the subject line should be collapse
 -- Tim

> -Original Message-
> From: Baolin Wang 
> Subject: [PATCH 2/2] selftests: mm: add shmem collpase as a default test item
> 
> Currently, we only test anonymous memory collapse by default. We should also 
> add shmem collapse as a default test item to catch issues that
> could break the test cases. Signed-off-by: Baolin Wang  alibaba. com> --- tools/testing/selftests/mm/run_vmtests. sh
> 
> Currently, we only test anonymous memory collapse by default. We should also
> add shmem collapse as a default test item to catch issues that could break
> the test cases.
> 
> Signed-off-by: Baolin Wang 
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh 
> b/tools/testing/selftests/mm/run_vmtests.sh
> index 33fc7fafa8f9..a38c984103ce 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -485,6 +485,10 @@ CATEGORY="thp" run_test ./khugepaged
> 
>  CATEGORY="thp" run_test ./khugepaged -s 2
> 
> +CATEGORY="thp" run_test ./khugepaged all:shmem
> +
> +CATEGORY="thp" run_test ./khugepaged -s 4 all:shmem
> +
>  CATEGORY="thp" run_test ./transhuge-stress -d 20
> 
>  # Try to create XFS if not provided
> --
> 2.43.5
>