RE: [PATCH v3 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method

[Peng Fan (OSS)]

Hi Mathieu,

> Subject: Re: [PATCH v3 11/11] remoteproc: imx_rproc: Remove enum
> imx_rproc_method
...
> >  };
> 
> After all this cleanup, please remove the goto statements in
> imx_dsp_rproc_{start,stop}(), as it was done for
> imx_rproc_{start,stop}().
> 
> This set can get in the next merge window if you send me another
> revision by tomorrow.

Thank you for the feedback and the opportunity to include this in
the next merge window.

I have sent out v4 of the patch series which includes an additional
patch to remove the goto statements in imx_dsp_rproc_{start,stop}
functions. And v4 also addresses the build warning in patch 1.

Thanks,
Peng.

Re: [PATCH v3 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method

[Mathieu Poirier]

On Tue, Nov 11, 2025 at 09:41:22AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan 
> 
> There is no user of enum imx_rproc_method after moved to ops based
> method. Remove it.
> 
> Reviewed-by: Frank Li 
> Reviewed-by: Daniel Baluta 
> Reviewed-by: Shengjiu Wang 
> Signed-off-by: Peng Fan 
> ---
>  drivers/remoteproc/imx_rproc.h | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h
> index 
> 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2ab3488281916a
>  100644
> --- a/drivers/remoteproc/imx_rproc.h
> +++ b/drivers/remoteproc/imx_rproc.h
> @@ -15,13 +15,6 @@ struct imx_rproc_att {
>   int flags;
>  };
>  
> -/* Remote core start/stop method */
> -enum imx_rproc_method {
> - IMX_RPROC_NONE,
> - /* Through ARM SMCCC */
> - IMX_RPROC_SMC,
> -};
> -
>  /* dcfg flags */
>  #define IMX_RPROC_NEED_SYSTEM_OFFBIT(0)
>  #define IMX_RPROC_NEED_CLKS  BIT(1)
> @@ -42,7 +35,6 @@ struct imx_rproc_dcfg {
>   u32 gpr_wait;
>   const struct imx_rproc_att  *att;
>   size_t  att_size;
> - enum imx_rproc_method   method;
>   u32 flags;
>   const struct imx_rproc_plat_ops *ops;
>  };

After all this cleanup, please remove the goto statements in
imx_dsp_rproc_{start,stop}(), as it was done for imx_rproc_{start,stop}().

This set can get in the next merge window if you send me another revision by
tomorrow.

Thanks,
Mathieu

> 
> -- 
> 2.37.1
>