Re: [PATCH] selftests: vDSO: align stack for O2-optimized memcpy

2024-09-27 Thread Shuah Khan 

On 9/27/24 11:24, Jason A. Donenfeld wrote:

Hi Shuah,

On Tue, Sep 24, 2024 at 01:47:23PM +0200, Jason A. Donenfeld wrote:

When switching on -O2, gcc generates SSE2 instructions that assume a
16-byte aligned stack, which the standalone test's start point wasn't
aligning. Fix this with the usual alignnent sequence.


I fixed this spelling when I apply. checkpatch is good at catching
these by the way.



Fixes: ecb8bd70d51 ("selftests: vDSO: build tests with O2 optimization")
Reported-by: kernel test robot 
Closes: 
https://lore.kernel.org/oe-lkp/202409241558.98e13f6f-oliver.s...@intel.com
Signed-off-by: Jason A. Donenfeld 
  
Just FYI, I'm expecting that this is a patch you take through your tree

for 6.12, and hopefully before rc1, as automated testing is failing.

Jason


Okay. Thanks for letting me know.

I will try to send this up for rc1 if at all possible.

Applied to linux-kselftest next

thanks,
-- Shuah

Re: [PATCH] selftests: vDSO: align stack for O2-optimized memcpy

2024-09-27 Thread Jason A. Donenfeld 
Hi Shuah,

On Tue, Sep 24, 2024 at 01:47:23PM +0200, Jason A. Donenfeld wrote:
> When switching on -O2, gcc generates SSE2 instructions that assume a
> 16-byte aligned stack, which the standalone test's start point wasn't
> aligning. Fix this with the usual alignnent sequence.
> 
> Fixes: ecb8bd70d51 ("selftests: vDSO: build tests with O2 optimization")
> Reported-by: kernel test robot 
> Closes: 
> https://lore.kernel.org/oe-lkp/202409241558.98e13f6f-oliver.s...@intel.com
> Signed-off-by: Jason A. Donenfeld 
 
Just FYI, I'm expecting that this is a patch you take through your tree
for 6.12, and hopefully before rc1, as automated testing is failing.

Jason